Skip to content

Commit 63ec065

Browse files
committed
Disable SmartLock saving when SmartLock is off.
Change-Id: I69bb08940fd94d75994e66d9a2aa83254b7cc4cb
1 parent 3dfb94b commit 63ec065

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

auth/src/main/java/com/firebase/ui/auth/ui/ExtraConstants.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,5 @@ public class ExtraConstants {
2727
public static final String EXTRA_PROFILE_PICTURE_URI = "extra_profile_picture_uri";
2828
public static final String EXTRA_PROVIDER = "extra_provider";
2929
public static final String EXTRA_SUCCESS = "success_extra";
30+
public static final String EXTRA_SMARTLOCK_ENABLED = "extra_smartlock_enabled";
3031
}

auth/src/main/java/com/firebase/ui/auth/ui/account_link/SaveCredentialsActivity.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,19 @@ public class SaveCredentialsActivity extends AppCompatBase
6060
protected void onCreate(Bundle savedInstanceState) {
6161
super.onCreate(savedInstanceState);
6262
setContentView(R.layout.save_credentials_layout);
63+
64+
// If SmartLock is not enabled, finish immediately
65+
if (!getIntent().getBooleanExtra(ExtraConstants.EXTRA_SMARTLOCK_ENABLED, true)) {
66+
finish(RESULT_OK, getIntent());
67+
return;
68+
}
69+
6370
if (!FirebaseAuthWrapperFactory.getFirebaseAuthWrapper(mActivityHelper.getAppName())
6471
.isPlayServicesAvailable(this)) {
6572
finish(RESULT_FIRST_USER, getIntent());
6673
return;
6774
}
75+
6876
mName = getIntent().getStringExtra(ExtraConstants.EXTRA_NAME);
6977
mEmail = getIntent().getStringExtra(ExtraConstants.EXTRA_EMAIL);
7078
mPassword = getIntent().getStringExtra(ExtraConstants.EXTRA_PASSWORD);
@@ -217,6 +225,7 @@ public static Intent createIntent(
217225
.putExtra(ExtraConstants.EXTRA_EMAIL, email)
218226
.putExtra(ExtraConstants.EXTRA_PASSWORD, password)
219227
.putExtra(ExtraConstants.EXTRA_PROVIDER, provider)
220-
.putExtra(ExtraConstants.EXTRA_PROFILE_PICTURE_URI, profilePictureUri);
228+
.putExtra(ExtraConstants.EXTRA_PROFILE_PICTURE_URI, profilePictureUri)
229+
.putExtra(ExtraConstants.EXTRA_SMARTLOCK_ENABLED, flowParams.smartLockEnabled);
221230
}
222231
}

auth/src/main/java/com/firebase/ui/auth/util/EmailFlowUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
public class EmailFlowUtil {
1414

1515
/**
16-
* Return and intent for either {@link EmailHintContainerActivity} or
16+
* Return an intent for either {@link EmailHintContainerActivity} or
1717
* {@link SignInNoPasswordActivity} depending on if SmartLock is enabled.
1818
*/
1919
public static Intent createIntent(Context context, FlowParameters parameters) {

0 commit comments

Comments
 (0)