Skip to content

Commit 6ddee34

Browse files
committed
feat: rename setIsSmartLockEnabled to setCredentialManagerEnabled
1 parent e004565 commit 6ddee34

File tree

2 files changed

+1
-25
lines changed

2 files changed

+1
-25
lines changed

auth/src/main/java/com/firebase/ui/auth/AuthUI.java

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1126,7 +1126,6 @@ private abstract class AuthIntentBuilder<T extends AuthIntentBuilder> {
11261126
boolean mAlwaysShowProviderChoice = false;
11271127
boolean mLockOrientation = false;
11281128
boolean mEnableCredentials = true;
1129-
boolean mEnableHints = true;
11301129
AuthMethodPickerLayout mAuthMethodPickerLayout = null;
11311130
ActionCodeSettings mPasswordSettings = null;
11321131

@@ -1250,33 +1249,17 @@ public T setDefaultProvider(@Nullable IdpConfig config) {
12501249
return (T) this;
12511250
}
12521251

1253-
/**
1254-
* Enables or disables the use of Smart Lock for Passwords in the sign in flow. To
1255-
* (en)disable hint selector and credential selector independently use {@link
1256-
* #setIsSmartLockEnabled(boolean, boolean)}
1257-
* <p>
1258-
* <p>SmartLock is enabled by default.
1259-
*
1260-
* @param enabled enables smartlock's credential selector and hint selector
1261-
*/
1262-
@NonNull
1263-
public T setIsSmartLockEnabled(boolean enabled) {
1264-
return setIsSmartLockEnabled(enabled, enabled);
1265-
}
1266-
12671252
/**
12681253
* Enables or disables the use of Smart Lock for Passwords credential selector and hint
12691254
* selector.
12701255
* <p>
12711256
* <p>Both selectors are enabled by default.
12721257
*
12731258
* @param enableCredentials enables credential selector before signup
1274-
* @param enableHints enable hint selector in respective signup screens
12751259
*/
12761260
@NonNull
1277-
public T setIsSmartLockEnabled(boolean enableCredentials, boolean enableHints) {
1261+
public T setCredentialManagerEnabled(boolean enableCredentials) {
12781262
mEnableCredentials = enableCredentials;
1279-
mEnableHints = enableHints;
12801263
return (T) this;
12811264
}
12821265

@@ -1409,7 +1392,6 @@ protected FlowParameters getFlowParams() {
14091392
mTosUrl,
14101393
mPrivacyPolicyUrl,
14111394
mEnableCredentials,
1412-
mEnableHints,
14131395
mEnableAnonymousUpgrade,
14141396
mAlwaysShowProviderChoice,
14151397
mLockOrientation,

auth/src/main/java/com/firebase/ui/auth/data/model/FlowParameters.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ public FlowParameters createFromParcel(Parcel in) {
7070
termsOfServiceUrl,
7171
privacyPolicyUrl,
7272
enableCredentials,
73-
enableHints,
7473
enableAnonymousUpgrade,
7574
alwaysShowProviderChoice,
7675
lockOrientation,
@@ -113,7 +112,6 @@ public FlowParameters[] newArray(int size) {
113112
public final ActionCodeSettings passwordResetSettings;
114113

115114
public final boolean enableCredentials;
116-
public final boolean enableHints;
117115
public final boolean enableAnonymousUpgrade;
118116
public final boolean alwaysShowProviderChoice;
119117
public final boolean lockOrientation;
@@ -130,7 +128,6 @@ public FlowParameters(
130128
@Nullable String termsOfServiceUrl,
131129
@Nullable String privacyPolicyUrl,
132130
boolean enableCredentials,
133-
boolean enableHints,
134131
boolean enableAnonymousUpgrade,
135132
boolean alwaysShowProviderChoice,
136133
boolean lockOrientation,
@@ -146,7 +143,6 @@ public FlowParameters(
146143
this.termsOfServiceUrl = termsOfServiceUrl;
147144
this.privacyPolicyUrl = privacyPolicyUrl;
148145
this.enableCredentials = enableCredentials;
149-
this.enableHints = enableHints;
150146
this.enableAnonymousUpgrade = enableAnonymousUpgrade;
151147
this.alwaysShowProviderChoice = alwaysShowProviderChoice;
152148
this.lockOrientation = lockOrientation;
@@ -172,7 +168,6 @@ public void writeToParcel(Parcel dest, int flags) {
172168
dest.writeString(termsOfServiceUrl);
173169
dest.writeString(privacyPolicyUrl);
174170
dest.writeInt(enableCredentials ? 1 : 0);
175-
dest.writeInt(enableHints ? 1 : 0);
176171
dest.writeInt(enableAnonymousUpgrade ? 1 : 0);
177172
dest.writeInt(alwaysShowProviderChoice ? 1 : 0);
178173
dest.writeInt(lockOrientation ? 1 : 0);
@@ -205,7 +200,6 @@ public boolean isAnonymousUpgradeEnabled() {
205200
public boolean isPlayServicesRequired() {
206201
// Play services only required for Google Sign In and the Credentials API
207202
return isProviderEnabled(GoogleAuthProvider.PROVIDER_ID)
208-
|| enableHints
209203
|| enableCredentials;
210204
}
211205

0 commit comments

Comments
 (0)