Skip to content

Commit 7edd9d1

Browse files
committed
Review feedback
Change-Id: I5e59666ed452d091864ea1894e2abe9e59894532
1 parent f35be2c commit 7edd9d1

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

firestore/src/main/java/com/firebase/ui/firestore/paging/FirestorePagingOptions.java

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public static final class Builder<T> {
6767
private DiffUtil.ItemCallback<DocumentSnapshot> mDiffCallback;
6868

6969
/**
70-
* Sets the query using {@link Source#SERVER} and a {@link ClassSnapshotParser} based
70+
* Sets the query using {@link Source#DEFAULT} and a {@link ClassSnapshotParser} based
7171
* on the given Class.
7272
*
7373
* See {@link #setQuery(Query, Source, PagedList.Config, SnapshotParser)}.
@@ -80,7 +80,7 @@ public Builder<T> setQuery(@NonNull Query query,
8080
}
8181

8282
/**
83-
* Sets the query using {@link Source#SERVER} and a custom {@link SnapshotParser}.
83+
* Sets the query using {@link Source#DEFAULT} and a custom {@link SnapshotParser}.
8484
*
8585
* See {@link #setQuery(Query, Source, PagedList.Config, SnapshotParser)}.
8686
*/
@@ -92,7 +92,7 @@ public Builder<T> setQuery(@NonNull Query query,
9292
}
9393

9494
/**
95-
* Sets the query using a custom {@link Source} amd a {@link ClassSnapshotParser} based
95+
* Sets the query using a custom {@link Source} and a {@link ClassSnapshotParser} based
9696
* on the given class.
9797
*
9898
* See {@link #setQuery(Query, Source, PagedList.Config, SnapshotParser)}.
@@ -106,9 +106,10 @@ public Builder<T> setQuery(@NonNull Query query,
106106
}
107107

108108
/**
109-
* Sets the Firestore query to page.
109+
* Sets the Firestore query to paginate.
110+
*
110111
* @param query the Firestore query. This query should only contain where() and
111-
* orderBy() clauses. Any limit() pr pagination clauses will cause errors.
112+
* orderBy() clauses. Any limit() or pagination clauses will cause errors.
112113
* @param source the data source to use for query data.
113114
* @param config paging configuration, passed directly to the support paging library.
114115
* @param parser the {@link SnapshotParser} to parse {@link DocumentSnapshot} into model
@@ -133,6 +134,7 @@ public Builder<T> setQuery(@NonNull Query query,
133134
* {@link DocumentSnapshot} objects.
134135
*
135136
* The default implementation is {@link DefaultSnapshotDiffCallback}.
137+
*
136138
* @return this, for chaining.
137139
*/
138140
@NonNull
@@ -142,9 +144,10 @@ public Builder<T> setDiffCallback(@NonNull DiffUtil.ItemCallback<DocumentSnapsho
142144
}
143145

144146
/**
145-
* Sets an optional {@link LifecycleOwner} to control the lifecycle of the view. Otherwise,
146-
* developer must manually call {@link FirestorePagingAdapter#startListening()}
147+
* Sets an optional {@link LifecycleOwner} to control the lifecycle of the adapter. Otherwise,
148+
* you must manually call {@link FirestorePagingAdapter#startListening()}
147149
* and {@link FirestorePagingAdapter#stopListening()}.
150+
*
148151
* @return this, for chaining.
149152
*/
150153
@NonNull

0 commit comments

Comments
 (0)