Skip to content

Commit 8240822

Browse files
authored
Restore setGithubButtonId (#1810)
1 parent 3529895 commit 8240822

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
- Fixes issue with custom parameters for OAuth providers (#1805)
2+
- Restore `setGithubButtonId` when using custom layouts (#1783)

auth/src/main/java/com/firebase/ui/auth/AuthMethodPickerLayout.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
import com.google.firebase.auth.EmailAuthProvider;
88
import com.google.firebase.auth.FacebookAuthProvider;
9+
import com.google.firebase.auth.GithubAuthProvider;
910
import com.google.firebase.auth.GoogleAuthProvider;
1011
import com.google.firebase.auth.PhoneAuthProvider;
1112
import com.google.firebase.auth.TwitterAuthProvider;
@@ -158,6 +159,12 @@ public AuthMethodPickerLayout.Builder setAnonymousButtonId(@IdRes int anonymousB
158159
return this;
159160
}
160161

162+
public AuthMethodPickerLayout.Builder setGithubButtonId(
163+
@IdRes int githubButtonId) {
164+
providersMapping.put(GithubAuthProvider.PROVIDER_ID, githubButtonId);
165+
return this;
166+
}
167+
161168
public AuthMethodPickerLayout.Builder setMicrosoftButtonId(
162169
@IdRes int microsoftButtonId) {
163170
providersMapping.put(AuthUI.MICROSOFT_PROVIDER, microsoftButtonId);

auth/src/main/java/com/firebase/ui/auth/AuthUI.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,7 @@ public final class AuthUI {
149149
public static final Set<String> SOCIAL_PROVIDERS =
150150
Collections.unmodifiableSet(new HashSet<>(Arrays.asList(
151151
GoogleAuthProvider.PROVIDER_ID,
152-
FacebookAuthProvider.PROVIDER_ID,
153-
GithubAuthProvider.PROVIDER_ID)));
152+
FacebookAuthProvider.PROVIDER_ID)));
154153

155154
@RestrictTo(RestrictTo.Scope.LIBRARY_GROUP)
156155
public static final String UNCONFIGURED_CONFIG_VALUE = "CHANGE-ME";

0 commit comments

Comments
 (0)