Fix issue 1278

Change-Id: I1ef08d498261ecfe09e0efd651814bf34f498ea8

Author: samtstern

auth/src/main/java/com/firebase/ui/auth/AuthUI.java

@@ -31,6 +31,7 @@
 
 import com.facebook.login.LoginManager;
 import com.firebase.ui.auth.data.model.FlowParameters;
+import com.firebase.ui.auth.data.remote.TwitterSignInHandler;
 import com.firebase.ui.auth.ui.idp.AuthMethodPickerActivity;
 import com.firebase.ui.auth.util.CredentialUtils;
 import com.firebase.ui.auth.util.ExtraConstants;
@@ -276,7 +277,7 @@ public static int getDefaultTheme() {
      * UI-based sign-in flow knowing it is required.
      *
      * @param context        requesting the user be signed in
-     * @param desiredConfigs to use for silent sign in. Only Google and email are currently
+     * @param configs        to use for silent sign in. Only Google and email are currently
      *                       supported, the rest will be ignored.
      * @return a task which indicates whether or not the user was successfully signed in.
      */
@@ -455,6 +456,7 @@ private Task<Void> signOutIdps(@NonNull Context context) {
             LoginManager.getInstance().logOut();
         }
         if (ProviderAvailability.IS_TWITTER_AVAILABLE) {
+            TwitterSignInHandler.initializeTwitter();
             TwitterCore.getInstance().getSessionManager().clearActiveSession();
         }
         return GoogleSignIn.getClient(context, GoogleSignInOptions.DEFAULT_SIGN_IN).signOut();

auth/src/main/java/com/firebase/ui/auth/data/remote/TwitterSignInHandler.java

@@ -33,12 +33,7 @@
 public class TwitterSignInHandler extends ProviderSignInBase<Void> {
     static {
         if (ProviderAvailability.IS_TWITTER_AVAILABLE) {
-            Context context = AuthUI.getApplicationContext();
-            Twitter.initialize(new TwitterConfig.Builder(context)
-                    .twitterAuthConfig(new TwitterAuthConfig(
-                            context.getString(R.string.twitter_consumer_key),
-                            context.getString(R.string.twitter_consumer_secret)))
-                    .build());
+            initializeTwitter();
         }
     }
 
@@ -50,6 +45,18 @@ public TwitterSignInHandler(Application application) {
         mClient = new TwitterAuthClient();
     }
 
+    public static void initializeTwitter() {
+        Context context = AuthUI.getApplicationContext();
+
+        // Note: this has no effect if Twitter is already initialized so it's safe to call
+        // multiple times.
+        Twitter.initialize(new TwitterConfig.Builder(context)
+                .twitterAuthConfig(new TwitterAuthConfig(
+                        context.getString(R.string.twitter_consumer_key),
+                        context.getString(R.string.twitter_consumer_secret)))
+                .build());
+    }
+
     private static IdpResponse createIdpResponse(
             TwitterSession session, String email, String name, Uri photoUri) {
         return new IdpResponse.Builder(

auth/src/main/java/com/firebase/ui/auth/viewmodel/ResourceObserver.java

@@ -4,6 +4,7 @@
 import android.support.annotation.NonNull;
 import android.support.annotation.RestrictTo;
 import android.support.annotation.StringRes;
+import android.util.Log;
 
 import com.firebase.ui.auth.data.model.Resource;
 import com.firebase.ui.auth.data.model.State;
@@ -34,6 +35,7 @@ private ResourceObserver(HelperActivityBase activity, FragmentBase fragment, int
     @Override
     public final void onChanged(Resource<T> resource) {
         if (resource.getState() == State.LOADING) {
+            Log.d("DIALOG", "Shown by: " + resource.toString());
             mActivity.getDialogHolder().showLoadingDialog(mLoadingMessage);
             return;
         }