Skip to content

Commit a8c0f47

Browse files
authored
Fix most Javadoc warnings (#1420)
2 parents ae3e3ad + 79ee9c1 commit a8c0f47

File tree

3 files changed

+17
-17
lines changed

3 files changed

+17
-17
lines changed

auth/src/main/java/com/firebase/ui/auth/AuthUI.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -660,7 +660,7 @@ public PhoneBuilder setDefaultCountryIso(@NonNull String iso) {
660660
* Sets the country codes available in the country code selector for phone
661661
* authentication. Takes as input a List of both country isos and codes.
662662
* This is not to be called with
663-
* {@link #setBlacklistedCountries(List<String>)}.
663+
* {@link #setBlacklistedCountries(List)}.
664664
* If both are called, an exception will be thrown.
665665
* <p>
666666
* Inputting an e-164 country code (e.g. '+1') will include all countries with
@@ -696,7 +696,7 @@ public PhoneBuilder setWhitelistedCountries(
696696
* Sets the countries to be removed from the country code selector for phone
697697
* authentication. Takes as input a List of both country isos and codes.
698698
* This is not to be called with
699-
* {@link #setWhitelistedCountries(List<String>)}.
699+
* {@link #setWhitelistedCountries(List)}.
700700
* If both are called, an exception will be thrown.
701701
* <p>
702702
* Inputting an e-164 country code (e.g. '+1') will include all countries with

auth/src/main/java/com/firebase/ui/auth/ui/email/CheckEmailFragment.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
/**
3333
* Fragment that shows a form with an email field and checks for existing accounts with that email.
3434
* <p>
35-
* Host Activities should implement {@link CheckEmailListener}.
35+
* Host Activities should implement {@link CheckEmailFragment.CheckEmailListener}.
3636
*/
3737
@RestrictTo(RestrictTo.Scope.LIBRARY_GROUP)
3838
public class CheckEmailFragment extends FragmentBase implements

build.gradle.kts

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import com.android.build.gradle.BaseExtension
2+
import com.android.build.gradle.LibraryExtension
23
import com.jfrog.bintray.gradle.BintrayExtension
34
import com.jfrog.bintray.gradle.tasks.RecordingCopyTask
45
import org.jfrog.gradle.plugin.artifactory.dsl.ArtifactoryPluginConvention
@@ -36,16 +37,6 @@ allprojects {
3637
mavenLocal()
3738
}
3839

39-
// Skip Javadoc generation for Java 1.8 as it breaks build
40-
if (JavaVersion.current().isJava8Compatible) {
41-
tasks.withType<Javadoc> {
42-
options {
43-
this as StandardJavadocDocletOptions
44-
addStringOption("Xdoclint:none", "-quiet")
45-
}
46-
}
47-
}
48-
4940
if ((group as String).isNotEmpty() && name != "lint" && name != "internal") {
5041
configureAndroid()
5142
configureQuality()
@@ -142,9 +133,18 @@ fun Project.setupPublishing() {
142133
}
143134

144135
val javadoc = task<Javadoc>("javadoc") {
145-
setSource(project.the<BaseExtension>().sourceSets["main"].java.srcDirs)
146-
classpath += configurations["compile"]
147-
classpath += project.files(project.the<BaseExtension>().bootClasspath)
136+
afterEvaluate {
137+
dependsOn(project.the<LibraryExtension>().libraryVariants.map { it.assemble })
138+
139+
setSource(project.the<BaseExtension>().sourceSets["main"].java.srcDirs)
140+
classpath += files(project.the<BaseExtension>().bootClasspath)
141+
classpath += files(project.the<LibraryExtension>().libraryVariants.map {
142+
(it.javaCompiler as AbstractCompile).classpath
143+
})
144+
}
145+
146+
// Ignore warnings about incomplete documentation
147+
(options as StandardJavadocDocletOptions).addStringOption("Xdoclint:none", "-quiet")
148148
}
149149

150150
val javadocJar = task<Jar>("javadocJar") {
@@ -199,7 +199,7 @@ fun Project.setupPublishing() {
199199
}.toTypedArray())
200200
}
201201
} else {
202-
val pomTask = "generatePomFileFor${project.name.capitalize()}LibraryPublication"
202+
val pomTask = "generatePomFileFor${name.capitalize()}LibraryPublication"
203203
task("prepareArtifacts") {
204204
dependsOn(javadocJar, sourcesJar, "assembleRelease", pomTask)
205205
}

0 commit comments

Comments
 (0)