Skip to content

Commit ad671f2

Browse files
committed
Fix possible infinite loading
Signed-off-by: Alex Saveau <[email protected]>
1 parent 4d2298b commit ad671f2

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

auth/src/main/java/com/firebase/ui/auth/util/data/ProviderUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ public static String signInMethodToProviderId(@NonNull String method) {
8484
case EmailAuthProvider.EMAIL_LINK_SIGN_IN_METHOD:
8585
return EmailAuthProvider.PROVIDER_ID;
8686
default:
87-
throw new IllegalStateException("Unknown method: + " + method);
87+
throw new IllegalStateException("Unknown method: " + method);
8888
}
8989
}
9090

auth/src/main/java/com/firebase/ui/auth/viewmodel/idp/EmailProviderResponseHandler.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,13 @@ public void onFailure(@NonNull Exception e) {
5757
// Collision with existing user email, it should be very hard for
5858
// the user to even get to this error due to CheckEmailFragment.
5959
ProviderUtils.fetchTopProvider(getAuth(), email)
60-
.addOnSuccessListener(new StartWelcomeBackFlow(email));
60+
.addOnSuccessListener(new StartWelcomeBackFlow(email))
61+
.addOnFailureListener(new OnFailureListener() {
62+
@Override
63+
public void onFailure(@NonNull Exception e) {
64+
setResult(Resource.<IdpResponse>forFailure(e));
65+
}
66+
});
6167
} else {
6268
setResult(Resource.<IdpResponse>forFailure(e));
6369
}

0 commit comments

Comments
 (0)