Tweaking twitter deps

We upgrade to twitter kit 3.0 and achieve the following
1. No more fabric deps. This shaves our sdk down even more and clears related bugs.
2. We use only twitter core and not other deps. Shaves even more.
Total savings: 0.6 MB

Change-Id: I64ae5b6c7e2f238c35e25d6b2a2b7089431a3a0a

Author: ashwinraghav

auth/build.gradle

@@ -1,5 +1,4 @@
 apply plugin: 'com.android.library'
-apply plugin: 'io.fabric'
 apply from: '../library/quality/quality.gradle'
 
 android {
@@ -45,7 +44,7 @@ dependencies {
     compile "com.google.android.gms:play-services-auth:$firebaseVersion"
 
     compile 'com.facebook.android:facebook-android-sdk:4.23.0'
-    compile("com.twitter.sdk.android:twitter:2.3.2@aar") { transitive = true }
+    compile("com.twitter.sdk.android:twitter-core:3.0.0@aar") { transitive = true }
 
     // The following libraries are needed to prevent incompatibilities with the facebook
     // library when updating com.android.support libraries:

auth/src/main/java/com/firebase/ui/auth/AuthUI.java

@@ -51,7 +51,6 @@
 import com.google.firebase.auth.GoogleAuthProvider;
 import com.google.firebase.auth.PhoneAuthProvider;
 import com.google.firebase.auth.TwitterAuthProvider;
-import com.twitter.sdk.android.Twitter;
 
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -61,8 +60,6 @@
 import java.util.List;
 import java.util.Set;
 
-import io.fabric.sdk.android.Fabric;
-
 /**
  * The entry point to the AuthUI authentication flow, and related utility methods. If your
  * application uses the default {@link FirebaseApp} instance, an AuthUI instance can be retrieved
@@ -204,8 +201,8 @@ public Void then(@NonNull Task<GoogleApiClient> task) throws Exception {
         LoginManager.getInstance().logOut();
 
         // Twitter sign out
-        if (!Fabric.isInitialized()) TwitterProvider.initialize(activity);
-        Twitter.logOut();
+        TwitterProvider.signout(activity);
+
 
         // Wait for all tasks to complete
         return Tasks.whenAll(disableCredentialsTask, googleSignOutTask);
@@ -255,8 +252,7 @@ public Task<Void> signOut(@NonNull FragmentActivity activity) {
         LoginManager.getInstance().logOut();
 
         // Twitter sign out
-        if (!Fabric.isInitialized()) TwitterProvider.initialize(activity);
-        Twitter.logOut();
+        TwitterProvider.signout(activity);
 
         // Wait for all tasks to complete
         return Tasks.whenAll(disableCredentialsTask, signOutTask);

auth/src/main/java/com/firebase/ui/auth/provider/TwitterProvider.java

@@ -11,17 +11,18 @@
 import com.firebase.ui.auth.R;
 import com.google.firebase.auth.AuthCredential;
 import com.google.firebase.auth.TwitterAuthProvider;
-import com.twitter.sdk.android.Twitter;
 import com.twitter.sdk.android.core.Callback;
 import com.twitter.sdk.android.core.Result;
+import com.twitter.sdk.android.core.Twitter;
 import com.twitter.sdk.android.core.TwitterAuthConfig;
+import com.twitter.sdk.android.core.TwitterConfig;
+import com.twitter.sdk.android.core.TwitterCore;
 import com.twitter.sdk.android.core.TwitterException;
 import com.twitter.sdk.android.core.TwitterSession;
 import com.twitter.sdk.android.core.identity.TwitterAuthClient;
 
 import java.lang.ref.WeakReference;
 
-import io.fabric.sdk.android.Fabric;
 
 public class TwitterProvider extends Callback<TwitterSession> implements IdpProvider {
     private static final String TAG = "TwitterProvider";
@@ -45,7 +46,19 @@ public static void initialize(Context context) {
         TwitterAuthConfig authConfig = new TwitterAuthConfig(
                 context.getString(R.string.twitter_consumer_key),
                 context.getString(R.string.twitter_consumer_secret));
-        Fabric.with(context.getApplicationContext(), new Twitter(authConfig));
+        TwitterConfig config = new TwitterConfig.Builder(context)
+                .twitterAuthConfig(authConfig)
+                .build();
+        Twitter.initialize(config);
+    }
+
+    public static void signout(Context context) {
+        try {
+            signOut();
+        } catch (IllegalStateException e) {
+            initialize(context);
+            signOut();
+        }
     }
 
     @Override
@@ -126,4 +139,8 @@ private IdpResponse createIdpResponse(String email) {
                     .build();
         }
     }
+
+    private static void signOut() throws IllegalStateException {
+        TwitterCore.getInstance().getSessionManager().clearActiveSession();
+    }
 }

auth/src/main/java/com/firebase/ui/auth/ui/phone/CountryListLoadTask.java

@@ -18,12 +18,13 @@
 
 package com.firebase.ui.auth.ui.phone;
 
+import android.os.AsyncTask;
+
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
 import java.util.Locale;
 
-import io.fabric.sdk.android.services.concurrency.AsyncTask;
 
 // We need to move away from ListView and AsyncTask in the future and use (say)
 // RecyclerView and Task/ThreadPoolExecutor .

build.gradle

@@ -4,13 +4,11 @@ buildscript {
     repositories {
         jcenter()
         mavenLocal()
-        maven { url 'https://maven.fabric.io/public' }
     }
 
     dependencies {
         classpath 'com.android.tools.build:gradle:2.3.1'
         classpath 'com.google.gms:google-services:3.0.0'
-        classpath 'io.fabric.tools:gradle:1.+'
         classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.7.3'
     }
 }
@@ -20,7 +18,6 @@ allprojects {
         jcenter()
         mavenLocal()
         mavenCentral()
-        maven { url 'https://maven.fabric.io/public' }
     }
 }