Fixed onAuth triggering multiple times

Author: abeisgoat

app/src/main/java/com/firebase/uidemo/RecyclerViewDemoActivity.java

@@ -86,11 +86,9 @@ public void populateViewHolder(ChatHolder chatView, Chat chat) {
                 chatView.setText(chat.getText());
 
                 if (mAuthData != null && chat.getUid().equals(mAuthData.getUid())) {
-                    // Is me
-                    chatView.setSender(true);
+                    chatView.setIsSender(true);
                 } else {
-                    chatView.setSender(false);
-                    // Isn't me
+                    chatView.setIsSender(false);
                 }
             }
         };
@@ -211,11 +209,12 @@ public ChatHolder(View itemView) {
             mView = itemView;
         }
 
-        public void setSender(Boolean isSender) {
+        public void setIsSender(Boolean isSender) {
             FrameLayout left_arrow = (FrameLayout) mView.findViewById(R.id.left_arrow);
             FrameLayout right_arrow = (FrameLayout) mView.findViewById(R.id.right_arrow);
             RelativeLayout messageContainer = (RelativeLayout) mView.findViewById(R.id.message_container);
 
+
             if (isSender) {
                 left_arrow.setVisibility(View.GONE);
                 right_arrow.setVisibility(View.VISIBLE);
@@ -224,10 +223,6 @@ public void setSender(Boolean isSender) {
                 left_arrow.setVisibility(View.VISIBLE);
                 right_arrow.setVisibility(View.GONE);
                 messageContainer.setGravity(Gravity.LEFT);
-                //GradientDrawable messageBoxBackground= (GradientDrawable) (messageBox.getBackground());
-                //messageBoxBackground.setColor(Color.MAGENTA);
-                //GradientDrawable messageArrowBackground = (GradientDrawable) (messageArrow.getBackground());
-                //messageArrowBackground.setColor(Color.MAGENTA);
 
             }
         }

app/src/main/res/layout/message.xml

@@ -2,7 +2,9 @@
 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
     android:layout_height="wrap_content"
     android:layout_width="match_parent"
-    android:id="@+id/message_container">
+    android:id="@+id/message_container"
+    android:paddingTop="5dp"
+    android:paddingBottom="5dp">
 
     <FrameLayout
         android:id="@+id/left_arrow"
@@ -21,18 +23,17 @@
         android:id="@+id/message"
         android:padding="10dp"
         android:layout_marginLeft="26dp"
-        android:layout_marginRight="26dp"
-        android:layout_marginBottom="10dp">
+        android:layout_marginRight="26dp">
 
         <TextView android:id="@+id/message_text"
-            android:layout_width="fill_parent"
+            android:layout_width="match_parent"
             android:layout_height="0dp"
             android:layout_weight="1"
             android:textStyle="bold"/>
 
         <TextView android:id="@+id/name_text"
             android:textStyle="normal"
-            android:layout_width="fill_parent"
+            android:layout_width="match_parent"
             android:layout_height="0dp"
             android:layout_weight="1" />
     </LinearLayout>

app/src/main/res/layout/recycler_view_demo.xml

@@ -13,8 +13,7 @@
         android:layout_alignParentLeft="true"
         android:layout_alignParentStart="true"
         android:layout_alignParentTop="true"
-        android:layout_above="@+id/footer"
-        />
+        android:layout_above="@+id/footer" />
 
     <LinearLayout
         android:orientation="horizontal"

library/src/main/java/com/firebase/ui/FirebaseLoginBaseActivity.java

@@ -22,6 +22,7 @@ public abstract class FirebaseLoginBaseActivity extends AppCompatActivity {
     private FacebookAuthHelper mFacebookAuthHelper;
     private TwitterAuthHelper mTwitterAuthHelper;
     private PasswordAuthHelper mPasswordAuthHelper;
+    private Firebase.AuthStateListener mAuthStateListener;
 
     TokenAuthHandler mHandler;
 
@@ -115,15 +116,28 @@ public void onProviderError(FirebaseError err) {
             }
         };
 
+        mAuthStateListener = new Firebase.AuthStateListener() {
+            @Override
+            public void onAuthStateChanged(AuthData authData) {
+                if (authData != null) {
+                    mChosenProvider = SocialProvider.valueOf(authData.getProvider());
+                    onFirebaseLoginSuccess(authData);
+                    Log.d(TAG, "Auth data changed");
+                } else {
+                    onFirebaseLogout();
+                }
+            }
+        };
+
         mFacebookAuthHelper = new FacebookAuthHelper(this, getFirebaseRef(), mHandler);
         mGoogleAuthHelper = new GoogleAuthHelper(this, getFirebaseRef(), mHandler);
         mTwitterAuthHelper = new TwitterAuthHelper(this, getFirebaseRef(), mHandler);
         mPasswordAuthHelper = new PasswordAuthHelper(this, getFirebaseRef(), mHandler);
 
         mDialog = new FirebaseLoginDialog();
         mDialog
-                .setContext(this)
-                .setRef(getFirebaseRef())
+            .setContext(this)
+            .setRef(getFirebaseRef())
             .setHandler(mHandler);
 
         mDialog
@@ -132,18 +146,11 @@ public void onProviderError(FirebaseError err) {
             .setProviderEnabled(SocialProvider.twitter)
             .setProviderEnabled(SocialProvider.password);
 
-        // TODO: should we remove the authStateListener on `onStop()`?
-        getFirebaseRef().addAuthStateListener(new Firebase.AuthStateListener() {
-            @Override
-            public void onAuthStateChanged(AuthData authData) {
-                if (authData != null) {
-                    mChosenProvider = SocialProvider.valueOf(authData.getProvider());
-                    onFirebaseLoginSuccess(authData);
-                    Log.d(TAG, "Auth data changed");
-                } else {
-                    onFirebaseLogout();
-                }
-            }
-        });
+        getFirebaseRef().addAuthStateListener(mAuthStateListener);
+    }
+
+    protected void onStop() {
+        super.onStop();
+        getFirebaseRef().removeAuthStateListener(mAuthStateListener);
     }
 }

library/src/main/java/com/firebase/ui/FirebaseLoginDialog.java

@@ -58,11 +58,8 @@ public void onActivityResult(int requestCode, int resultCode, Intent data) {
     @Override
     public Dialog onCreateDialog(Bundle savedInstanceState) {
         AlertDialog.Builder builder = new AlertDialog.Builder(getActivity());
-        // Get the layout inflater
         LayoutInflater inflater = getActivity().getLayoutInflater();
 
-        // Inflate and set the layout for the dialog
-        // Pass null as the parent view because its going in the dialog layout
         mView = inflater.inflate(R.layout.fragment_firebase_login, null);
 
         if (mFacebookAuthHelper != null) showLoginOption(mFacebookAuthHelper, R.id.facebook_button);

library/src/main/java/com/firebase/ui/auth/FirebaseAuthHelper.java

@@ -29,7 +29,7 @@ private void authenticateRefWithOAuthFirebasetoken(FirebaseOAuthToken token, fin
         Firebase.AuthResultHandler authResultHandler = new Firebase.AuthResultHandler() {
             @Override
             public void onAuthenticated(AuthData authData) {
-                // Do nothing. Auth updates are handled in the AuthStateListener
+                Log.d("Helper", "GO GO GO");
                 handler.onSuccess(authData);
             }
 

library/src/main/java/com/firebase/ui/auth/TwitterAuthHelper.java

@@ -3,6 +3,7 @@
 import android.app.Activity;
 import android.content.Context;
 import android.content.Intent;
+import android.util.Log;
 
 import com.firebase.client.Firebase;
 import com.firebase.client.FirebaseError;