Skip to content

Commit ca4a5fb

Browse files
committed
Merge branch 'feat/P2' of github.com:demolaf/FirebaseUI-Android into feat/S3
2 parents d4b0fbb + edbf241 commit ca4a5fb

File tree

2 files changed

+0
-26
lines changed

2 files changed

+0
-26
lines changed

auth/src/main/java/com/firebase/ui/auth/compose/configuration/auth_provider/AuthProvider.kt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -109,11 +109,6 @@ abstract class AuthProvider(open val providerId: String) {
109109
* @param displayName The display name to set (if current is empty)
110110
* @param photoUri The photo URL to set (if current is null)
111111
*
112-
* **Old library reference:**
113-
* - ProfileMerger.java:34-56 (complete implementation)
114-
* - ProfileMerger.java:39-43 (only update if profile incomplete)
115-
* - ProfileMerger.java:49-55 (updateProfile call)
116-
*
117112
* **Note:** This operation always succeeds to minimize login interruptions.
118113
* Failures are logged but don't prevent sign-in completion.
119114
*/
@@ -149,7 +144,6 @@ abstract class AuthProvider(open val providerId: String) {
149144
}
150145
} catch (e: Exception) {
151146
// Log error but don't throw - profile update failure shouldn't prevent sign-in
152-
// Old library uses TaskFailureLogger for this
153147
Log.e("AuthProvider.Email", "Error updating profile", e)
154148
}
155149
}

auth/src/main/java/com/firebase/ui/auth/compose/util/EmailLinkPersistenceManager.kt

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -36,19 +36,13 @@ private val Context.dataStore: DataStore<Preferences> by preferencesDataStore(na
3636
* - Anonymous user ID for upgrade flows
3737
* - Social provider credentials for linking flows
3838
*
39-
* **Old library reference:**
40-
* - EmailLinkPersistenceManager.java (complete implementation)
41-
*
4239
* @since 10.0.0
4340
*/
4441
object EmailLinkPersistenceManager {
4542

4643
/**
4744
* Saves email and session information to DataStore for email link sign-in.
4845
*
49-
* **Old library reference:**
50-
* - EmailLinkPersistenceManager.java:47-59 (saveEmail method)
51-
*
5246
* @param context Android context for DataStore access
5347
* @param email Email address to save
5448
* @param sessionId Unique session identifier for same-device validation
@@ -74,11 +68,6 @@ object EmailLinkPersistenceManager {
7468
* but an email link account with the same email already exists. The credential is saved
7569
* and will be linked after the user completes email link authentication.
7670
*
77-
* **Old library reference:**
78-
* - EmailLinkPersistenceManager.java:61-80 (saveIdpResponseForLinking method)
79-
* - SocialProviderResponseHandler.java:144-152 (caller - redirects to email link flow)
80-
* - EmailActivity.java:92-93 (caller - saves credential before showing email link UI)
81-
*
8271
* @param context Android context for DataStore access
8372
* @param providerType Provider ID ("google.com", "facebook.com", etc.)
8473
* @param idToken ID token from the provider
@@ -100,9 +89,6 @@ object EmailLinkPersistenceManager {
10089
/**
10190
* Retrieves session information from DataStore.
10291
*
103-
* **Old library reference:**
104-
* - EmailLinkPersistenceManager.java:82-110 (retrieveSessionRecord method)
105-
*
10692
* @param context Android context for DataStore access
10793
* @return SessionRecord containing saved session data, or null if no session exists
10894
*/
@@ -142,9 +128,6 @@ object EmailLinkPersistenceManager {
142128
/**
143129
* Clears all saved data from DataStore.
144130
*
145-
* **Old library reference:**
146-
* - EmailLinkPersistenceManager.java:112-121 (clearAllData method)
147-
*
148131
* @param context Android context for DataStore access
149132
*/
150133
suspend fun clear(context: Context) {
@@ -161,9 +144,6 @@ object EmailLinkPersistenceManager {
161144
/**
162145
* Holds the necessary information to complete the email link sign in flow.
163146
*
164-
* **Old library reference:**
165-
* - EmailLinkPersistenceManager.SessionRecord (lines 123-164)
166-
*
167147
* @property sessionId Unique session identifier for same-device validation
168148
* @property email Email address for sign-in
169149
* @property anonymousUserId Optional anonymous user ID for upgrade flows

0 commit comments

Comments
 (0)