Fix NoSuchMethodException

Author: SUPERCILEX

auth/README.md

@@ -156,8 +156,6 @@ startActivityForResult(
     RC_SIGN_IN);
 ```
 
-To enable all supported providers in their basic configuration, use `setProviders(AuthUI.ALL_PROVIDERS)`
-
 If a terms of service URL and a custom theme are required:
 
 ```java

auth/build.gradle

@@ -32,13 +32,13 @@ android {
 
 dependencies {
     testCompile 'junit:junit:4.12'
-    testCompile 'org.mockito:mockito-core:2.2.0'
+    testCompile 'org.mockito:mockito-core:2.2.2'
     testCompile 'org.robolectric:robolectric:3.1.2'
     // See https://github.com/robolectric/robolectric/issues/1932#issuecomment-219796474
     testCompile 'org.khronos:opengl-api:gl1.1-android-2.1_r1'
 
-    compile 'com.facebook.android:facebook-android-sdk:4.14.1'
-    compile("com.twitter.sdk.android:twitter:2.0.0@aar") {
+    compile 'com.facebook.android:facebook-android-sdk:4.17.0'
+    compile("com.twitter.sdk.android:twitter:2.1.1@aar") {
         transitive = true;
     }
     compile "com.android.support:design:${project.ext.support_library_version}"

auth/src/main/AndroidManifest.xml

@@ -9,6 +9,9 @@
         <meta-data
             android:name="com.google.android.gms.version"
             android:value="@integer/google_play_services_version" />
+        <meta-data
+            android:name="io.fabric.ApiKey"
+            android:value="@string/twitter_consumer_secret"/>
 
         <activity
             android:name="com.firebase.ui.auth.ui.email.ConfirmRecoverPasswordActivity"

auth/src/main/java/com/firebase/ui/auth/AuthUI.java

@@ -265,16 +265,6 @@ public class AuthUI {
                     TWITTER_PROVIDER
             )));
 
-    /**
-     * The list of all supported authentication providers in Firebase Auth UI in their basic
-     * {@link IdpConfig} form.
-     */
-    public static final List<IdpConfig> ALL_PROVIDERS =
-            Arrays.asList(new AuthUI.IdpConfig.Builder(AuthUI.EMAIL_PROVIDER).build(),
-                          new AuthUI.IdpConfig.Builder(AuthUI.GOOGLE_PROVIDER).build(),
-                          new AuthUI.IdpConfig.Builder(AuthUI.FACEBOOK_PROVIDER).build(),
-                          new AuthUI.IdpConfig.Builder(AuthUI.TWITTER_PROVIDER).build());
-
     private static final IdentityHashMap<FirebaseApp, AuthUI> INSTANCES = new IdentityHashMap<>();
 
     private final FirebaseApp mApp;

auth/src/main/java/com/firebase/ui/auth/provider/FacebookProvider.java

@@ -19,6 +19,7 @@
 import android.content.Intent;
 import android.os.Bundle;
 import android.util.Log;
+
 import com.facebook.CallbackManager;
 import com.facebook.FacebookCallback;
 import com.facebook.FacebookException;
@@ -34,11 +35,13 @@
 import com.firebase.ui.auth.R;
 import com.google.firebase.auth.AuthCredential;
 import com.google.firebase.auth.FacebookAuthProvider;
-import java.util.ArrayList;
-import java.util.List;
+
 import org.json.JSONException;
 import org.json.JSONObject;
 
+import java.util.ArrayList;
+import java.util.List;
+
 public class FacebookProvider implements IdpProvider, FacebookCallback<LoginResult> {
     protected static final String ERROR = "err";
     protected static final String ERROR_MSG = "err_msg";

auth/src/main/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivity.java

@@ -89,18 +89,18 @@ private void populateIdpList(List<IdpConfig> providers) {
         mIdpProviders = new ArrayList<>();
         for (IdpConfig idpConfig : providers) {
             switch (idpConfig.getProviderId()) {
-                case AuthUI.FACEBOOK_PROVIDER:
-                    mIdpProviders.add(new FacebookProvider(this, idpConfig));
-                    break;
                 case AuthUI.GOOGLE_PROVIDER:
                     mIdpProviders.add(new GoogleProvider(this, idpConfig));
                     break;
-                case AuthUI.EMAIL_PROVIDER:
-                    findViewById(R.id.email_provider).setVisibility(View.VISIBLE);
+                case AuthUI.FACEBOOK_PROVIDER:
+                    mIdpProviders.add(new FacebookProvider(this, idpConfig));
                     break;
                 case AuthUI.TWITTER_PROVIDER:
                     mIdpProviders.add(new TwitterProvider(this));
                     break;
+                case AuthUI.EMAIL_PROVIDER:
+                    findViewById(R.id.email_provider).setVisibility(View.VISIBLE);
+                    break;
                 default:
                     if (BuildConfig.DEBUG) {
                         Log.d(TAG, "Encountered unknown IDPProvider parcel with type: "

auth/src/main/java/com/firebase/ui/auth/util/FirebaseAuthWrapperImpl.java

@@ -14,7 +14,6 @@
 
 package com.firebase.ui.auth.util;
 
-import android.app.Fragment;
 import android.app.PendingIntent;
 import android.content.Context;
 import android.os.Bundle;
@@ -61,7 +60,7 @@ public FirebaseAuthWrapperImpl(@NonNull FirebaseAuth firebaseAuth) {
         if (firebaseAuth == null) {
             throw new IllegalArgumentException("firebaseAuth must not be null");
         }
-        this.mFirebaseAuth = firebaseAuth;
+        mFirebaseAuth = firebaseAuth;
     }
 
     @Override

common/constants.gradle

@@ -1,7 +1,5 @@
 project.ext.firebase_version = '9.8.0'
-// use caution when updating support library version, v25.0.0 caused issues
-// with the Facebook SDK. (NoSuchMethodError startActivity)
-project.ext.support_library_version = '24.2.1'
+project.ext.support_library_version = '25.0.0'
 
 project.ext.submodules = ['database', 'auth', 'storage']
 project.ext.group = 'com.firebaseui'