Simple review feedback

Change-Id: I7a60cd497bc00b6b9e6f92b44df1527725d96daa

Author: samtstern

auth/src/main/java/com/firebase/ui/auth/ui/InvisibleActivityBase.java

@@ -10,21 +10,21 @@
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.FrameLayout;
-import android.widget.ProgressBar;
 
 import com.firebase.ui.auth.R;
 
+import me.zhanghai.android.materialprogressbar.MaterialProgressBar;
 
 /**
  * Base classes for activities that are just simple overlays.
  */
 @RestrictTo(RestrictTo.Scope.LIBRARY_GROUP)
 public class InvisibleActivityBase extends HelperActivityBase {
 
-    private static final long MIN_SPINNER_MS = 1000;
+    private static final long MIN_SPINNER_MS = 750;
 
     private Handler mHandler = new Handler();
-    private ProgressBar mProgressBar;
+    private MaterialProgressBar mProgressBar;
     private long mLastShownTime = 0;
 
     @Override
@@ -33,9 +33,9 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
         setContentView(R.layout.fui_activity_invisible);
 
         // Create an indeterminate, circular progress bar in the app's theme
-        mProgressBar = new ProgressBar(new ContextThemeWrapper(this, getFlowParams().themeId));
+        mProgressBar = new MaterialProgressBar(new ContextThemeWrapper(this, getFlowParams().themeId));
         mProgressBar.setIndeterminate(true);
-        mProgressBar.setVisibility(View.INVISIBLE);
+        mProgressBar.setVisibility(View.GONE);
 
         // Set bar to float in the center
         FrameLayout.LayoutParams params = new FrameLayout.LayoutParams(
@@ -64,7 +64,7 @@ public void hideProgress() {
             @Override
             public void run() {
                 mLastShownTime = 0;
-                mProgressBar.setVisibility(View.INVISIBLE);
+                mProgressBar.setVisibility(View.GONE);
             }
         });
     }
@@ -83,6 +83,10 @@ public void run() {
     private void doAfterTimeout(Runnable runnable) {
         long currentTime = System.currentTimeMillis();
         long diff = currentTime - mLastShownTime;
+
+        // 'diff' is how long it's been since we showed the spinner, so in the
+        // case where diff is greater than our minimum spinner duration then our
+        // remaining wait time is 0.
         long remaining = Math.max(MIN_SPINNER_MS - diff, 0);
 
         mHandler.postDelayed(runnable, remaining);

auth/src/main/res/layout-land/fui_auth_method_picker_layout.xml

@@ -12,9 +12,8 @@
     <me.zhanghai.android.materialprogressbar.MaterialProgressBar
         android:id="@+id/top_progress_bar"
         style="@style/FirebaseUI.TopProgressBar"
-        android:visibility="invisible"
         app:layout_constraintTop_toTopOf="parent"
-        tools:visibility="visible"/>
+        tools:visibility="visible" />
 
     <ImageView
         android:id="@+id/logo"

auth/src/main/res/layout/fui_auth_method_picker_layout.xml

@@ -12,9 +12,8 @@
     <me.zhanghai.android.materialprogressbar.MaterialProgressBar
         android:id="@+id/top_progress_bar"
         style="@style/FirebaseUI.TopProgressBar"
-        android:visibility="invisible"
         app:layout_constraintTop_toTopOf="parent"
-        tools:visibility="visible"/>
+        tools:visibility="visible" />
 
     <ImageView
         android:id="@+id/logo"

auth/src/main/res/layout/fui_check_email_layout.xml

@@ -14,7 +14,6 @@
         <me.zhanghai.android.materialprogressbar.MaterialProgressBar
             android:id="@+id/top_progress_bar"
             style="@style/FirebaseUI.TopProgressBar"
-            android:visibility="invisible"
             tools:visibility="visible" />
 
         <LinearLayout

auth/src/main/res/layout/fui_register_email_layout.xml

@@ -14,7 +14,6 @@
         <me.zhanghai.android.materialprogressbar.MaterialProgressBar
             android:id="@+id/top_progress_bar"
             style="@style/FirebaseUI.TopProgressBar"
-            android:visibility="invisible"
             tools:visibility="visible" />
 
         <LinearLayout

auth/src/main/res/layout/fui_welcome_back_idp_prompt_layout.xml

@@ -13,7 +13,6 @@
         <me.zhanghai.android.materialprogressbar.MaterialProgressBar
             android:id="@+id/top_progress_bar"
             style="@style/FirebaseUI.TopProgressBar"
-            android:visibility="invisible"
             tools:visibility="visible" />
 
         <LinearLayout

auth/src/main/res/layout/fui_welcome_back_password_prompt_layout.xml

@@ -14,7 +14,6 @@
         <me.zhanghai.android.materialprogressbar.MaterialProgressBar
             android:id="@+id/top_progress_bar"
             style="@style/FirebaseUI.TopProgressBar"
-            android:visibility="invisible"
             tools:visibility="visible" />
 
         <android.support.constraint.ConstraintLayout

auth/src/main/res/values/styles.xml

@@ -234,6 +234,7 @@
         <item name="android:layout_width">match_parent</item>
         <item name="android:layout_height">4dp</item>
         <item name="android:indeterminate">true</item>
+        <item name="android:visibility">gone</item>
         <item name="mpb_progressStyle">horizontal</item>
         <item name="mpb_useIntrinsicPadding">false</item>
     </style>