Merge pull request #612 from vieck/enhancement-taskfailurelogger

samtstern · web-flow · commit f2e3cc185b5a · 2017-02-27T11:31:02.000-05:00
Enhanced TaskFailureLogger Credentials Logging #341
diff --git a/auth/src/main/java/com/firebase/ui/auth/ui/accountlink/WelcomeBackIdpPrompt.java b/auth/src/main/java/com/firebase/ui/auth/ui/accountlink/WelcomeBackIdpPrompt.java
@@ -158,7 +158,7 @@ public void onSuccess(AuthResult result) {
                                 result.getUser()
                                         .linkWithCredential(mPrevCredential)
                                         .addOnFailureListener(new TaskFailureLogger(
-                                                TAG, "Error signing in with previous credential"))
+                                                TAG, "Error signing in with previous credential " + idpResponse.getProviderType()))
                                         .addOnCompleteListener(new FinishListener(idpResponse));
                             } else {
                                 finish(ResultCodes.OK, IdpResponse.getIntent(idpResponse));
@@ -172,12 +172,12 @@ public void onFailure(@NonNull Exception e) {
                         }
                     })
                     .addOnFailureListener(
-                            new TaskFailureLogger(TAG, "Error signing in with new credential"));
+                            new TaskFailureLogger(TAG, "Error signing in with new credential " + idpResponse.getProviderType()));
         } else {
             currentUser
                     .linkWithCredential(newCredential)
                     .addOnFailureListener(
-                            new TaskFailureLogger(TAG, "Error linking with credential"))
+                            new TaskFailureLogger(TAG, "Error linking with credential " + idpResponse.getProviderType()))
                     .addOnCompleteListener(new FinishListener(idpResponse));
         }
     }
diff --git a/auth/src/main/java/com/firebase/ui/auth/ui/accountlink/WelcomeBackPasswordPrompt.java b/auth/src/main/java/com/firebase/ui/auth/ui/accountlink/WelcomeBackPasswordPrompt.java
@@ -152,7 +152,7 @@ public void onSuccess(AuthResult authResult) {
                             authResult.getUser()
                                     .linkWithCredential(authCredential)
                                     .addOnFailureListener(new TaskFailureLogger(
-                                            TAG, "Error signing in with credential"))
+                                            TAG, "Error signing in with credential " + authCredential.getProvider()))
                                     .addOnSuccessListener(new OnSuccessListener<AuthResult>() {
                                         @Override
                                         public void onSuccess(AuthResult authResult) {
diff --git a/auth/src/main/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivity.java b/auth/src/main/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivity.java
@@ -167,7 +167,7 @@ public void onSuccess(final IdpResponse response) {
         mActivityHelper.getFirebaseAuth()
                 .signInWithCredential(credential)
                 .addOnFailureListener(
-                        new TaskFailureLogger(TAG, "Firebase sign in with credential unsuccessful"))
+                        new TaskFailureLogger(TAG, "Firebase sign in with credential " + credential.getProvider() + " unsuccessful. Visit https://console.firebase.google.com to enable it."))
                 .addOnCompleteListener(new CredentialSignInHandler(
                         this,
                         mActivityHelper,
diff --git a/auth/src/main/java/com/firebase/ui/auth/ui/idp/CredentialSignInHandler.java b/auth/src/main/java/com/firebase/ui/auth/ui/idp/CredentialSignInHandler.java
@@ -90,7 +90,7 @@ public void onFailure(@NonNull Exception e) {
                     return;
                 }
             } else {
-                Log.e(TAG, "Unexpected exception when signing in with credential",
+                Log.e(TAG, "Unexpected exception when signing in with credential " + mResponse.getProviderType() + " unsuccessful. Visit https://console.firebase.google.com to enable it.",
                       task.getException());
             }
             mHelper.dismissDialog();
diff --git a/auth/src/main/java/com/firebase/ui/auth/util/signincontainer/IdpSignInContainer.java b/auth/src/main/java/com/firebase/ui/auth/util/signincontainer/IdpSignInContainer.java
@@ -134,7 +134,7 @@ public void onSuccess(final IdpResponse response) {
         mHelper.getFirebaseAuth()
                 .signInWithCredential(credential)
                 .addOnFailureListener(
-                        new TaskFailureLogger(TAG, "Failure authenticating with credential"))
+                        new TaskFailureLogger(TAG, "Failure authenticating with credential " + credential.getProvider()))
                 .addOnCompleteListener(new CredentialSignInHandler(
                         getActivity(),
                         mHelper,

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ public void onFailure(@NonNull Exception e) {`
`90`	`90`	`return;`
`91`	`91`	`}`
`92`	`92`	`} else {`
`93`		`- Log.e(TAG, "Unexpected exception when signing in with credential",`
	`93`	`+ Log.e(TAG, "Unexpected exception when signing in with credential " + mResponse.getProviderType() + " unsuccessful. Visit https://console.firebase.google.com to enable it.",`
`94`	`94`	`task.getException());`
`95`	`95`	`}`
`96`	`96`	`mHelper.dismissDialog();`