feat: Email Provider Integration #2233
Open
+2,266
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demolaf
force-pushed
the
feat/P2
branch
7 times, most recently
from
a841656 to
5bd8c7c
Compare
- added: sign in, sign up, reset password, email link and anonymous auto upgrade - upgrade mockito - fixed spying mocked objects in new library test error
Lyokone
reviewed
Oct 8, 2025
Comment on lines
+113
to
+117
| * **Old library reference:** | ||
| * - EmailProviderResponseHandler.java:42-84 (startSignIn implementation) | ||
| * - AuthOperationManager.java:64-74 (createOrLinkUserWithEmailAndPassword) | ||
| * - RegisterEmailFragment.java:270-287 (validation and triggering sign-up) | ||
| * - ProfileMerger.java:34-56 (profile merging after sign-up) |
There was a problem hiding this comment.
We can delete those kind of comments
Lyokone
reviewed
Oct 8, 2025
| } | ||
| } else { | ||
| // Non-anonymous collision: could be same email different provider | ||
| // TODO: Fetch providers and emit AuthState.RequiresSignIn |
There was a problem hiding this comment.
Being able to fetch providers per email is now deprecated, so let's remove this feature and just let the FirebaseAuth library handle that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.