refactor: add phone auth to deleteUser + put in same protocol

Author: russellwheatley

FirebaseSwiftUI/FirebaseAppleSwiftUI/Sources/Services/AppleProviderAuthUI.swift

@@ -114,7 +114,7 @@ extension AuthenticateWithAppleDialog: ASAuthorizationControllerDelegate {
 
 // MARK: - Apple Provider Swift
 
-public class AppleProviderSwift: AuthProviderSwift, DeleteUserSwift {
+public class AppleProviderSwift: AuthProviderSwift {
   public let scopes: [ASAuthorization.Scope]
   let providerId = "apple.com"
 

FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Services/AuthService.swift

@@ -17,6 +17,7 @@ import SwiftUI
 
 public protocol AuthProviderSwift {
   @MainActor func createAuthCredential() async throws -> AuthCredential
+  @MainActor func deleteUser(user: User) async throws
 }
 
 public protocol AuthProviderUI {
@@ -25,10 +26,6 @@ public protocol AuthProviderUI {
   var provider: AuthProviderSwift { get }
 }
 
-public protocol DeleteUserSwift {
-  @MainActor func deleteUser(user: User) async throws
-}
-
 public protocol PhoneAuthProviderSwift: AuthProviderSwift {
   @MainActor func verifyPhoneNumber(phoneNumber: String) async throws -> String
 }
@@ -282,13 +279,12 @@ public extension AuthService {
           let operation = EmailPasswordDeleteUserOperation(passwordPrompt: passwordPrompt)
           try await operation(on: user)
         } else {
-          // Find provider by matching ID and ensure it can delete users
-          guard let matchingProvider = providers.first(where: { $0.id == providerId }),
-                let provider = matchingProvider.provider as? DeleteUserSwift else {
+          // Find provider by matching ID
+          guard let matchingProvider = providers.first(where: { $0.id == providerId }) else {
             throw AuthServiceError.providerNotFound("No provider found for \(providerId)")
           }
 
-          try await provider.deleteUser(user: user)
+          try await matchingProvider.provider.deleteUser(user: user)
         }
       }
     } catch {

FirebaseSwiftUI/FirebaseFacebookSwiftUI/Sources/Services/FacebookProviderAuthUI.swift

@@ -19,7 +19,7 @@ import FirebaseAuth
 import FirebaseAuthSwiftUI
 import SwiftUI
 
-public class FacebookProviderSwift: AuthProviderSwift, DeleteUserSwift {
+public class FacebookProviderSwift: AuthProviderSwift {
   let scopes: [String]
   let providerId = "facebook.com"
   private let loginManager = LoginManager()

FirebaseSwiftUI/FirebaseGoogleSwiftUI/Sources/Services/GoogleProviderAuthUI.swift

@@ -19,7 +19,7 @@ import GoogleSignIn
 import GoogleSignInSwift
 import SwiftUI
 
-public class GoogleProviderSwift: AuthProviderSwift, DeleteUserSwift {
+public class GoogleProviderSwift: AuthProviderSwift {
   let scopes: [String]
   let clientID: String
   let providerId = "google.com"

FirebaseSwiftUI/FirebaseOAuthSwiftUI/Sources/Services/OAuthProviderSwift.swift

@@ -18,7 +18,7 @@ import FirebaseCore
 import SwiftUI
 
 /// Configuration for a generic OAuth provider
-public class OAuthProviderSwift: AuthProviderSwift, DeleteUserSwift {
+public class OAuthProviderSwift: AuthProviderSwift {
   public let providerId: String
   public let scopes: [String]
   public let customParameters: [String: String]

FirebaseSwiftUI/FirebasePhoneAuthSwiftUI/Sources/Services/PhoneAuthProviderAuthUI.swift

@@ -63,6 +63,11 @@ public class PhoneProviderSwift: PhoneAuthProviderSwift {
       presentingViewController.present(hostingController, animated: true)
     }
   }
+
+  public func deleteUser(user: User) async throws {
+    let operation = ProviderDeleteUserOperation(provider: self)
+    try await operation(on: user)
+  }
 }
 
 public class PhoneAuthProviderAuthUI: AuthProviderUI {

FirebaseSwiftUI/FirebaseTwitterSwiftUI/Sources/Services/TwitterProviderAuthUI.swift

@@ -17,7 +17,7 @@ import FirebaseAuthSwiftUI
 import FirebaseCore
 import SwiftUI
 
-public class TwitterProviderSwift: AuthProviderSwift, DeleteUserSwift {
+public class TwitterProviderSwift: AuthProviderSwift {
   public let scopes: [String]
   let providerId = "twitter.com"