Skip to content

Commit 29976cd

Browse files
authored
Merge pull request #997 from wimbledon/patch-2
initWithAuthUI: Auth Fix
2 parents 91da16a + 83c5fc4 commit 29976cd

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

FirebaseOAuthUI/FirebaseOAuthUITests/FirebaseOAuthUITests.m

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,13 @@ - (void)setUp {
4040

4141
id appClass = OCMClassMock([FIRApp class]);
4242
OCMStub([authClass app]).andReturn(appClass);
43+
44+
FIRAuth *auth = [FIRAuth auth];
45+
self.authUI = [FUIAuth authUIWithAuth:auth];
4346

4447
self.mockOAuthProvider = OCMClassMock([FIROAuthProvider class]);
45-
OCMStub(ClassMethod([_mockOAuthProvider providerWithProviderID:OCMOCK_ANY])).
48+
OCMStub(ClassMethod([_mockOAuthProvider providerWithProviderID:OCMOCK_ANY auth:self.authUI.auth])).
4649
andReturn(_mockOAuthProvider);
47-
48-
FIRAuth *auth = [FIRAuth auth];
49-
self.authUI = [FUIAuth authUIWithAuth:auth];
5050
}
5151

5252
- (void)tearDown {
@@ -78,7 +78,7 @@ - (void)testProviderValidity {
7878
XCTAssertNil(self.provider.accessToken);
7979
XCTAssertNil(self.provider.idToken);
8080

81-
OCMVerify([self.mockOAuthProvider providerWithProviderID:@"dummy"]);
81+
OCMVerify([self.mockOAuthProvider providerWithProviderID:@"dummy" auth:self.authUI.auth]);
8282
}
8383

8484
- (void)testAppleUsesEmulatorCreatesOAuthProvider {
@@ -93,7 +93,7 @@ - (void)testAppleUsesEmulatorCreatesOAuthProvider {
9393
scopes:@[]
9494
customParameters:@{}
9595
loginHintKey:nil];
96-
OCMVerify([self.mockOAuthProvider providerWithProviderID:@"apple.com"]);
96+
OCMVerify([self.mockOAuthProvider providerWithProviderID:@"apple.com" auth:self.authUI.auth]);
9797
}
9898

9999
- (void)testAppleNoUseEmulatorNoOAuthProvider {
@@ -106,7 +106,7 @@ - (void)testAppleNoUseEmulatorNoOAuthProvider {
106106
scopes:@[]
107107
customParameters:@{}
108108
loginHintKey:nil];
109-
OCMVerify(never(), [self.mockOAuthProvider providerWithProviderID:@"apple.com"]);
109+
OCMVerify(never(), [self.mockOAuthProvider providerWithProviderID:@"apple.com" auth:self.authUI.auth]);
110110
}
111111

112112
@end

FirebaseOAuthUI/Sources/FUIOAuth.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ - (instancetype)initWithAuthUI:(FUIAuth *)authUI
136136
_customParameters = customParameters;
137137
_loginHintKey = loginHintKey;
138138
if ((_authUI.isEmulatorEnabled || ![_providerID isEqualToString:@"apple.com"]) && ![_providerID isEqualToString:@"facebook.com"]) {
139-
_provider = [FIROAuthProvider providerWithProviderID:self.providerID];
139+
_provider = [FIROAuthProvider providerWithProviderID:self.providerID auth:_authUI.auth];
140140
}
141141
}
142142
return self;

0 commit comments

Comments
 (0)