fix: remove createPhoneAuthCredential

Author: russellwheatley

FirebaseSwiftUI/FirebasePhoneAuthSwiftUI/Sources/Services/PhoneAuthProviderAuthUI.swift

@@ -34,13 +34,6 @@ public class PhoneProviderSwift: PhoneAuthProviderSwift {
     }
   }
 
-  // Create a phone auth credential with the verification details
-  public func createPhoneAuthCredential(verificationID: String,
-                                        verificationCode: String) -> AuthCredential {
-    return PhoneAuthProvider.provider()
-      .credential(withVerificationID: verificationID, verificationCode: verificationCode)
-  }
-
   // Present phone auth UI and wait for user to complete the flow
   @MainActor public func createAuthCredential() async throws -> AuthCredential {
     guard let presentingViewController = await (UIApplication.shared.connectedScenes
@@ -54,7 +47,10 @@ public class PhoneProviderSwift: PhoneAuthProviderSwift {
     return try await withCheckedThrowingContinuation { continuation in
       let phoneAuthView = PhoneAuthView(phoneProvider: self) { result in
         switch result {
-        case .success(let credential):
+        case .success(let verificationID, let verificationCode):
+          // Create the credential here
+          let credential = PhoneAuthProvider.provider()
+            .credential(withVerificationID: verificationID, verificationCode: verificationCode)
           continuation.resume(returning: credential)
         case .failure(let error):
           continuation.resume(throwing: error)

FirebaseSwiftUI/FirebasePhoneAuthSwiftUI/Sources/Views/PhoneAuthView.swift

@@ -35,9 +35,9 @@ public struct PhoneAuthView {
   @State private var verificationID = ""
   @State private var isProcessing = false
   let phoneProvider: PhoneAuthProviderSwift
-  let completion: (Result<AuthCredential, Error>) -> Void
+  let completion: (Result<(String, String), Error>) -> Void
 
-  public init(phoneProvider: PhoneAuthProviderSwift, completion: @escaping (Result<AuthCredential, Error>) -> Void) {
+  public init(phoneProvider: PhoneAuthProviderSwift, completion: @escaping (Result<(String, String), Error>) -> Void) {
     self.phoneProvider = phoneProvider
     self.completion = completion
   }
@@ -161,23 +161,10 @@ extension PhoneAuthView: View {
           Button(action: {
             Task {
               isProcessing = true
-              do {
-                guard let phoneAuthProvider = phoneProvider as? PhoneProviderSwift else {
-                  errorMessage = "Invalid phone provider"
-                  isProcessing = false
-                  return
-                }
-                let credential = phoneAuthProvider.createPhoneAuthCredential(
-                  verificationID: verificationID,
-                  verificationCode: verificationCode
-                )
-                completion(.success(credential))
-                showVerificationCodeInput = false
-                dismiss()
-              } catch {
-                errorMessage = error.localizedDescription
-                isProcessing = false
-              }
+              // Return the verification details to createAuthCredential
+              completion(.success((verificationID, verificationCode)))
+              showVerificationCodeInput = false
+              dismiss()
             }
           }) {
             Text(authService.string.verifyPhoneNumberAndSignInLabel)
@@ -203,8 +190,8 @@ extension PhoneAuthView: View {
   let phoneProvider = PhoneProviderSwift()
   return PhoneAuthView(phoneProvider: phoneProvider) { result in
     switch result {
-    case .success:
-      print("Preview: Phone auth succeeded")
+    case .success(let verificationID, let verificationCode):
+      print("Preview: Got verification - ID: \(verificationID), Code: \(verificationCode)")
     case .failure(let error):
       print("Preview: Phone auth failed with error: \(error)")
     }