fix: renamed arg to make it clear the distinction between provider & provider + button

Author: russellwheatley

FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Services/AuthService.swift

@@ -152,8 +152,8 @@ public final class AuthService {
   var emailSignInEnabled = false
 
   private var providers: [AuthProviderUI] = []
-  public func registerProvider(provider: AuthProviderUI) {
-    providers.append(provider)
+  public func registerProvider(providerWithButton: AuthProviderUI) {
+    providers.append(providerWithButton)
   }
 
   public func renderButtons(spacing: CGFloat = 16) -> AnyView {

FirebaseSwiftUI/FirebaseFacebookSwiftUI/Sources/Services/AuthService+Facebook.swift

@@ -25,7 +25,7 @@ public extension AuthService {
   @discardableResult
   func withFacebookSignIn(scopes scopes: [String]? = nil) -> AuthService {
     FacebookProviderAuthUI.configureProvider(scopes: scopes)
-    registerProvider(provider: FacebookProviderAuthUI.shared)
+    registerProvider(providerWithButton: FacebookProviderAuthUI.shared)
     return self
   }
 }

FirebaseSwiftUI/FirebaseGoogleSwiftUI/Sources/Services/AuthService+Google.swift

@@ -25,7 +25,7 @@ public extension AuthService {
   @discardableResult
   func withGoogleSignIn(scopes scopes: [String]? = nil) -> AuthService {
     let clientID = auth.app?.options.clientID ?? ""
-    registerProvider(provider: GoogleProviderAuthUI(scopes: scopes, clientID: clientID))
+    registerProvider(providerWithButton: GoogleProviderAuthUI(scopes: scopes, clientID: clientID))
     return self
   }
 }

FirebaseSwiftUI/FirebasePhoneAuthSwiftUI/Sources/Services/AuthService+Phone.swift

@@ -24,7 +24,7 @@ import FirebaseAuthSwiftUI
 public extension AuthService {
   @discardableResult
   func withPhoneSignIn() -> AuthService {
-    registerProvider(provider: PhoneAuthProviderAuthUI())
+    registerProvider(providerWithButton: PhoneAuthProviderAuthUI())
     return self
   }
 }

FirebaseSwiftUI/FirebaseTwitterSwiftUI/Sources/Services/AuthService+Twitter.swift

@@ -23,8 +23,8 @@ import FirebaseAuthSwiftUI
 
 public extension AuthService {
   @discardableResult
-  func withTwitterSignIn(provider _: [String]? = nil) -> AuthService {
-    registerProvider(provider: TwitterProviderAuthUI())
+  func withTwitterSignIn(_ provider: TwitterProviderSwift) -> AuthService {
+    registerProvider(providerWithButton: TwitterProviderAuthUI(provider: provider))
     return self
   }
 }