Should callback Apple's error status instead of doing nothing (canceled/failed/invalid/Nothandled/Unknown)

for-meng · for-meng · commit 5ba7b20e4955 · 2021-11-08T14:50:40.000+08:00
Signed-off-by: for-meng &lt;formengblithe@gmail.com&gt;
diff --git a/FirebaseOAuthUI/Sources/FUIOAuth.m b/FirebaseOAuthUI/Sources/FUIOAuth.m
@@ -399,7 +399,11 @@ - (void)authorizationController:(ASAuthorizationController *)controller didCompl
 }
 
 - (void)authorizationController:(ASAuthorizationController *)controller didCompleteWithError:(NSError *)error API_AVAILABLE(ios(13.0)) {
-  NSLog(@"%@", error.description);
+    NSLog(@"%@", error.description);
+    // canceled/failed/invalid/Nothandled/Unknown
+    if (_providerSignInCompletion) {
+        _providerSignInCompletion(nil, error, nil, nil);
+    }
 }
 
 #pragma mark - ASAuthorizationControllerPresentationContextProviding

Original file line number	Diff line number	Diff line change
`@@ -399,7 +399,11 @@ - (void)authorizationController:(ASAuthorizationController *)controller didCompl`
`399`	`399`	`}`
`400`	`400`
`401`	`401`	`- (void)authorizationController:(ASAuthorizationController )controller didCompleteWithError:(NSError )error API_AVAILABLE(ios(13.0)) {`
`402`		`- NSLog(@"%@", error.description);`
	`402`	`+ NSLog(@"%@", error.description);`
	`403`	`+ // canceled/failed/invalid/Nothandled/Unknown`
	`404`	`+ if (_providerSignInCompletion) {`
	`405`	`+ _providerSignInCompletion(nil, error, nil, nil);`
	`406`	`+ }`
`403`	`407`	`}`
`404`	`408`
`405`	`409`	`#pragma mark - ASAuthorizationControllerPresentationContextProviding`