Skip to content

Commit 7cb3d65

Browse files
author
Chuan Ren
committed
Update i18n strings
1 parent 1b92fac commit 7cb3d65

File tree

7 files changed

+50
-30
lines changed

7 files changed

+50
-30
lines changed

Auth/FirebaseAuthUI/FUIAuthBaseViewController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ + (void)showAlertWithTitle:(nullable NSString *)title
236236
message:message
237237
actionTitle:nil
238238
actionHandler:nil
239-
dismissTitle:@"OK"
239+
dismissTitle:FUILocalizedString(kStr_OK)
240240
dismissHandler:nil
241241
presentingViewController:presentingViewController];
242242
}

Auth/FirebaseAuthUI/FUIAuthStrings.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ extern NSString *const kStr_Close;
3737
extern NSString *const kStr_ConfirmEmail;
3838
extern NSString *const kStr_Email;
3939
extern NSString *const kStr_EmailAlreadyInUseError;
40+
extern NSString *const kStr_EmailSentConfirmationMessage;
4041
extern NSString *const kStr_EnterYourEmail;
4142
extern NSString *const kStr_EnterYourPassword;
4243
extern NSString *const kStr_Error;
@@ -57,12 +58,17 @@ extern NSString *const kStr_PasswordVerificationMessage;
5758
extern NSString *const kStr_ProviderUsedPreviouslyMessage;
5859
extern NSString *const kStr_Save;
5960
extern NSString *const kStr_Send;
61+
extern NSString *const kStr_Resend;
62+
extern NSString *const kStr_SignedIn;
6063
extern NSString *const kStr_SignInTitle;
6164
extern NSString *const kStr_SignInTooManyTimesError;
6265
extern NSString *const kStr_SignInWithEmail;
66+
extern NSString *const kStr_SignInEmailSent;
6367
extern NSString *const kStr_SignUpTitle;
6468
extern NSString *const kStr_SignUpTooManyTimesError;
6569
extern NSString *const kStr_TermsOfService;
70+
extern NSString *const kStr_TroubleGettingEmailTitle;
71+
extern NSString *const kStr_TroubleGettingEmailMessage;
6672
extern NSString *const kStr_PrivacyPolicy;
6773
extern NSString *const kStr_TermsOfServiceMessage;
6874
extern NSString *const kStr_UserNotFoundError;

Auth/FirebaseAuthUI/FUIAuthStrings.m

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343
NSString *const kStr_ConfirmEmail = @"ConfirmEmail";
4444
NSString *const kStr_Email = @"Email";
4545
NSString *const kStr_EmailAlreadyInUseError = @"EmailAlreadyInUseError";
46+
NSString *const kStr_EmailSentConfirmationMessage = @"EmailSentConfirmationMessage";
4647
NSString *const kStr_EnterYourEmail = @"EnterYourEmail";
4748
NSString *const kStr_EnterYourPassword = @"EnterYourPassword";
4849
NSString *const kStr_Error = @"Error";
@@ -63,12 +64,17 @@
6364
NSString *const kStr_ProviderUsedPreviouslyMessage = @"ProviderUsedPreviouslyMessage";
6465
NSString *const kStr_Save = @"Save";
6566
NSString *const kStr_Send = @"Send";
67+
NSString *const kStr_Resend = @"Resend";
68+
NSString *const kStr_SignedIn = @"SignedIn";
6669
NSString *const kStr_SignInTitle = @"SignInTitle";
6770
NSString *const kStr_SignInTooManyTimesError = @"SignInTooManyTimesError";
6871
NSString *const kStr_SignInWithEmail = @"SignInWithEmail";
72+
NSString *const kStr_SignInEmailSent = @"SignInEmailSent";
6973
NSString *const kStr_SignUpTitle = @"SignUpTitle";
7074
NSString *const kStr_SignUpTooManyTimesError = @"SignUpTooManyTimesError";
7175
NSString *const kStr_TermsOfService = @"TermsOfService";
76+
NSString *const kStr_TroubleGettingEmailTitle = @"TroubleGettingEmailTitle";
77+
NSString *const kStr_TroubleGettingEmailMessage = @"TroubleGettingEmailMessage";
7278
NSString *const kStr_PrivacyPolicy = @"PrivacyPolicy";
7379
NSString *const kStr_TermsOfServiceMessage = @"TermsOfServiceMessage";
7480
NSString *const kStr_UserNotFoundError = @"UserNotFoundError";

Auth/FirebaseAuthUI/Strings/en.lproj/FirebaseAuthUI.strings

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,12 @@
103103
/* Save button title. */
104104
"Save" = "Save";
105105

106-
/* Save button title. */
106+
/* Send button title. */
107107
"Send" = "Send";
108108

109+
/* Resend button title. */
110+
"Resend" = "Resend";
111+
109112
/* Label next to a email text field. Use short/abbreviated translation for 'email' which is less than 15 chars. */
110113
"Email" = "Email";
111114

@@ -244,5 +247,23 @@
244247
/* Placeholder of secret input cell when user changes password. */
245248
"PlaceholderChosePassword" = "Choose password";
246249

247-
/* The title of forgot password button. */
250+
/* Title of forgot password button. */
248251
"ForgotPasswordTitle" = "Trouble signing in?";
252+
253+
/* Title of confirm email label. */
254+
"ConfirmEmail" = "Confirm Email";
255+
256+
/* Title of successfully signed in label. */
257+
"SignedIn" = "Signed in!";
258+
259+
/* Title used in trouble getting email alert view. */
260+
"TroubleGettingEmailTitle" = "Trouble getting emails?";
261+
262+
/* Alert message displayed when user having trouble getting email. */
263+
"TroubleGettingEmailMessage" = "Try these common fixes: \n - Check if the email was marked as spam or filtered.\n - Check your internet connection.\n - Check that you did not misspell your email.\n - Check that your inbox space is not running out or other inbox settings related issues.\n If the steps above didn't work, you can resend the email. Note that this will deactivate the link in the older email.";
264+
265+
/* Message displayed after email is sent. The placeholder is the email address that the email is sent to. */
266+
"EmailSentConfirmationMessage" = "A sign-in email with additional instrucitons was sent to %@. Check your email to complete sign-in.";
267+
268+
/* Message displayed after the email of sign-in link is sent. */
269+
"SignInEmailSent" = "Sign-in email Sent";

EmailAuth/FirebaseEmailAuthUI/FUIConfirmEmailViewController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ - (void)onNext:(NSString *)emailText {
167167
}
168168
}
169169

170-
[[self class] showAlertWithTitle:@"Signed in!"
170+
[[self class] showAlertWithTitle:FUILocalizedString(kStr_SignedIn)
171171
message:nil
172172
actionTitle:nil
173173
actionHandler:nil

EmailAuth/FirebaseEmailAuthUI/FUIEmailAuth.m

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ - (void)handleUnverifiedProviderLinking:(NSString *)providerID
304304
[self.authUI invokeResultCallbackWithAuthDataResult:authResult URL:nil error:error];
305305
};
306306

307-
[FUIAuthBaseViewController showAlertWithTitle:@"Signed in!"
307+
[FUIAuthBaseViewController showAlertWithTitle:FUILocalizedString(kStr_SignedIn)
308308
message:nil
309309
actionTitle:nil
310310
actionHandler:nil
@@ -352,7 +352,7 @@ - (void)handleAnonymousUpgrade:(NSString *)anonymousUserID email:(NSString *)ema
352352
return;
353353
}
354354
}
355-
[FUIAuthBaseViewController showAlertWithMessage:@"Signed in!"];
355+
[FUIAuthBaseViewController showAlertWithMessage:FUILocalizedString(kStr_SignedIn)];
356356
};
357357

358358
[self.authUI.auth.currentUser
@@ -408,11 +408,11 @@ - (void)handleEmaiLinkSignIn:(NSString *)email {
408408
[self.authUI invokeResultCallbackWithAuthDataResult:authResult URL:nil error:error];
409409
};
410410

411-
[FUIAuthBaseViewController showAlertWithTitle:@"Signed in!"
411+
[FUIAuthBaseViewController showAlertWithTitle:FUILocalizedString(kStr_SignedIn)
412412
message:nil
413413
actionTitle:nil
414414
actionHandler:nil
415-
dismissTitle:@"OK"
415+
dismissTitle:FUILocalizedString(kStr_OK)
416416
dismissHandler:dismissHandler
417417
presentingViewController:nil];
418418
};

EmailAuth/FirebaseEmailAuthUI/FUIEmailEntryViewController.m

Lines changed: 9 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -55,18 +55,6 @@
5555
*/
5656
static NSString *const kNextButtonAccessibilityID = @"NextButtonAccessibilityID";
5757

58-
/** @var kTroubleGettingEmailMessage
59-
@brief The message used in trouble getting email alert view.
60-
*/
61-
static NSString *const kTroubleGettingEmailMessage =
62-
@"Try these common fixes: \n \
63-
- Check if the email was marked as spam or filtered.\n \
64-
- Check your internet connection.\n \
65-
- Check that you did not misspell your email.\n \
66-
- Check that your inbox space is not running out or other inbox settings related issues.\n \
67-
If the steps above didn't work, you can resend the email.\
68-
Note that this will deactivate the link in the older email.";
69-
7058
@interface FUIEmailEntryViewController () <UITableViewDataSource, UITextFieldDelegate>
7159
@end
7260

@@ -237,30 +225,29 @@ - (void)sendSignInLinkToEmail:(NSString*)email {
237225
[self decrementActivity];
238226

239227
if (error) {
240-
[FUIAuthBaseViewController showAlertWithTitle:@"Error"
228+
[FUIAuthBaseViewController showAlertWithTitle:FUILocalizedString(kStr_Error)
241229
message:error.description
242230
presentingViewController:self];
243231
} else {
244232
NSString *successMessage =
245-
[NSString stringWithFormat: @"A sign-in email with additional instrucitons was sent to "
246-
"%@. Check your email to complete sign-in.", email];
247-
[FUIAuthBaseViewController showAlertWithTitle:@"Sign-in email Sent"
233+
[NSString stringWithFormat: FUILocalizedString(kStr_EmailSentConfirmationMessage), email];
234+
[FUIAuthBaseViewController showAlertWithTitle:FUILocalizedString(kStr_SignInEmailSent)
248235
message:successMessage
249-
actionTitle:@"Trouble getting email?"
236+
actionTitle:FUILocalizedString(kStr_TroubleGettingEmailTitle)
250237
actionHandler:^{
251238
[FUIAuthBaseViewController
252-
showAlertWithTitle:@"Trouble getting emails?"
253-
message:kTroubleGettingEmailMessage
254-
actionTitle:@"Resend"
239+
showAlertWithTitle:FUILocalizedString(kStr_TroubleGettingEmailTitle)
240+
message:FUILocalizedString(kStr_TroubleGettingEmailMessage)
241+
actionTitle:FUILocalizedString(kStr_Resend)
255242
actionHandler:^{
256243
[self sendSignInLinkToEmail:email];
257-
} dismissTitle:@"Back"
244+
} dismissTitle:FUILocalizedString(kStr_Back)
258245
dismissHandler:^{
259246
[self.navigationController popToRootViewControllerAnimated:YES];
260247
}
261248
presentingViewController:self];
262249
}
263-
dismissTitle:@"Back"
250+
dismissTitle:FUILocalizedString(kStr_Back)
264251
dismissHandler:^{
265252
[self.navigationController popToRootViewControllerAnimated:YES];
266253
}

0 commit comments

Comments
 (0)