Skip to content

Commit 8c25c45

Browse files
committed
code review comments
1 parent 2416b0e commit 8c25c45

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

FirebaseGoogleAuthUI/Sources/FUIGoogleAuth.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ - (instancetype)initWithScopes:(NSArray *)scopes {
101101
#pragma clang diagnostic pop
102102

103103
- (GIDSignIn *)googleSignIn {
104-
return [GIDSignIn sharedInstance];
104+
return GIDSignIn.sharedInstance;
105105
}
106106

107107
- (NSString *)clientID {
@@ -247,7 +247,7 @@ - (void)requestScopesWithPresentingViewController:(UIViewController *)presenting
247247
FIRAuthResultCallback result,
248248
NSDictionary<NSString *,id> *userInfo) {
249249
if (completion != nil) {
250-
completion(credential, error, result, nil);
250+
completion(credential, error, result, userInfo);
251251
}
252252
}];
253253
}];

FirebaseGoogleAuthUI/Sources/Public/FirebaseGoogleAuthUI/FUIGoogleAuth.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ __attribute__((deprecated("Instead use initWithAuthUI:")));
8989
- (instancetype)initWithScopes:(NSArray <NSString *> *)scopes
9090
__attribute__((deprecated("Instead use initWithAuthUI:permissions:"))) NS_DESIGNATED_INITIALIZER;
9191

92-
/** @fn initWithAuthUI:scopes:
92+
/** @fn requestScopesWithPresentingViewController:completion:
9393
@brief Requests the scopes in the `scopes` array.
9494
*/
9595
- (void)requestScopesWithPresentingViewController:(UIViewController *)presentingViewController

0 commit comments

Comments
 (0)