Merge pull request #246 from morganchen12/index-array-bug

fix bug in FUIIndexArray

Author: morganchen12

FirebaseDatabaseUI/FUIQueryObserver.m

@@ -58,8 +58,6 @@ + (FUIQueryObserver *)observerForQuery:(id<FUIDataObservable>)query
     completion(obs, nil, error);
   };
 
-  [obs observeEventType:FIRDataEventTypeChildAdded
-    andPreviousSiblingKeyWithBlock:observerBlock withCancelBlock:cancelBlock];
   [obs observeEventType:FIRDataEventTypeValue
     andPreviousSiblingKeyWithBlock:observerBlock withCancelBlock:cancelBlock];
   return obs;

FirebaseDatabaseUITests/FUIDatabaseTestUtils.m

@@ -176,6 +176,11 @@ - (FIRDatabaseHandle)observeEventType:(FIRDataEventType)eventType
       id value = self.contents[contentKey];
       FUIFakeSnapshot *snap = [[FUIFakeSnapshot alloc] initWithKey:contentKey value:value];
       [self sendEvent:FIRDataEventTypeChildAdded withObject:snap previousKey:previousKey error:nil];
+
+      // Send a value event, since this is a complete snapshot.
+      // TODO: FUIFakeSnapshot currently only represents dictionary types, though snapshots can
+      // have array, string, or number values as well. Tests need to be written for these.
+      [self sendEvent:FIRDataEventTypeValue withObject:snap previousKey:previousKey error:nil];
       previousKey = contentKey;
     }
   }

FirebaseDatabaseUITests/FUIIndexArrayTest.m

@@ -60,7 +60,7 @@ - (void)setUp {
   self.index = [[FUITestObservable alloc] initWithDictionary:database()[@"index"]];
   self.data = [[FUITestObservable alloc] initWithDictionary:database()[@"data"]];
   self.array = [[FUIIndexArray alloc] initWithIndex:self.index
-                                                    data:self.data];
+                                               data:self.data];
   self.arrayDelegate = [[FUIIndexArrayTestDelegate alloc] init];
   self.array.delegate = self.arrayDelegate;
   self.dict = [database() mutableCopy];