test: integration test updates

Author: russellwheatley

samples/swiftui/FirebaseSwiftUIExample/FirebaseSwiftUIExampleTests/FirebaseSwiftUIExampleTests.swift

@@ -105,37 +105,58 @@ struct FirebaseSwiftUIExampleTests {
     #expect(service.errorMessage.isEmpty)
     #expect(service.signedInCredential == nil)
     #expect(service.currentUser == nil)
-    try await service.createUser(withEmail: createEmail(), password: kPassword)
-    try await Task.sleep(nanoseconds: 4_000_000_000)
+    try await service.createUser(email: createEmail(), password: kPassword)
+
+    try await waitForStateChange {
+      service.authenticationState == .authenticated
+    }
     #expect(service.authenticationState == .authenticated)
+
+    try await waitForStateChange {
+      service.currentUser != nil
+    }
+    #expect(service.currentUser != nil)
     #expect(service.authView == .authPicker)
     #expect(service.errorMessage.isEmpty)
-    #expect(service.currentUser != nil)
-    // TODO: - reinstate once this PR is merged: https://github.com/firebase/FirebaseUI-iOS/pull/1256
-//    #expect(service.signedInCredential is AuthCredential)
   }
 
   @Test
   @MainActor
   func testSignInUser() async throws {
     let service = try await prepareFreshAuthService()
     let email = createEmail()
-    try await service.createUser(withEmail: email, password: kPassword)
+    try await service.createUser(email: email, password: kPassword)
     try await service.signOut()
-    try await Task.sleep(nanoseconds: 2_000_000_000)
+
+    try await waitForStateChange {
+      service.authenticationState == .unauthenticated
+    }
     #expect(service.authenticationState == .unauthenticated)
+
+    try await waitForStateChange {
+      service.currentUser == nil
+    }
+    #expect(service.currentUser == nil)
     #expect(service.authView == .authPicker)
     #expect(service.errorMessage.isEmpty)
     #expect(service.signedInCredential == nil)
-    #expect(service.currentUser == nil)
 
-    try await service.signIn(withEmail: email, password: kPassword)
+    try await service.signIn(email: email, password: kPassword)
 
+    try await waitForStateChange {
+      service.authenticationState == .authenticated
+    }
     #expect(service.authenticationState == .authenticated)
+
+    try await waitForStateChange {
+      service.currentUser != nil
+    }
+    #expect(service.currentUser != nil)
+    try await waitForStateChange {
+      service.signedInCredential != nil
+    }
+    #expect(service.signedInCredential != nil)
     #expect(service.authView == .authPicker)
     #expect(service.errorMessage.isEmpty)
-    #expect(service.currentUser != nil)
-    // TODO: - reinstate once this PR is merged: https://github.com/firebase/FirebaseUI-iOS/pull/1256
-    //    #expect(service.signedInCredential is AuthCredential)
   }
 }

samples/swiftui/FirebaseSwiftUIExample/FirebaseSwiftUIExampleTests/TestHarness.swift

@@ -61,3 +61,22 @@ func createEmail() -> String {
   let after = UUID().uuidString.prefix(6)
   return "\(before)@\(after).com"
 }
+
+func waitForStateChange(timeout: TimeInterval = 10.0,
+                        condition: @escaping () -> Bool) async throws {
+  let startTime = Date()
+
+  while !condition() {
+    if Date().timeIntervalSince(startTime) > timeout {
+      throw TestError.timeout("Timeout waiting for condition to be met")
+    }
+
+    // Small delay to prevent busy waiting
+    try await Task.sleep(nanoseconds: 50_000_000) // 50ms
+  }
+}
+
+// Add this simple error type
+enum TestError: Error {
+  case timeout(String)
+}