Skip to content

Commit d8f7705

Browse files
committed
clean unit test comments
1 parent 5dcc177 commit d8f7705

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

FirebaseGoogleAuthUITests/FirebaseGoogleAuthUITests.m

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,7 @@ - (void)testSuccessfullLogin {
8282

8383
OCMExpect([_mockProvider configuredGoogleSignIn]).andReturn(mockSignIn);
8484

85-
86-
// OCMExpect([mockSignInDelegate signIn:mockSignIn didSignInForUser:mockGoogleUser withError:nil]);
87-
// OCMExpect([mockSignIn signIn]).andCall(mockSignInDelegate, @selector(signIn:didSignInForUser:withError:));
85+
//forward call to signIn delegate
8886
OCMExpect([mockSignIn signIn]).andDo(^(NSInvocation *invocation) {
8987
[mockSignInDelegate signIn:mockSignIn didSignInForUser:mockGoogleUser withError:nil];
9088
});
@@ -136,8 +134,6 @@ - (void)testErrorLogin {
136134
OCMExpect([_mockProvider configuredGoogleSignIn]).andReturn(mockSignIn);
137135
NSError *signInError = [NSError errorWithDomain:@"sign in domain" code:kGIDSignInErrorCodeUnknown userInfo:@{}];
138136

139-
// OCMExpect([mockSignInDelegate signIn:mockSignIn didSignInForUser:mockGoogleUser withError:nil]);
140-
// OCMExpect([mockSignIn signIn]).andCall(mockSignInDelegate, @selector(signIn:didSignInForUser:withError:));
141137
OCMExpect([mockSignIn signIn]).andDo(^(NSInvocation *invocation) {
142138
[mockSignInDelegate signIn:mockSignIn didSignInForUser:mockGoogleUser withError:signInError];
143139
});
@@ -188,8 +184,6 @@ - (void)testCancelLogin {
188184
OCMExpect([_mockProvider configuredGoogleSignIn]).andReturn(mockSignIn);
189185
NSError *signInError = [NSError errorWithDomain:@"sign in domain" code:kGIDSignInErrorCodeCanceled userInfo:@{}];
190186

191-
// OCMExpect([mockSignInDelegate signIn:mockSignIn didSignInForUser:mockGoogleUser withError:nil]);
192-
// OCMExpect([mockSignIn signIn]).andCall(mockSignInDelegate, @selector(signIn:didSignInForUser:withError:));
193187
OCMExpect([mockSignIn signIn]).andDo(^(NSInvocation *invocation) {
194188
[mockSignInDelegate signIn:mockSignIn didSignInForUser:mockGoogleUser withError:signInError];
195189
});

0 commit comments

Comments
 (0)