Fix outstanding deprecation warnings

Change-Id: I335064ee6592deae6b4acf27e5b77aaf41948f24

Author: morganchen12

FirebaseAuthUI/AccountManagement/FUIAccountSettingsOperation.m

@@ -178,8 +178,9 @@ - (void)reauthenticateWithProvider:(NSString *)providerID
       }
       return;
     }
-    [self.delegate.auth.currentUser reauthenticateWithCredential:credential
-                                                  completion:^(NSError *_Nullable reauthError) {
+    [self.delegate.auth.currentUser
+        reauthenticateAndRetrieveDataWithCredential:credential
+                                         completion:^(NSError *_Nullable reauthError) {
       [self.delegate decrementActivity];
       if (result) {
         result(self.delegate.auth.currentUser, reauthError);

FirebaseAuthUI/FUIAuth.m

@@ -215,7 +215,7 @@ - (void)signInWithProviderUI:(id<FUIAuthProvider>)providerUI
         the sign-in attempt.
     @param newCredential The credential used in the lastest sign-in attempt.
     @param presentingViewController The view controller used to present the UI.
-    @param signInResult block which takes the result of this method as a parameter; a nullable
+    @param result block which takes the result of this method as a parameter; a nullable
         AuthResult indicating success or a nullable Error indicating failure.
  */
 - (void)handleAccountLinkingForEmail:(NSString *)email

FirebaseAuthUI/FUIAuthBaseViewController.m

@@ -323,7 +323,7 @@ - (void)incrementActivity {
   dispatch_after(dispatch_time(DISPATCH_TIME_NOW,
                               (int64_t)(kActivityIndiactorAnimationDelay * NSEC_PER_SEC)),
                  dispatch_get_main_queue(), ^{
-    [self->_activityIndicator.superview bringSubviewToFront:_activityIndicator];
+    [self->_activityIndicator.superview bringSubviewToFront:self->_activityIndicator];
     if (self->_activityCount > 0) {
       [self->_activityIndicator startAnimating];
     }

FirebaseAuthUI/FUIPasswordSignUpViewController.m

@@ -180,10 +180,10 @@ - (void)signUpWithEmail:(NSString *)email
 
   [self incrementActivity];
 
-  [self.auth createUserAndRetrieveDataWithEmail:email
-                                       password:password
-                                     completion:^(FIRAuthDataResult *_Nullable authDataResult,
-                                                  NSError *_Nullable error) {
+  [self.auth createUserWithEmail:email
+                        password:password
+                      completion:^(FIRAuthDataResult *_Nullable authDataResult,
+                                   NSError *_Nullable error) {
     if (error) {
       [self decrementActivity];