Merge pull request #604 from Granfalloner/SignInCompletionFix

Fixed dismissal/completion handling in email sign in controller

Author: morganchen12

EmailAuth/FirebaseEmailAuthUI/FUIPasswordSignInViewController.m

@@ -168,7 +168,8 @@ - (void)signInWithDefaultValue:(NSString *)email andPassword:(NSString *)passwor
             return;
         }
       }
-      [self.navigationController dismissViewControllerAnimated:YES completion:^{
+
+      [self dismissNavigationControllerAnimated:YES completion:^{
         if (self->_onDismissCallback) {
           self->_onDismissCallback(authResult, error);
         }

EmailAuth/FirebaseEmailAuthUI/FUIPasswordSignInViewController_Internal.h

@@ -22,9 +22,7 @@ NS_ASSUME_NONNULL_BEGIN
 @interface FUIPasswordSignInViewController ()
 
 /** @property onDismissCallback:
-    @brief Sets an optional custom callback for FUIPasswordSigInViewController during dismissal. If
-        this property is set the default dismissal routine is not triggered and should be included
-        in this block if necessary. This block is NOT set to nil after use, set to nil after using
+    @brief Sets an optional custom callback for FUIPasswordSigInViewController during dismissal. This block is NOT set to nil after use, set to nil after using
         if you wish to avoid circular references.
  */
 @property(nonatomic, strong, nullable) FIRAuthDataResultCallback onDismissCallback;