Skip to content

Commit fc7a512

Browse files
committed
add fb support
1 parent 79ad96d commit fc7a512

File tree

3 files changed

+48
-36
lines changed

3 files changed

+48
-36
lines changed

.github/workflows/facebookauth.yml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,16 @@ jobs:
3838
- name: Build
3939
run: |
4040
./test.sh FirebaseFacebookAuthUI
41-
# spm:
42-
# name: spm
43-
# runs-on: macOS-latest
41+
spm:
42+
name: spm
43+
runs-on: macOS-latest
4444

45-
# steps:
46-
# - name: Checkout
47-
# uses: actions/checkout@master
48-
# - name: List
49-
# run: |
50-
# xcodebuild -list
51-
# - name: Build
52-
# run: |
53-
# xcodebuild -scheme FirebaseFacebookAuthUI -sdk iphonesimulator
45+
steps:
46+
- name: Checkout
47+
uses: actions/checkout@master
48+
- name: List
49+
run: |
50+
xcodebuild -list
51+
- name: Build
52+
run: |
53+
xcodebuild -scheme FirebaseFacebookAuthUI -sdk iphonesimulator

FirebaseFacebookAuthUI/Sources/FUIFacebookAuth.m

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,16 @@
1616

1717
#import "FirebaseFacebookAuthUI/Sources/Public/FirebaseFacebookAuthUI/FUIFacebookAuth.h"
1818

19+
#import <FirebaseAuthUI/FirebaseAuthUI.h>
1920
#import <FirebaseAuth/FirebaseAuth.h>
21+
22+
#if SWIFT_PACKAGE
23+
@import FBSDKCoreKit;
24+
@import FBSDKLoginKit;
25+
#else
2026
#import <FBSDKCoreKit/FBSDKCoreKit.h>
2127
#import <FBSDKLoginKit/FBSDKLoginKit.h>
22-
#import <FirebaseAuthUI/FirebaseAuthUI.h>
28+
#endif // SWIFT_PACKAGE
2329

2430
/** @var kTableName
2531
@brief The name of the strings table to search for localized strings.
@@ -29,7 +35,11 @@
2935
/** @var kBundleName
3036
@brief The name of the bundle to search for resources.
3137
*/
38+
#if SWIFT_PACKAGE
39+
static NSString *const kBundleName = @"FirebaseUI_FirebaseFacebookAuthUI";
40+
#else
3241
static NSString *const kBundleName = @"FirebaseFacebookAuthUI";
42+
#endif // SWIFT_PACKAGE
3343

3444
/** @var kSignInWithFacebook
3545
@brief The string key for localized button text.

Package.swift

Lines changed: 25 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import PackageDescription
2020
let package = Package(
2121
name: "FirebaseUI",
2222
defaultLocalization: "en",
23-
platforms: [.iOS(.v10)],
23+
platforms: [.iOS(.v11)],
2424
products: [
2525
.library(
2626
name: "FirebaseAnonymousAuthUI",
@@ -38,6 +38,10 @@ let package = Package(
3838
name: "FirebaseEmailAuthUI",
3939
targets: ["FirebaseEmailAuthUI"]
4040
),
41+
.library(
42+
name: "FirebaseFacebookAuthUI",
43+
targets: ["FirebaseFacebookAuthUI"]
44+
),
4145
.library(
4246
name: "FirebaseFirestoreUI",
4347
targets: ["FirebaseFirestoreUI"]
@@ -64,12 +68,12 @@ let package = Package(
6468
.package(
6569
name: "Firebase",
6670
url: "https://github.com/firebase/firebase-ios-sdk.git",
67-
from: "7.2.0"
71+
from: "8.0.0"
6872
),
6973
.package(
7074
name: "GoogleUtilities",
7175
url: "https://github.com/google/GoogleUtilities.git",
72-
"7.2.1" ..< "8.0.0"
76+
from: "7.4.1"
7377
),
7478
.package(
7579
name: "GTMSessionFetcher",
@@ -146,26 +150,24 @@ let package = Package(
146150
.headerSearchPath("../../"),
147151
]
148152
),
149-
// Facebook doesn't seem to vend their ObjC libraries through SPM, though their
150-
// Swift libraries wrap their ObjC ones.
151-
// .target(
152-
// name: "FacebookAuthUI",
153-
// dependencies: [
154-
// "AuthUI",
155-
// .product(name: "FacebookLogin", package: "Facebook"),
156-
// .product(name: "FacebookCore", package: "Facebook"),
157-
// ],
158-
// path: "FacebookAuth/FirebaseFacebookAuthUI",
159-
// exclude: ["Info.plist"],
160-
// resources: [
161-
// .process("Resources"),
162-
// .process("Strings"),
163-
// ],
164-
// publicHeadersPath: ".",
165-
// cSettings: [
166-
// .headerSearchPath("./"),
167-
// ]
168-
// ),
153+
.target(
154+
name: "FirebaseFacebookAuthUI",
155+
dependencies: [
156+
"FirebaseAuthUI",
157+
.product(name: "FacebookLogin", package: "Facebook"),
158+
.product(name: "FacebookCore", package: "Facebook"),
159+
],
160+
path: "FirebaseFacebookAuthUI/Sources",
161+
exclude: ["Info.plist"],
162+
resources: [
163+
.process("Resources"),
164+
.process("Strings"),
165+
],
166+
publicHeadersPath: "Public",
167+
cSettings: [
168+
.headerSearchPath("../../"),
169+
]
170+
),
169171
.target(
170172
name: "FirebaseFirestoreUI",
171173
dependencies: [

0 commit comments

Comments
 (0)