Renamed UserID to UserId in the classes inside of GetAccountInfoResponse.

Converted ProviderUserInfo to be an internal class, with auto properties.
Fixed the FirebaseUserManagerTest test so that it would fail when instantiating a UserRecord class with a uid that's longer than 128 characters.

Author: renatoc8

FirebaseAdmin/FirebaseAdmin.Tests/Auth/FirebaseUserManagerTest.cs

@@ -35,9 +35,7 @@ public void InvalidUidForUserRecord()
             Assert.Throws<ArgumentException>(() => new UserRecord((string)null));
             Assert.Throws<ArgumentException>(() => new UserRecord((GetAccountInfoResponse.User)null));
             Assert.Throws<ArgumentException>(() => new UserRecord(string.Empty));
-
-            // The constructor for UserRecord should not throw an exception when initialized with a valid string.
-            var userRecord = new UserRecord(new string('a', 129));
+            Assert.Throws<ArgumentException>(() => new UserRecord(new string('a', 129)));
         }
 
         [Fact]
@@ -84,7 +82,7 @@ public async Task GetUserById()
                     Kind = "identitytoolkit#GetAccountInfoResponse",
                     Users = new List<GetAccountInfoResponse.User>()
                     {
-                        new GetAccountInfoResponse.User() { UserID = "user1" },
+                        new GetAccountInfoResponse.User() { UserId = "user1" },
                     },
                 },
             };
@@ -130,7 +128,7 @@ public async Task UpdateUser()
                     Kind = "identitytoolkit#GetAccountInfoResponse",
                     Users = new List<GetAccountInfoResponse.User>()
                     {
-                        new GetAccountInfoResponse.User() { UserID = "user1" },
+                        new GetAccountInfoResponse.User() { UserId = "user1" },
                     },
                 },
             };

FirebaseAdmin/FirebaseAdmin/Auth/FirebaseUserManager.cs

@@ -90,7 +90,7 @@ public async Task<UserRecord> GetUserById(
             }
 
             var user = response.Users[0];
-            if (user == null || user.UserID != uid)
+            if (user == null || user.UserId != uid)
             {
                 throw new FirebaseException($"Failed to get user: {uid}");
             }
@@ -117,7 +117,7 @@ public async Task UpdateUserAsync(
             }
 
             var updatedUser = response.Users[0];
-            if (updatedUser == null || updatedUser.UserID != user.Uid)
+            if (updatedUser == null || updatedUser.UserId != user.Uid)
             {
                 throw new FirebaseException($"Failed to update user: {user.Uid}");
             }

FirebaseAdmin/FirebaseAdmin/Auth/Internal/GetAccountInfoResponse.cs

@@ -31,7 +31,7 @@ internal sealed class User
             /// Gets or sets the user's ID.
             /// </summary>
             [JsonProperty(PropertyName = "localId")]
-            public string UserID { get; set; }
+            public string UserId { get; set; }
 
             /// <summary>
             /// Gets or sets the user's email address.
@@ -109,7 +109,7 @@ internal sealed class Provider
             /// Gets or sets the user's ID.
             /// </summary>
             [JsonProperty(PropertyName = "uid")]
-            public string UserID { get; set; }
+            public string UserId { get; set; }
 
             /// <summary>
             /// Gets or sets the user's display name.

FirebaseAdmin/FirebaseAdmin/Auth/ProviderUserInfo.cs

@@ -8,82 +8,57 @@ namespace FirebaseAdmin.Auth
     /// Contains metadata regarding how a user is known by a particular identity provider (IdP).
     /// Instances of this class are immutable and thread safe.
     /// </summary>
-    public sealed class ProviderUserInfo : IUserInfo
+    internal sealed class ProviderUserInfo : IUserInfo
     {
-        private string uid;
-        private string displayName;
-        private string email;
-        private string phoneNumber;
-        private string photoUrl;
-        private string providerId;
-
         /// <summary>
         /// Initializes a new instance of the <see cref="ProviderUserInfo"/> class with data provided by an authentication provider.
         /// </summary>
         /// <param name="provider">The deserialized JSON user data from the provider.</param>
         internal ProviderUserInfo(GetAccountInfoResponse.Provider provider)
         {
-            this.uid = provider.UserID;
-            this.displayName = provider.DisplayName;
-            this.email = provider.Email;
-            this.phoneNumber = provider.PhoneNumber;
-            this.photoUrl = provider.PhotoUrl;
-            this.providerId = provider.ProviderID;
+            this.Uid = provider.UserId;
+            this.DisplayName = provider.DisplayName;
+            this.Email = provider.Email;
+            this.PhoneNumber = provider.PhoneNumber;
+            this.PhotoUrl = provider.PhotoUrl;
+            this.ProviderId = provider.ProviderID;
         }
 
         /// <summary>
         /// Gets the user's unique ID assigned by the identity provider.
         /// </summary>
         /// <returns>a user ID string.</returns>
-        public string Uid
-        {
-            get => this.uid;
-        }
+        public string Uid { get; private set; }
 
         /// <summary>
         /// Gets the user's display name, if available.
         /// </summary>
         /// <returns>a display name string or null.</returns>
-        public string DisplayName
-        {
-            get => this.displayName;
-        }
+        public string DisplayName { get; private set; }
 
         /// <summary>
         /// Gets the user's email address, if available.
         /// </summary>
         /// <returns>an email address string or null.</returns>
-        public string Email
-        {
-            get => this.email;
-        }
+        public string Email { get; private set; }
 
         /// <summary>
         /// Gets the user's phone number.
         /// </summary>
         /// <returns>a phone number string or null.</returns>
-        public string PhoneNumber
-        {
-            get => this.phoneNumber;
-        }
+        public string PhoneNumber { get; private set; }
 
         /// <summary>
         /// Gets the user's photo URL, if available.
         /// </summary>
         /// <returns>a URL string or null.</returns>
-        public string PhotoUrl
-        {
-            get => this.photoUrl;
-        }
+        public string PhotoUrl { get; private set; }
 
         /// <summary>
         /// Gets the ID of the identity provider. This can be a short domain name (e.g. google.com) or
         /// the identifier of an OpenID identity provider.
         /// </summary>
         /// <returns>an ID string that uniquely identifies the identity provider.</returns>
-        public string ProviderId
-        {
-            get => this.providerId;
-        }
+        public string ProviderId { get; private set; }
     }
 }

FirebaseAdmin/FirebaseAdmin/Auth/UserRecord.cs

@@ -47,9 +47,9 @@ public sealed class UserRecord : IUserInfo
         /// <param name="uid">The user's ID.</param>
         internal UserRecord(string uid)
         {
-            if (string.IsNullOrEmpty(uid))
+            if (string.IsNullOrEmpty(uid) || uid.Length > 128)
             {
-                throw new ArgumentException("UserID must not be null or empty.");
+                throw new ArgumentException("User ID must not be null or empty, and be 128 characters or shorter.");
             }
 
             this.uid = uid;
@@ -65,12 +65,12 @@ internal UserRecord(GetAccountInfoResponse.User user)
             {
                 throw new ArgumentException("User object must not be null or empty.");
             }
-            else if (string.IsNullOrEmpty(user.UserID))
+            else if (string.IsNullOrEmpty(user.UserId))
             {
-                throw new ArgumentException("UserID must not be null or empty.");
+                throw new ArgumentException("User ID must not be null or empty.");
             }
 
-            this.uid = user.UserID;
+            this.uid = user.UserId;
             this.email = user.Email;
             this.phoneNumber = user.PhoneNumber;
             this.emailVerified = user.EmailVerified;