changes part 1

Author: Leo

FirebaseAdmin/FirebaseAdmin.Tests/Messaging/TopicManagementResponseTest.cs

@@ -14,7 +14,7 @@ public void SuccessfulReponse()
             var instanceIdServiceResponse = JsonConvert.DeserializeObject<InstanceIdServiceResponse>(json);
             var response = new TopicManagementResponse(instanceIdServiceResponse);
 
-            Assert.Equal(0, response.FailureCount);
+            Assert.Empty(response.Errors);
             Assert.Equal(2, response.SuccessCount);
         }
 
@@ -25,7 +25,7 @@ public void UnsuccessfulResponse()
             var instanceIdServiceResponse = JsonConvert.DeserializeObject<InstanceIdServiceResponse>(json);
             var response = new TopicManagementResponse(instanceIdServiceResponse);
 
-            Assert.Equal(1, response.FailureCount);
+            Assert.Single(response.Errors);
             Assert.Equal(1, response.SuccessCount);
             Assert.NotEmpty(response.Errors);
             Assert.Equal("registration-token-not-registered", response.Errors[0].Reason);
@@ -37,17 +37,17 @@ public void NullResponse()
         {
             Assert.Throws<ArgumentException>(() =>
             {
-                var response = new TopicManagementResponse(null);
+                new TopicManagementResponse(null);
             });
         }
 
         [Fact]
         public void EmptyResponse()
         {
+            var instanceIdServiceResponse = new InstanceIdServiceResponse();
             Assert.Throws<ArgumentException>(() =>
             {
-                var instanceIdServiceResponse = new InstanceIdServiceResponse();
-                var response = new TopicManagementResponse(instanceIdServiceResponse);
+                new TopicManagementResponse(instanceIdServiceResponse);
             });
         }
 
@@ -58,7 +58,7 @@ public void UnknownError()
             var instanceIdServiceResponse = JsonConvert.DeserializeObject<InstanceIdServiceResponse>(json);
             var response = new TopicManagementResponse(instanceIdServiceResponse);
 
-            Assert.Equal(1, response.FailureCount);
+            Assert.Empty(response.Errors);
             Assert.Equal(0, response.SuccessCount);
             Assert.NotEmpty(response.Errors);
             Assert.Equal("unknown-error", response.Errors[0].Reason);
@@ -72,7 +72,7 @@ public void UnexpectedResponse()
             var instanceIdServiceResponse = JsonConvert.DeserializeObject<InstanceIdServiceResponse>(json);
             var response = new TopicManagementResponse(instanceIdServiceResponse);
 
-            Assert.Equal(0, response.FailureCount);
+            Assert.Empty(response.Errors);
             Assert.Equal(1, response.SuccessCount);
         }
 

FirebaseAdmin/FirebaseAdmin/Messaging/InstanceIdClient.cs

@@ -15,6 +15,7 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
+using System.Linq;
 using System.Net.Http;
 using System.Threading;
 using System.Threading.Tasks;
@@ -87,6 +88,8 @@ public void Dispose()
 
         private async Task<TopicManagementResponse> SendInstanceIdRequest(string topic, List<string> registrationTokens, string path)
         {
+            this.ValidateRegistrationTokenList(registrationTokens);
+
             string url = $"{IidHost}/{path}";
             var body = new InstanceIdServiceRequest
             {
@@ -131,6 +134,32 @@ private FirebaseMessagingException CreateExceptionFromResponse(HttpRequestExcept
                 response: temp.HttpResponse);
         }
 
+        private void ValidateRegistrationTokenList(List<string> registrationTokens)
+        {
+            if (registrationTokens == null)
+            {
+                throw new FirebaseMessagingException(ErrorCode.InvalidArgument, "Registration token list must not be null");
+            }
+
+            if (registrationTokens.Count() == 0)
+            {
+                throw new FirebaseMessagingException(ErrorCode.InvalidArgument, "Registration token list must not be empty");
+            }
+
+            if (registrationTokens.Count() > 1000)
+            {
+                throw new FirebaseMessagingException(ErrorCode.InvalidArgument, "Registration token list must not contain more than 1000 tokens");
+            }
+
+            foreach (var registrationToken in registrationTokens)
+            {
+                if (string.IsNullOrEmpty(registrationToken))
+                {
+                    throw new FirebaseMessagingException(ErrorCode.InvalidArgument, "Registration token must not be null");
+                }
+            }
+        }
+
         private string GetPrefixedTopic(string topic)
         {
             if (topic.StartsWith("/topics/"))