Skip to content

Commit 356a8c1

Browse files
committed
Use nullable types for UserMetadata fields
1 parent d2f019e commit 356a8c1

File tree

4 files changed

+12
-13
lines changed

4 files changed

+12
-13
lines changed

CHANGELOG.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
# Unreleased
22

3-
- [added] Implemented the `GetUserById()` API in the `FirebaseUserManager` class.
4-
5-
-
3+
- [added] Implemented the `GetUserAsync()` API in the `FirebaseAuth` class.
4+
- [added] Implemented the `DeleteUserAsync()` API in the `FirebaseAuth` class.
65

76
# v1.4.0
87

FirebaseAdmin/FirebaseAdmin.Tests/Auth/FirebaseUserManagerTest.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ public async Task GetUserById()
5858
Assert.Equal(UserRecord.UnixEpoch, userRecord.TokensValidAfterTimestamp);
5959
Assert.Empty(userRecord.CustomClaims);
6060
Assert.Empty(userRecord.ProviderData);
61-
Assert.Equal(DateTime.MinValue, userRecord.UserMetaData.CreationTimestamp);
62-
Assert.Equal(DateTime.MinValue, userRecord.UserMetaData.LastSignInTimestamp);
61+
Assert.Null(userRecord.UserMetaData.CreationTimestamp);
62+
Assert.Null(userRecord.UserMetaData.LastSignInTimestamp);
6363
}
6464

6565
[Fact]

FirebaseAdmin/FirebaseAdmin.Tests/Auth/UserRecordTest.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ public void UidOnly()
6464
Assert.Empty(user.CustomClaims);
6565
Assert.Empty(user.ProviderData);
6666
Assert.NotNull(user.UserMetaData);
67-
Assert.Equal(DateTime.MinValue, user.UserMetaData.CreationTimestamp);
68-
Assert.Equal(DateTime.MinValue, user.UserMetaData.LastSignInTimestamp);
67+
Assert.Null(user.UserMetaData.CreationTimestamp);
68+
Assert.Null(user.UserMetaData.LastSignInTimestamp);
6969
}
7070

7171
[Fact]

FirebaseAdmin/FirebaseAdmin/Auth/UserMetadata.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,27 +26,27 @@ internal UserMetadata(long creationTimestamp, long lastSignInTimestamp)
2626

2727
/// <summary>
2828
/// Gets a timestamp representing the date and time that the account was created.
29-
/// If not available this property is <c>DateTime.MinValue</c>.
29+
/// If not available this property is <c>null</c>.
3030
/// </summary>
31-
public DateTime CreationTimestamp
31+
public DateTime? CreationTimestamp
3232
{
3333
get => this.ToDateTime(this.creationTimestampMillis);
3434
}
3535

3636
/// <summary>
3737
/// Gets a timestamp representing the last time that the user has signed in. If the user
38-
/// has never signed in this property is <c>DateTime.MinValue</c>.
38+
/// has never signed in this property is <c>null</c>.
3939
/// </summary>
40-
public DateTime LastSignInTimestamp
40+
public DateTime? LastSignInTimestamp
4141
{
4242
get => this.ToDateTime(this.lastSignInTimestampMillis);
4343
}
4444

45-
private DateTime ToDateTime(long millisFromEpoch)
45+
private DateTime? ToDateTime(long millisFromEpoch)
4646
{
4747
if (millisFromEpoch == 0)
4848
{
49-
return DateTime.MinValue;
49+
return null;
5050
}
5151

5252
return UserRecord.UnixEpoch.AddMilliseconds(millisFromEpoch);

0 commit comments

Comments
 (0)