use AppOptions.HttpClientFactory throughout api

Author: nixj14

FirebaseAdmin/FirebaseAdmin/AppOptions.cs

@@ -26,6 +26,8 @@ namespace FirebaseAdmin
     /// </summary>
     public sealed class AppOptions
     {
+        private HttpClientFactory httpClientFactory;
+
         /// <summary>
         /// Initializes a new instance of the  <see cref="AppOptions"/> class.
         /// </summary>
@@ -36,7 +38,7 @@ internal AppOptions(AppOptions options)
             this.Credential = options.Credential;
             this.ProjectId = options.ProjectId;
             this.ServiceAccountId = options.ServiceAccountId;
-            this.ClientFactory = options.ClientFactory;
+            this.HttpClientFactory = options.HttpClientFactory;
         }
 
         /// <summary>
@@ -62,8 +64,26 @@ internal AppOptions(AppOptions options)
         public string ServiceAccountId { get; set; }
 
         /// <summary>
-        /// Gets or sets the HttpClientFactory to use when making Firebase requirests.
+        /// Gets or sets the HttpClientFactory to use when making Firebase requests.
         /// </summary>
-        public HttpClientFactory ClientFactory { get; set; } = new HttpClientFactory();
+        public HttpClientFactory HttpClientFactory
+        {
+            get
+            {
+                if (this.httpClientFactory != null)
+                {
+                    return this.httpClientFactory;
+                }
+                else
+                {
+                    return new HttpClientFactory();
+                }
+            }
+
+            set
+            {
+                this.httpClientFactory = value;
+            }
+        }
     }
 }

FirebaseAdmin/FirebaseAdmin/Auth/FirebaseTokenFactory.cs

@@ -85,13 +85,13 @@ public static FirebaseTokenFactory Create(FirebaseApp app)
             {
                 // If no service account ID is specified, attempt to discover one and invoke the
                 // IAM service with it.
-                signer = new IAMSigner(new HttpClientFactory(), app.Options.Credential);
+                signer = new IAMSigner(app.Options.HttpClientFactory, app.Options.Credential);
             }
             else
             {
                 // If a service account ID is specified, invoke the IAM service with it.
                 signer = new FixedAccountIAMSigner(
-                    new HttpClientFactory(), app.Options.Credential, app.Options.ServiceAccountId);
+                    app.Options.HttpClientFactory, app.Options.Credential, app.Options.ServiceAccountId);
             }
 
             return new FirebaseTokenFactory(signer, SystemClock.Default);

FirebaseAdmin/FirebaseAdmin/Auth/FirebaseTokenVerifier.cs

@@ -85,7 +85,7 @@ internal static FirebaseTokenVerifier CreateIDTokenVerifier(FirebaseApp app)
             }
 
             var keySource = new HttpPublicKeySource(
-                IdTokenCertUrl, SystemClock.Default, new HttpClientFactory());
+                IdTokenCertUrl, SystemClock.Default, app.Options.HttpClientFactory);
             var args = new FirebaseTokenVerifierArgs()
             {
                 ProjectId = projectId,

FirebaseAdmin/FirebaseAdmin/Auth/FirebaseUserManager.cs

@@ -1,4 +1,4 @@
-// Copyright 2019, Google Inc. All rights reserved.
+// Copyright 2019, Google Inc. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -52,7 +52,7 @@ public static FirebaseUserManager Create(FirebaseApp app)
         {
             var args = new FirebaseUserManagerArgs
             {
-                ClientFactory = new HttpClientFactory(),
+                ClientFactory = app.Options.HttpClientFactory,
                 Credential = app.Options.Credential,
                 ProjectId = app.GetProjectId(),
             };

FirebaseAdmin/FirebaseAdmin/Messaging/FirebaseMessaging.cs

@@ -30,7 +30,7 @@ public sealed class FirebaseMessaging : IFirebaseService
         private FirebaseMessaging(FirebaseApp app)
         {
             this.messagingClient = new FirebaseMessagingClient(
-                    app.Options.ClientFactory, app.Options.Credential, app.GetProjectId());
+                    app.Options.HttpClientFactory, app.Options.Credential, app.GetProjectId());
         }
 
         /// <summary>