Skip to content

Commit b00db83

Browse files
author
Leo
committed
Improve docs, add missing dispose
1 parent b668b38 commit b00db83

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

FirebaseAdmin/FirebaseAdmin/Messaging/FirebaseMessaging.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ public async Task<BatchResponse> SendMulticastAsync(
319319
/// </summary>
320320
/// <param name="topic">The topic name to subscribe to. /topics/ will be prepended to the topic name provided if absent.</param>
321321
/// <param name="registrationTokens">A list of registration tokens to subscribe.</param>
322-
/// <returns>The response produced by FCM topic management operations.</returns>
322+
/// <returns>A task that completes with a <see cref="TopicManagementResponse"/>, giving details about the topic subscription operations.</returns>
323323
public async Task<TopicManagementResponse> SubscribeToTopicAsync(string topic, List<string> registrationTokens)
324324
{
325325
return await this.instanceIdClient.SubscribeToTopicAsync(topic, registrationTokens);
@@ -330,7 +330,7 @@ public async Task<TopicManagementResponse> SubscribeToTopicAsync(string topic, L
330330
/// </summary>
331331
/// <param name="topic">The topic name to unsubscribe from. /topics/ will be prepended to the topic name provided if absent.</param>
332332
/// <param name="registrationTokens">A list of registration tokens to unsubscribe.</param>
333-
/// <returns>The response produced by FCM topic management operations.</returns>
333+
/// <returns>A task that completes with a <see cref="TopicManagementResponse"/>, giving details about the topic unsubscription operations.</returns>
334334
public async Task<TopicManagementResponse> UnsubscribeFromTopicAsync(string topic, List<string> registrationTokens)
335335
{
336336
return await this.instanceIdClient.UnsubscribeFromTopicAsync(topic, registrationTokens);
@@ -342,6 +342,7 @@ public async Task<TopicManagementResponse> UnsubscribeFromTopicAsync(string topi
342342
void IFirebaseService.Delete()
343343
{
344344
this.messagingClient.Dispose();
345+
this.instanceIdClient.Dispose();
345346
}
346347
}
347348
}

FirebaseAdmin/FirebaseAdmin/Messaging/InstanceIdClient.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public InstanceIdClient(HttpClientFactory clientFactory, GoogleCredential creden
7070
/// </summary>
7171
/// <param name="topic">The topic name to subscribe to. /topics/ will be prepended to the topic name provided if absent.</param>
7272
/// <param name="registrationTokens">A list of registration tokens to subscribe.</param>
73-
/// <returns>The response produced by FCM topic management operations.</returns>
73+
/// <returns>A task that completes with a <see cref="TopicManagementResponse"/>, giving details about the topic subscription operations.</returns>
7474
public async Task<TopicManagementResponse> SubscribeToTopicAsync(string topic, List<string> registrationTokens)
7575
{
7676
try
@@ -92,7 +92,7 @@ public async Task<TopicManagementResponse> SubscribeToTopicAsync(string topic, L
9292
/// </summary>
9393
/// <param name="topic">The topic name to unsubscribe from. /topics/ will be prepended to the topic name provided if absent.</param>
9494
/// <param name="registrationTokens">A list of registration tokens to unsubscribe.</param>
95-
/// <returns>The response produced by FCM topic management operations.</returns>
95+
/// <returns>A task that completes with a <see cref="TopicManagementResponse"/>, giving details about the topic unsubscription operations.</returns>
9696
public async Task<TopicManagementResponse> UnsubscribeFromTopicAsync(string topic, List<string> registrationTokens)
9797
{
9898
try

0 commit comments

Comments
 (0)