resolved all remarks

extending userrecord
added password hash and salt
trailing newlines in files
class documentation
renamed page-manager and service-request to match the API-method

Author: ChristopherLenz

FirebaseAdmin/FirebaseAdmin/Auth/ExportedUserRecord.cs

@@ -15,81 +15,83 @@
 namespace FirebaseAdmin.Auth
 {
     /// <summary>
-    /// Contains metadata associated with a Firebase user account.
+    /// Contains metadata associated with a Firebase user account, along with password hash and salt.
+    /// Instances of this class are immutable and thread safe.
     /// </summary>
-    public sealed class ExportedUserRecord
+    public sealed class ExportedUserRecord : UserRecord
     {
-        /// <summary>
-        /// Gets or sets the user's ID.
-        /// </summary>
-        public string UserId { get; set; }
-
-        /// <summary>
-        /// Gets or sets the user's email address.
-        /// </summary>
-        public string Email { get; set; }
-
-        /// <summary>
-        /// Gets or sets the user's phone number.
-        /// </summary>
-        public string PhoneNumber { get; set; }
-
-        /// <summary>
-        /// Gets or sets a value indicating whether the user's email address is verified or not.
-        /// </summary>
-        public bool EmailVerified { get; set; }
+        private readonly long createdAt;
+        private readonly long lastLoginAt;
+        private readonly long validSince;
+        private readonly string passwordHash;
+        private readonly string passwordSalt;
 
-        /// <summary>
-        /// Gets or sets the user's display name.
-        /// </summary>
-        public string DisplayName { get; set; }
+        internal ExportedUserRecord(string uid, long createdAt, long lastLoginAt, long validSince, string passwordHash, string passwordSalt)
+            : base(uid)
+        {
+            this.createdAt = createdAt;
+            this.lastLoginAt = lastLoginAt;
+            this.validSince = validSince;
+            this.passwordHash = passwordHash;
+            this.passwordSalt = passwordSalt;
+        }
 
-        /// <summary>
-        /// Gets or sets the URL for the user's photo.
-        /// </summary>
-        public string PhotoUrl { get; set; }
+        internal ExportedUserRecord(GetAccountInfoResponse.User user)
+            : base(user)
+        {
+            this.createdAt = user.CreatedAt;
+            this.lastLoginAt = user.LastLoginAt;
+            this.validSince = user.ValidSince;
+            this.passwordHash = user.PasswordHash;
+            this.passwordSalt = user.PasswordSalt;
+        }
 
         /// <summary>
-        /// Gets or sets a value indicating whether the user is disabled or not.
+        /// Gets the timestamp representing the time that the user account was created.
         /// </summary>
-        public bool Disabled { get; set; }
+        public long CreatedAt
+        {
+            get => this.createdAt;
+        }
 
         /// <summary>
-        /// Gets or sets the timestamp representing the time that the user account was created.
+        /// Gets the timestamp representing the last time that the user has logged in.
         /// </summary>
-        public long CreatedAt { get; set; }
+        public long LastLoginAt
+        {
+            get => this.lastLoginAt;
+        }
 
         /// <summary>
-        /// Gets or sets the timestamp representing the last time that the user has logged in.
+        /// Gets the timestamp representing the time that the user account was first valid.
         /// </summary>
-        public long LastLoginAt { get; set; }
+        public long ValidSince
+        {
+            get => this.validSince;
+        }
 
         /// <summary>
-        /// Gets or sets the timestamp representing the time that the user account was first valid.
+        /// Gets the user's password hash as a base64-encoded string.
+        /// If the Firebase Auth hashing algorithm (SCRYPT) was used to create the user account,
+        /// returns the base64-encoded password hash of the user.If a different hashing algorithm was
+        /// used to create this user, as is typical when migrating from another Auth system, returns
+        /// an empty string. Returns null if no password is set.
         /// </summary>
-        public long ValidSince { get; set; }
+        public string PasswordHash
+        {
+            get => this.passwordHash;
+        }
 
         /// <summary>
-        /// Gets or sets the user's custom claims.
+        /// Gets the user's password salt as a base64-encoded string.
+        /// If the Firebase Auth hashing algorithm (SCRYPT) was used to create the user account,
+        /// returns the base64-encoded password salt of the user.If a different hashing algorithm was
+        /// used to create this user, as is typical when migrating from another Auth system, returns
+        /// an empty string. Returns null if no password is set.
         /// </summary>
-        public string CustomClaims { get; set; }
-
-        internal static ExportedUserRecord CreateFrom(GetAccountInfoResponse.User userRecord)
+        public string PasswordSalt
         {
-            return new ExportedUserRecord
-            {
-                UserId = userRecord.UserId,
-                Email = userRecord.Email,
-                PhoneNumber = userRecord.PhoneNumber,
-                EmailVerified = userRecord.EmailVerified,
-                DisplayName = userRecord.DisplayName,
-                PhotoUrl = userRecord.PhotoUrl,
-                Disabled = userRecord.Disabled,
-                CreatedAt = userRecord.CreatedAt,
-                LastLoginAt = userRecord.LastLoginAt,
-                ValidSince = userRecord.ValidSince,
-                CustomClaims = userRecord.CustomClaims,
-            };
+            get => this.passwordSalt;
         }
     }
-}
+}

FirebaseAdmin/FirebaseAdmin/Auth/ExportedUserRecords.cs

@@ -31,4 +31,4 @@ public sealed class ExportedUserRecords
         /// </summary>
         public List<ExportedUserRecord> Users { get; set; }
     }
-}
+}

FirebaseAdmin/FirebaseAdmin/Auth/FirebaseAuth.cs

@@ -357,9 +357,9 @@ public PagedAsyncEnumerable<ExportedUserRecords, ExportedUserRecord> ListUsersAs
         {
             var userManager = this.IfNotDeleted(() => this.userManager.Value);
 
-            var restPagedAsyncEnumerable = new RestPagedAsyncEnumerable<UserRecordServiceRequest, ExportedUserRecords, ExportedUserRecord>(
+            var restPagedAsyncEnumerable = new RestPagedAsyncEnumerable<ListUsersRequest, ExportedUserRecords, ExportedUserRecord>(
                 () => userManager.CreateUserRecordServiceRequest(requestOptions),
-                new UserRecordPageManager());
+                new ListUsersPageManager());
 
             return restPagedAsyncEnumerable;
         }

FirebaseAdmin/FirebaseAdmin/Auth/FirebaseUserManager.cs

@@ -99,9 +99,9 @@ public async Task<UserRecord> GetUserById(
             return new UserRecord(user);
         }
 
-        public UserRecordServiceRequest CreateUserRecordServiceRequest(ListUsersOptions requestOptions)
+        public ListUsersRequest CreateUserRecordServiceRequest(ListUsersOptions requestOptions)
         {
-            return new UserRecordServiceRequest(this.baseUrl, this.httpClient, requestOptions);
+            return new ListUsersRequest(this.baseUrl, this.httpClient, requestOptions);
         }
 
         /// <summary>

FirebaseAdmin/FirebaseAdmin/Auth/Internal/DownloadAccountResponse.cs

@@ -34,4 +34,4 @@ internal class DownloadAccountResponse
         [JsonProperty("users")]
         public List<GetAccountInfoResponse.User> Users { get; set; }
     }
-}
+}

FirebaseAdmin/FirebaseAdmin/Auth/Internal/GetAccountInfoResponse.cs

@@ -37,6 +37,18 @@ internal sealed class User
             [JsonProperty(PropertyName = "email")]
             public string Email { get; set; }
 
+            /// <summary>
+            /// Gets or sets the user's password hash.
+            /// </summary>
+            [JsonProperty(PropertyName = "passwordHash")]
+            public string PasswordHash { get; set; }
+
+            /// <summary>
+            /// Gets or sets the user's password salt.
+            /// </summary>
+            [JsonProperty(PropertyName = "salt")]
+            public string PasswordSalt { get; set; }
+
             /// <summary>
             /// Gets or sets the user's phone number.
             /// </summary>

FirebaseAdmin/FirebaseAdmin/Auth/ListUsersOptions.cs

@@ -35,4 +35,4 @@ public sealed class ListUsersOptions
         /// </summary>
         public string PageToken { get; set; }
     }
-}
+}

FirebaseAdmin/FirebaseAdmin/Auth/UserRecordPageManager.cs renamed to FirebaseAdmin/FirebaseAdmin/Auth/ListUsersPageManager.cs

@@ -17,14 +17,14 @@
 
 namespace FirebaseAdmin.Auth
 {
-    internal class UserRecordPageManager : IPageManager<UserRecordServiceRequest, ExportedUserRecords, ExportedUserRecord>
+    internal class ListUsersPageManager : IPageManager<ListUsersRequest, ExportedUserRecords, ExportedUserRecord>
     {
-        public void SetPageSize(UserRecordServiceRequest request, int pageSize)
+        public void SetPageSize(ListUsersRequest request, int pageSize)
         {
             request.SetPageSize(pageSize);
         }
 
-        public void SetPageToken(UserRecordServiceRequest request, string pageToken)
+        public void SetPageToken(ListUsersRequest request, string pageToken)
         {
             request.SetPageToken(pageToken);
         }
@@ -44,4 +44,4 @@ public string GetNextPageToken(ExportedUserRecords response)
             return string.IsNullOrEmpty(response.NextPageToken) ? null : response.NextPageToken;
         }
     }
-}
+}

FirebaseAdmin/FirebaseAdmin/Auth/UserRecordServiceRequest.cs renamed to FirebaseAdmin/FirebaseAdmin/Auth/ListUsersRequest.cs

@@ -26,13 +26,13 @@
 
 namespace FirebaseAdmin.Auth
 {
-    internal class UserRecordServiceRequest : IClientServiceRequest<ExportedUserRecords>
+    internal class ListUsersRequest : IClientServiceRequest<ExportedUserRecords>
     {
         private readonly string baseUrl;
         private readonly HttpClient httpClient;
         private readonly ListUsersOptions requestOptions;
 
-        internal UserRecordServiceRequest(string baseUrl, HttpClient httpClient, ListUsersOptions requestOptions)
+        internal ListUsersRequest(string baseUrl, HttpClient httpClient, ListUsersOptions requestOptions)
         {
             this.baseUrl = baseUrl;
             this.httpClient = httpClient;
@@ -113,7 +113,7 @@ public ExportedUserRecords Execute()
         private static ExportedUserRecords ConvertToExportedUserRecords(DownloadAccountResponse downloadAccountResponse)
         {
             var userRecords = new List<ExportedUserRecord>();
-            downloadAccountResponse.Users?.ForEach(u => userRecords.Add(ExportedUserRecord.CreateFrom(u)));
+            downloadAccountResponse.Users?.ForEach(u => userRecords.Add(new ExportedUserRecord(u)));
             return new ExportedUserRecords { NextPageToken = downloadAccountResponse.NextPageToken, Users = userRecords };
         }
 
@@ -178,4 +178,4 @@ private void AddOrUpdate(string paramName, string value)
             }
         }
     }
-}
+}

FirebaseAdmin/FirebaseAdmin/Auth/UserRecord.cs

@@ -25,7 +25,7 @@ namespace FirebaseAdmin.Auth
     /// Contains metadata associated with a Firebase user account. Instances
     /// of this class are immutable and thread safe.
     /// </summary>
-    public sealed class UserRecord : IUserInfo
+    public class UserRecord : IUserInfo
     {
         private const string PROVIDERID = "firebase";