improve unit tests

Author: nixj14

FirebaseAdmin/FirebaseAdmin.Tests/FirebaseAppTest.cs

@@ -104,7 +104,7 @@ public void CreateAppOptions()
             Assert.Same(credential, copy.Credential);
             Assert.Equal("test-project", copy.ProjectId);
             Assert.Equal("[email protected]", copy.ServiceAccountId);
-            Assert.Equal(typeof(MockHttpClientFactory), copy.HttpClientFactory.GetType());
+            Assert.Same(typeof(MockHttpClientFactory), copy.HttpClientFactory.GetType());
         }
 
         [Fact]
@@ -125,7 +125,21 @@ public void CreateAppOptionsNoClientFactory()
             Assert.Same(credential, copy.Credential);
             Assert.Equal("test-project", copy.ProjectId);
             Assert.Equal("[email protected]", copy.ServiceAccountId);
-            Assert.Equal(typeof(HttpClientFactory), copy.HttpClientFactory.GetType());
+            Assert.Same(typeof(HttpClientFactory), copy.HttpClientFactory.GetType());
+        }
+
+        [Fact]
+        public void NoHttpClientFactory()
+        {
+            var credential = GoogleCredential.FromAccessToken("token");
+            var options = new AppOptions()
+            {
+                Credential = credential,
+                ProjectId = "test-project",
+                ServiceAccountId = "[email protected]",
+                HttpClientFactory = null,
+            };
+            Assert.Throws<ArgumentNullException>(() => FirebaseApp.Create(options));
         }
 
         [Fact]

FirebaseAdmin/FirebaseAdmin.Tests/Messaging/FirebaseMessagingTest.cs

@@ -15,6 +15,7 @@
 using System;
 using System.Threading;
 using System.Threading.Tasks;
+using FirebaseAdmin.Tests;
 using Google.Apis.Auth.OAuth2;
 using Google.Apis.Http;
 using Xunit;
@@ -55,14 +56,25 @@ public void GetMessaging()
         }
 
         [Fact]
-        public void GetMessagingWithClientFactory()
+        public async Task GetMessagingWithClientFactory()
         {
-            var app = FirebaseApp.Create(new AppOptions() { Credential = MockCredential, HttpClientFactory = new HttpClientFactory() }, "MyApp");
+            var handler = new MockMessageHandler()
+            {
+                Response = new FirebaseMessagingClient.SendResponse()
+                {
+                    Name = "test-response",
+                },
+            };
+            var factory = new MockHttpClientFactory(handler);
+
+            var app = FirebaseApp.Create(new AppOptions() { Credential = GoogleCredential.FromAccessToken("test-token"), HttpClientFactory = factory, ProjectId = "test-project" });
             FirebaseMessaging messaging = FirebaseMessaging.GetMessaging(app);
             Assert.NotNull(messaging);
             Assert.Same(messaging, FirebaseMessaging.GetMessaging(app));
+
+            var response = await messaging.SendAsync(new Message() { Topic = "test-topic" });
+            Assert.Equal("test-response", response);
             app.Delete();
-            Assert.Throws<InvalidOperationException>(() => FirebaseMessaging.GetMessaging(app));
         }
 
         [Fact]
@@ -78,8 +90,7 @@ await Assert.ThrowsAsync<ObjectDisposedException>(
         [Fact]
         public async Task SendMessageCancel()
         {
-            var cred = GoogleCredential.FromFile("./resources/service_account.json");
-            FirebaseApp.Create(new AppOptions() { Credential = cred });
+            FirebaseApp.Create(new AppOptions() { Credential = MockCredential });
             var canceller = new CancellationTokenSource();
             canceller.Cancel();
             await Assert.ThrowsAsync<OperationCanceledException>(
@@ -90,8 +101,7 @@ await Assert.ThrowsAsync<OperationCanceledException>(
         [Fact]
         public async Task SendMessageCancelWithClientFactory()
         {
-            var cred = GoogleCredential.FromFile("./resources/service_account.json");
-            FirebaseApp.Create(new AppOptions() { Credential = cred, HttpClientFactory = new HttpClientFactory() });
+            FirebaseApp.Create(new AppOptions() { Credential = MockCredential, HttpClientFactory = new HttpClientFactory() });
             var canceller = new CancellationTokenSource();
             canceller.Cancel();
             await Assert.ThrowsAsync<OperationCanceledException>(