add .ConfigureAwait(false) to all async call (#109)

NiCoTinEz · hiranya911 · commit e9c8cad8013b · 2019-08-30T10:03:42.000-07:00
diff --git a/FirebaseAdmin/FirebaseAdmin/Auth/FirebaseAuth.cs b/FirebaseAdmin/FirebaseAdmin/Auth/FirebaseAuth.cs
@@ -112,7 +112,8 @@ public static FirebaseAuth GetAuth(FirebaseApp app)
         /// 128 characters.</param>
         public async Task<string> CreateCustomTokenAsync(string uid)
         {
-            return await this.CreateCustomTokenAsync(uid, default(CancellationToken));
+            return await this.CreateCustomTokenAsync(uid, default(CancellationToken))
+                .ConfigureAwait(false);
         }
 
         /// <summary>
@@ -151,7 +152,8 @@ public async Task<string> CreateCustomTokenAsync(string uid)
         public async Task<string> CreateCustomTokenAsync(
             string uid, CancellationToken cancellationToken)
         {
-            return await this.CreateCustomTokenAsync(uid, null, cancellationToken);
+            return await this.CreateCustomTokenAsync(uid, null, cancellationToken)
+                .ConfigureAwait(false);
         }
 
         /// <summary>
@@ -178,7 +180,8 @@ public async Task<string> CreateCustomTokenAsync(
         public async Task<string> CreateCustomTokenAsync(
             string uid, IDictionary<string, object> developerClaims)
         {
-            return await this.CreateCustomTokenAsync(uid, developerClaims, default(CancellationToken));
+            return await this.CreateCustomTokenAsync(uid, developerClaims, default(CancellationToken))
+                .ConfigureAwait(false);
         }
 
         /// <summary>
@@ -232,7 +235,8 @@ public async Task<string> CreateCustomTokenAsync(
         /// <param name="idToken">A Firebase ID token string to parse and verify.</param>
         public async Task<FirebaseToken> VerifyIdTokenAsync(string idToken)
         {
-            return await this.VerifyIdTokenAsync(idToken, default(CancellationToken));
+            return await this.VerifyIdTokenAsync(idToken, default(CancellationToken))
+                .ConfigureAwait(false);
         }
 
         /// <summary>
diff --git a/FirebaseAdmin/FirebaseAdmin/Auth/FirebaseUserManager.cs b/FirebaseAdmin/FirebaseAdmin/Auth/FirebaseUserManager.cs
@@ -101,7 +101,8 @@ internal async Task<UserRecord> GetUserByIdAsync(
                 Value = uid,
                 Label = "uid",
             };
-            return await this.GetUserAsync(query, cancellationToken);
+            return await this.GetUserAsync(query, cancellationToken)
+                .ConfigureAwait(false);
         }
 
         /// <summary>
@@ -124,7 +125,8 @@ internal async Task<UserRecord> GetUserByEmailAsync(
                 Field = "email",
                 Value = email,
             };
-            return await this.GetUserAsync(query, cancellationToken);
+            return await this.GetUserAsync(query, cancellationToken)
+                .ConfigureAwait(false);
         }
 
         /// <summary>
@@ -148,7 +150,8 @@ internal async Task<UserRecord> GetUserByPhoneNumberAsync(
                 Value = phoneNumber,
                 Label = "phone number",
             };
-            return await this.GetUserAsync(query, cancellationToken);
+            return await this.GetUserAsync(query, cancellationToken)
+                .ConfigureAwait(false);
         }
 
         internal PagedAsyncEnumerable<ExportedUserRecords, ExportedUserRecord> ListUsers(
diff --git a/FirebaseAdmin/FirebaseAdmin/Messaging/FirebaseMessaging.cs b/FirebaseAdmin/FirebaseAdmin/Messaging/FirebaseMessaging.cs
@@ -90,7 +90,8 @@ public static FirebaseMessaging GetMessaging(FirebaseApp app)
         /// <param name="message">The message to be sent. Must not be null.</param>
         public async Task<string> SendAsync(Message message)
         {
-            return await this.SendAsync(message, false);
+            return await this.SendAsync(message, false)
+                .ConfigureAwait(false);
         }
 
         /// <summary>
@@ -111,7 +112,8 @@ public async Task<string> SendAsync(Message message)
         /// operation.</param>
         public async Task<string> SendAsync(Message message, CancellationToken cancellationToken)
         {
-            return await this.SendAsync(message, false, cancellationToken);
+            return await this.SendAsync(message, false, cancellationToken)
+                .ConfigureAwait(false);
         }
 
         /// <summary>
@@ -137,7 +139,8 @@ public async Task<string> SendAsync(Message message, CancellationToken cancellat
         /// but it will not be delivered to any actual recipients.</param>
         public async Task<string> SendAsync(Message message, bool dryRun)
         {
-            return await this.SendAsync(message, dryRun, default(CancellationToken));
+            return await this.SendAsync(message, dryRun, default(CancellationToken))
+                .ConfigureAwait(false);
         }
 
         /// <summary>
@@ -182,7 +185,8 @@ public async Task<string> SendAsync(
         /// outcome.</returns>
         public async Task<BatchResponse> SendAllAsync(IEnumerable<Message> messages)
         {
-            return await this.SendAllAsync(messages, false);
+            return await this.SendAllAsync(messages, false)
+                .ConfigureAwait(false);
         }
 
         /// <summary>
@@ -199,7 +203,8 @@ public async Task<BatchResponse> SendAllAsync(IEnumerable<Message> messages)
         /// outcome.</returns>
         public async Task<BatchResponse> SendAllAsync(IEnumerable<Message> messages, CancellationToken cancellationToken)
         {
-            return await this.SendAllAsync(messages, false, cancellationToken);
+            return await this.SendAllAsync(messages, false, cancellationToken)
+                .ConfigureAwait(false);
         }
 
         /// <summary>
@@ -217,7 +222,8 @@ public async Task<BatchResponse> SendAllAsync(IEnumerable<Message> messages, Can
         /// outcome.</returns>
         public async Task<BatchResponse> SendAllAsync(IEnumerable<Message> messages, bool dryRun)
         {
-            return await this.SendAllAsync(messages, dryRun, default);
+            return await this.SendAllAsync(messages, dryRun, default)
+                .ConfigureAwait(false);
         }
 
         /// <summary>
@@ -237,7 +243,8 @@ public async Task<BatchResponse> SendAllAsync(IEnumerable<Message> messages, boo
         /// outcome.</returns>
         public async Task<BatchResponse> SendAllAsync(IEnumerable<Message> messages, bool dryRun, CancellationToken cancellationToken)
         {
-            return await this.messagingClient.SendAllAsync(messages, dryRun, cancellationToken);
+            return await this.messagingClient.SendAllAsync(messages, dryRun, cancellationToken)
+                .ConfigureAwait(false);
         }
 
         /// <summary>
@@ -250,7 +257,8 @@ public async Task<BatchResponse> SendAllAsync(IEnumerable<Message> messages, boo
         /// outcome.</returns>
         public async Task<BatchResponse> SendMulticastAsync(MulticastMessage message)
         {
-            return await this.SendMulticastAsync(message, false);
+            return await this.SendMulticastAsync(message, false)
+                .ConfigureAwait(false);
         }
 
         /// <summary>
@@ -265,7 +273,8 @@ public async Task<BatchResponse> SendMulticastAsync(MulticastMessage message)
         /// outcome.</returns>
         public async Task<BatchResponse> SendMulticastAsync(MulticastMessage message, CancellationToken cancellationToken)
         {
-            return await this.SendMulticastAsync(message, false, cancellationToken);
+            return await this.SendMulticastAsync(message, false, cancellationToken)
+                .ConfigureAwait(false);
         }
 
         /// <summary>
@@ -285,7 +294,8 @@ public async Task<BatchResponse> SendMulticastAsync(MulticastMessage message, Ca
         /// outcome.</returns>
         public async Task<BatchResponse> SendMulticastAsync(MulticastMessage message, bool dryRun)
         {
-            return await this.SendMulticastAsync(message, dryRun, default);
+            return await this.SendMulticastAsync(message, dryRun, default)
+                .ConfigureAwait(false);
         }
 
         /// <summary>
@@ -309,7 +319,8 @@ public async Task<BatchResponse> SendMulticastAsync(
             MulticastMessage message, bool dryRun, CancellationToken cancellationToken)
         {
             return await this.SendAllAsync(
-                message.GetMessageList(), dryRun, cancellationToken).ConfigureAwait(false);
+                message.GetMessageList(), dryRun, cancellationToken)
+                .ConfigureAwait(false);
         }
 
         /// <summary>
@@ -321,7 +332,8 @@ public async Task<BatchResponse> SendMulticastAsync(
         public async Task<TopicManagementResponse> SubscribeToTopicAsync(
             IReadOnlyList<string> registrationTokens, string topic)
         {
-            return await this.instanceIdClient.SubscribeToTopicAsync(registrationTokens, topic);
+            return await this.instanceIdClient.SubscribeToTopicAsync(registrationTokens, topic)
+                .ConfigureAwait(false);
         }
 
         /// <summary>
@@ -333,7 +345,8 @@ public async Task<TopicManagementResponse> SubscribeToTopicAsync(
         public async Task<TopicManagementResponse> UnsubscribeFromTopicAsync(
             IReadOnlyList<string> registrationTokens, string topic)
         {
-            return await this.instanceIdClient.UnsubscribeFromTopicAsync(registrationTokens, topic);
+            return await this.instanceIdClient.UnsubscribeFromTopicAsync(registrationTokens, topic)
+                .ConfigureAwait(false);
         }
 
         /// <summary>
diff --git a/FirebaseAdmin/FirebaseAdmin/Messaging/FirebaseMessagingClient.cs b/FirebaseAdmin/FirebaseAdmin/Messaging/FirebaseMessagingClient.cs
@@ -157,7 +157,8 @@ public async Task<BatchResponse> SendAllAsync(
 
             try
             {
-                return await this.SendBatchRequestAsync(copyOfMessages, dryRun, cancellationToken);
+                return await this.SendBatchRequestAsync(copyOfMessages, dryRun, cancellationToken)
+                    .ConfigureAwait(false);
             }
             catch (HttpRequestException e)
             {
@@ -192,7 +193,7 @@ private async Task<BatchResponse> SendBatchRequestAsync(
                     SendResponse sendResponse;
                     if (error != null)
                     {
-                        sendResponse = SendResponse.FromException(await this.CreateException(message));
+                        sendResponse = SendResponse.FromException(await this.CreateException(message).ConfigureAwait(false));
                     }
                     else if (content != null)
                     {

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,8 @@ public static FirebaseAuth GetAuth(FirebaseApp app)`
`112`	`112`	`/// 128 characters.</param>`
`113`	`113`	`public async Task<string> CreateCustomTokenAsync(string uid)`
`114`	`114`	`{`
`115`		`- return await this.CreateCustomTokenAsync(uid, default(CancellationToken));`
	`115`	`+ return await this.CreateCustomTokenAsync(uid, default(CancellationToken))`
	`116`	`+ .ConfigureAwait(false);`
`116`	`117`	`}`
`117`	`118`
`118`	`119`	`/// <summary>`
`@@ -151,7 +152,8 @@ public async Task<string> CreateCustomTokenAsync(string uid)`
`151`	`152`	`public async Task<string> CreateCustomTokenAsync(`
`152`	`153`	`string uid, CancellationToken cancellationToken)`
`153`	`154`	`{`
`154`		`- return await this.CreateCustomTokenAsync(uid, null, cancellationToken);`
	`155`	`+ return await this.CreateCustomTokenAsync(uid, null, cancellationToken)`
	`156`	`+ .ConfigureAwait(false);`
`155`	`157`	`}`
`156`	`158`
`157`	`159`	`/// <summary>`
`@@ -178,7 +180,8 @@ public async Task<string> CreateCustomTokenAsync(`
`178`	`180`	`public async Task<string> CreateCustomTokenAsync(`
`179`	`181`	`string uid, IDictionary<string, object> developerClaims)`
`180`	`182`	`{`
`181`		`- return await this.CreateCustomTokenAsync(uid, developerClaims, default(CancellationToken));`
	`183`	`+ return await this.CreateCustomTokenAsync(uid, developerClaims, default(CancellationToken))`
	`184`	`+ .ConfigureAwait(false);`
`182`	`185`	`}`
`183`	`186`
`184`	`187`	`/// <summary>`
`@@ -232,7 +235,8 @@ public async Task<string> CreateCustomTokenAsync(`
`232`	`235`	`/// <param name="idToken">A Firebase ID token string to parse and verify.</param>`
`233`	`236`	`public async Task<FirebaseToken> VerifyIdTokenAsync(string idToken)`
`234`	`237`	`{`
`235`		`- return await this.VerifyIdTokenAsync(idToken, default(CancellationToken));`
	`238`	`+ return await this.VerifyIdTokenAsync(idToken, default(CancellationToken))`
	`239`	`+ .ConfigureAwait(false);`
`236`	`240`	`}`
`237`	`241`
`238`	`242`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,8 @@ public static FirebaseMessaging GetMessaging(FirebaseApp app)`
`90`	`90`	`/// <param name="message">The message to be sent. Must not be null.</param>`
`91`	`91`	`public async Task<string> SendAsync(Message message)`
`92`	`92`	`{`
`93`		`- return await this.SendAsync(message, false);`
	`93`	`+ return await this.SendAsync(message, false)`
	`94`	`+ .ConfigureAwait(false);`
`94`	`95`	`}`
`95`	`96`
`96`	`97`	`/// <summary>`
`@@ -111,7 +112,8 @@ public async Task<string> SendAsync(Message message)`
`111`	`112`	`/// operation.</param>`
`112`	`113`	`public async Task<string> SendAsync(Message message, CancellationToken cancellationToken)`
`113`	`114`	`{`
`114`		`- return await this.SendAsync(message, false, cancellationToken);`
	`115`	`+ return await this.SendAsync(message, false, cancellationToken)`
	`116`	`+ .ConfigureAwait(false);`
`115`	`117`	`}`
`116`	`118`
`117`	`119`	`/// <summary>`
`@@ -137,7 +139,8 @@ public async Task<string> SendAsync(Message message, CancellationToken cancellat`
`137`	`139`	`/// but it will not be delivered to any actual recipients.</param>`
`138`	`140`	`public async Task<string> SendAsync(Message message, bool dryRun)`
`139`	`141`	`{`
`140`		`- return await this.SendAsync(message, dryRun, default(CancellationToken));`
	`142`	`+ return await this.SendAsync(message, dryRun, default(CancellationToken))`
	`143`	`+ .ConfigureAwait(false);`
`141`	`144`	`}`
`142`	`145`
`143`	`146`	`/// <summary>`
`@@ -182,7 +185,8 @@ public async Task<string> SendAsync(`
`182`	`185`	`/// outcome.</returns>`
`183`	`186`	`public async Task<BatchResponse> SendAllAsync(IEnumerable<Message> messages)`
`184`	`187`	`{`
`185`		`- return await this.SendAllAsync(messages, false);`
	`188`	`+ return await this.SendAllAsync(messages, false)`
	`189`	`+ .ConfigureAwait(false);`
`186`	`190`	`}`
`187`	`191`
`188`	`192`	`/// <summary>`
`@@ -199,7 +203,8 @@ public async Task<BatchResponse> SendAllAsync(IEnumerable<Message> messages)`
`199`	`203`	`/// outcome.</returns>`
`200`	`204`	`public async Task<BatchResponse> SendAllAsync(IEnumerable<Message> messages, CancellationToken cancellationToken)`
`201`	`205`	`{`
`202`		`- return await this.SendAllAsync(messages, false, cancellationToken);`
	`206`	`+ return await this.SendAllAsync(messages, false, cancellationToken)`
	`207`	`+ .ConfigureAwait(false);`
`203`	`208`	`}`
`204`	`209`
`205`	`210`	`/// <summary>`
`@@ -217,7 +222,8 @@ public async Task<BatchResponse> SendAllAsync(IEnumerable<Message> messages, Can`
`217`	`222`	`/// outcome.</returns>`
`218`	`223`	`public async Task<BatchResponse> SendAllAsync(IEnumerable<Message> messages, bool dryRun)`
`219`	`224`	`{`
`220`		`- return await this.SendAllAsync(messages, dryRun, default);`
	`225`	`+ return await this.SendAllAsync(messages, dryRun, default)`
	`226`	`+ .ConfigureAwait(false);`
`221`	`227`	`}`
`222`	`228`
`223`	`229`	`/// <summary>`
`@@ -237,7 +243,8 @@ public async Task<BatchResponse> SendAllAsync(IEnumerable<Message> messages, boo`
`237`	`243`	`/// outcome.</returns>`
`238`	`244`	`public async Task<BatchResponse> SendAllAsync(IEnumerable<Message> messages, bool dryRun, CancellationToken cancellationToken)`
`239`	`245`	`{`
`240`		`- return await this.messagingClient.SendAllAsync(messages, dryRun, cancellationToken);`
	`246`	`+ return await this.messagingClient.SendAllAsync(messages, dryRun, cancellationToken)`
	`247`	`+ .ConfigureAwait(false);`
`241`	`248`	`}`
`242`	`249`
`243`	`250`	`/// <summary>`
`@@ -250,7 +257,8 @@ public async Task<BatchResponse> SendAllAsync(IEnumerable<Message> messages, boo`
`250`	`257`	`/// outcome.</returns>`
`251`	`258`	`public async Task<BatchResponse> SendMulticastAsync(MulticastMessage message)`
`252`	`259`	`{`
`253`		`- return await this.SendMulticastAsync(message, false);`
	`260`	`+ return await this.SendMulticastAsync(message, false)`
	`261`	`+ .ConfigureAwait(false);`
`254`	`262`	`}`
`255`	`263`
`256`	`264`	`/// <summary>`
`@@ -265,7 +273,8 @@ public async Task<BatchResponse> SendMulticastAsync(MulticastMessage message)`
`265`	`273`	`/// outcome.</returns>`
`266`	`274`	`public async Task<BatchResponse> SendMulticastAsync(MulticastMessage message, CancellationToken cancellationToken)`
`267`	`275`	`{`
`268`		`- return await this.SendMulticastAsync(message, false, cancellationToken);`
	`276`	`+ return await this.SendMulticastAsync(message, false, cancellationToken)`
	`277`	`+ .ConfigureAwait(false);`
`269`	`278`	`}`
`270`	`279`
`271`	`280`	`/// <summary>`
`@@ -285,7 +294,8 @@ public async Task<BatchResponse> SendMulticastAsync(MulticastMessage message, Ca`
`285`	`294`	`/// outcome.</returns>`
`286`	`295`	`public async Task<BatchResponse> SendMulticastAsync(MulticastMessage message, bool dryRun)`
`287`	`296`	`{`
`288`		`- return await this.SendMulticastAsync(message, dryRun, default);`
	`297`	`+ return await this.SendMulticastAsync(message, dryRun, default)`
	`298`	`+ .ConfigureAwait(false);`
`289`	`299`	`}`
`290`	`300`
`291`	`301`	`/// <summary>`
`@@ -309,7 +319,8 @@ public async Task<BatchResponse> SendMulticastAsync(`
`309`	`319`	`MulticastMessage message, bool dryRun, CancellationToken cancellationToken)`
`310`	`320`	`{`
`311`	`321`	`return await this.SendAllAsync(`
`312`		`- message.GetMessageList(), dryRun, cancellationToken).ConfigureAwait(false);`
	`322`	`+ message.GetMessageList(), dryRun, cancellationToken)`
	`323`	`+ .ConfigureAwait(false);`
`313`	`324`	`}`
`314`	`325`
`315`	`326`	`/// <summary>`
`@@ -321,7 +332,8 @@ public async Task<BatchResponse> SendMulticastAsync(`
`321`	`332`	`public async Task<TopicManagementResponse> SubscribeToTopicAsync(`
`322`	`333`	`IReadOnlyList<string> registrationTokens, string topic)`
`323`	`334`	`{`
`324`		`- return await this.instanceIdClient.SubscribeToTopicAsync(registrationTokens, topic);`
	`335`	`+ return await this.instanceIdClient.SubscribeToTopicAsync(registrationTokens, topic)`
	`336`	`+ .ConfigureAwait(false);`
`325`	`337`	`}`
`326`	`338`
`327`	`339`	`/// <summary>`
`@@ -333,7 +345,8 @@ public async Task<TopicManagementResponse> SubscribeToTopicAsync(`
`333`	`345`	`public async Task<TopicManagementResponse> UnsubscribeFromTopicAsync(`
`334`	`346`	`IReadOnlyList<string> registrationTokens, string topic)`
`335`	`347`	`{`
`336`		`- return await this.instanceIdClient.UnsubscribeFromTopicAsync(registrationTokens, topic);`
	`348`	`+ return await this.instanceIdClient.UnsubscribeFromTopicAsync(registrationTokens, topic)`
	`349`	`+ .ConfigureAwait(false);`
`337`	`350`	`}`
`338`	`351`
`339`	`352`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,8 @@ public async Task<BatchResponse> SendAllAsync(`
`157`	`157`
`158`	`158`	`try`
`159`	`159`	`{`
`160`		`- return await this.SendBatchRequestAsync(copyOfMessages, dryRun, cancellationToken);`
	`160`	`+ return await this.SendBatchRequestAsync(copyOfMessages, dryRun, cancellationToken)`
	`161`	`+ .ConfigureAwait(false);`
`161`	`162`	`}`
`162`	`163`	`catch (HttpRequestException e)`
`163`	`164`	`{`
`@@ -192,7 +193,7 @@ private async Task<BatchResponse> SendBatchRequestAsync(`
`192`	`193`	`SendResponse sendResponse;`
`193`	`194`	`if (error != null)`
`194`	`195`	`{`
`195`		`- sendResponse = SendResponse.FromException(await this.CreateException(message));`
	`196`	`+ sendResponse = SendResponse.FromException(await this.CreateException(message).ConfigureAwait(false));`
`196`	`197`	`}`
`197`	`198`	`else if (content != null)`
`198`	`199`	`{`