From 305510ae65f115dc283d149261bfff0657b109d1 Mon Sep 17 00:00:00 2001 From: jonathanedey Date: Mon, 7 Jul 2025 15:18:45 -0400 Subject: [PATCH 1/4] chore: Update dependencies --- .../Auth/GetUsersTest.cs | 8 ++++---- .../FirebaseAdmin.IntegrationTests.csproj | 4 ++-- .../FirebaseAdmin.Snippets.csproj | 4 ++-- .../Auth/FirebaseAuthTest.cs | 3 ++- .../Auth/Users/EmailActionRequestTest.cs | 6 +++--- .../Auth/Users/FirebaseUserManagerTest.cs | 20 +++++++++---------- .../FirebaseAdmin.Tests.csproj | 4 ++-- 7 files changed, 25 insertions(+), 24 deletions(-) diff --git a/FirebaseAdmin/FirebaseAdmin.IntegrationTests/Auth/GetUsersTest.cs b/FirebaseAdmin/FirebaseAdmin.IntegrationTests/Auth/GetUsersTest.cs index 66324380..23a4d080 100644 --- a/FirebaseAdmin/FirebaseAdmin.IntegrationTests/Auth/GetUsersTest.cs +++ b/FirebaseAdmin/FirebaseAdmin.IntegrationTests/Auth/GetUsersTest.cs @@ -31,7 +31,7 @@ public GetUsersTest(GetUsersFixture fixture) } [Fact] - public async void VariousIdentifiers() + public async Task VariousIdentifiers() { var getUsersResult = await FirebaseAuth.DefaultInstance.GetUsersAsync( new List() @@ -56,7 +56,7 @@ public async void VariousIdentifiers() } [Fact] - public async void IgnoresNonExistingUsers() + public async Task IgnoresNonExistingUsers() { var doesntExistId = new UidIdentifier("uid_that_doesnt_exist"); var getUsersResult = await FirebaseAuth.DefaultInstance.GetUsersAsync( @@ -79,7 +79,7 @@ public async void IgnoresNonExistingUsers() } [Fact] - public async void OnlyNonExistingUsers() + public async Task OnlyNonExistingUsers() { var doesntExistId = new UidIdentifier("uid_that_doesnt_exist"); var getUsersResult = await FirebaseAuth.DefaultInstance.GetUsersAsync( @@ -93,7 +93,7 @@ public async void OnlyNonExistingUsers() } [Fact] - public async void DedupsDuplicateUsers() + public async Task DedupsDuplicateUsers() { var getUsersResult = await FirebaseAuth.DefaultInstance.GetUsersAsync( new List() diff --git a/FirebaseAdmin/FirebaseAdmin.IntegrationTests/FirebaseAdmin.IntegrationTests.csproj b/FirebaseAdmin/FirebaseAdmin.IntegrationTests/FirebaseAdmin.IntegrationTests.csproj index 1fc444ff..cdfd60ff 100644 --- a/FirebaseAdmin/FirebaseAdmin.IntegrationTests/FirebaseAdmin.IntegrationTests.csproj +++ b/FirebaseAdmin/FirebaseAdmin.IntegrationTests/FirebaseAdmin.IntegrationTests.csproj @@ -10,10 +10,10 @@ - + - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/FirebaseAdmin/FirebaseAdmin.Snippets/FirebaseAdmin.Snippets.csproj b/FirebaseAdmin/FirebaseAdmin.Snippets/FirebaseAdmin.Snippets.csproj index 8df6b1b7..14d9289e 100644 --- a/FirebaseAdmin/FirebaseAdmin.Snippets/FirebaseAdmin.Snippets.csproj +++ b/FirebaseAdmin/FirebaseAdmin.Snippets/FirebaseAdmin.Snippets.csproj @@ -10,8 +10,8 @@ - - + + diff --git a/FirebaseAdmin/FirebaseAdmin.Tests/Auth/FirebaseAuthTest.cs b/FirebaseAdmin/FirebaseAdmin.Tests/Auth/FirebaseAuthTest.cs index 3d780f9d..d98cc355 100644 --- a/FirebaseAdmin/FirebaseAdmin.Tests/Auth/FirebaseAuthTest.cs +++ b/FirebaseAdmin/FirebaseAdmin.Tests/Auth/FirebaseAuthTest.cs @@ -13,6 +13,7 @@ // limitations under the License. using System; +using System.Threading.Tasks; using FirebaseAdmin.Auth.Jwt; using Google.Apis.Auth.OAuth2; using Xunit; @@ -171,7 +172,7 @@ public void ServiceAccountId() } [Fact] - public async void InvalidCredential() + public async Task InvalidCredential() { var options = new AppOptions { diff --git a/FirebaseAdmin/FirebaseAdmin.Tests/Auth/Users/EmailActionRequestTest.cs b/FirebaseAdmin/FirebaseAdmin.Tests/Auth/Users/EmailActionRequestTest.cs index 73778fe1..97ec2038 100644 --- a/FirebaseAdmin/FirebaseAdmin.Tests/Auth/Users/EmailActionRequestTest.cs +++ b/FirebaseAdmin/FirebaseAdmin.Tests/Auth/Users/EmailActionRequestTest.cs @@ -92,7 +92,7 @@ public class EmailActionRequestTest }; [Fact] - public async void NoEmail() + public async Task NoEmail() { var handler = new MockMessageHandler() { Response = GenerateEmailLinkResponse }; var auth = this.CreateFirebaseAuth(handler); @@ -115,7 +115,7 @@ await Assert.ThrowsAsync( [Theory] [MemberData(nameof(InvalidActionCodeSettingsArgs))] - public async void InvalidActionCodeSettings(ActionCodeSettings settings) + public async Task InvalidActionCodeSettings(ActionCodeSettings settings) { var handler = new MockMessageHandler() { Response = GenerateEmailLinkResponse }; var auth = this.CreateFirebaseAuth(handler); @@ -264,7 +264,7 @@ public async Task PasswordResetLinkUnexpectedResponse() } [Fact] - public async void SignInWithEmailLinkNoSettings() + public async Task SignInWithEmailLinkNoSettings() { var handler = new MockMessageHandler() { Response = GenerateEmailLinkResponse }; var auth = this.CreateFirebaseAuth(handler); diff --git a/FirebaseAdmin/FirebaseAdmin.Tests/Auth/Users/FirebaseUserManagerTest.cs b/FirebaseAdmin/FirebaseAdmin.Tests/Auth/Users/FirebaseUserManagerTest.cs index 4b74fa75..198a4e78 100644 --- a/FirebaseAdmin/FirebaseAdmin.Tests/Auth/Users/FirebaseUserManagerTest.cs +++ b/FirebaseAdmin/FirebaseAdmin.Tests/Auth/Users/FirebaseUserManagerTest.cs @@ -1302,7 +1302,7 @@ public async Task NullClaims(TestConfig config) [Theory] [MemberData(nameof(TestConfigs))] - public async void ReservedClaims(TestConfig config) + public async Task ReservedClaims(TestConfig config) { var handler = new MockMessageHandler(); var auth = config.CreateAuth(handler); @@ -1321,7 +1321,7 @@ await Assert.ThrowsAsync( [Theory] [MemberData(nameof(TestConfigs))] - public async void UpdateUserNoUid(TestConfig config) + public async Task UpdateUserNoUid(TestConfig config) { var handler = new MockMessageHandler(); var auth = config.CreateAuth(handler); @@ -1335,7 +1335,7 @@ public async void UpdateUserNoUid(TestConfig config) [Theory] [MemberData(nameof(TestConfigs))] - public async void UpdateUserInvalidUid(TestConfig config) + public async Task UpdateUserInvalidUid(TestConfig config) { var handler = new MockMessageHandler(); var auth = config.CreateAuth(handler); @@ -1487,7 +1487,7 @@ public async Task UpdateUserShortPassword(TestConfig config) [Theory] [MemberData(nameof(TestConfigs))] - public async void EmptyNameClaims(TestConfig config) + public async Task EmptyNameClaims(TestConfig config) { var handler = new MockMessageHandler(); var auth = config.CreateAuth(handler); @@ -1502,7 +1502,7 @@ await Assert.ThrowsAsync( [Theory] [MemberData(nameof(TestConfigs))] - public async void LargeClaimsOverLimit(TestConfig config) + public async Task LargeClaimsOverLimit(TestConfig config) { var handler = new MockMessageHandler(); var auth = config.CreateAuth(handler); @@ -1732,7 +1732,7 @@ public async Task RevokeRefreshTokens(TestConfig config) [Theory] [MemberData(nameof(TestConfigs))] - public async void RevokeRefreshTokensNoUid(TestConfig config) + public async Task RevokeRefreshTokensNoUid(TestConfig config) { var handler = new MockMessageHandler() { Response = CreateUserResponse }; var auth = config.CreateAuth(handler); @@ -1745,7 +1745,7 @@ await Assert.ThrowsAsync( [Theory] [MemberData(nameof(TestConfigs))] - public async void RevokeRefreshTokensInvalidUid(TestConfig config) + public async Task RevokeRefreshTokensInvalidUid(TestConfig config) { var auth = config.CreateAuth(new MockMessageHandler()); @@ -1756,7 +1756,7 @@ await Assert.ThrowsAsync( [Theory] [MemberData(nameof(MainTenantTestConfigs))] - public async void CreateSessionCookieNoIdToken(TestConfig config) + public async Task CreateSessionCookieNoIdToken(TestConfig config) { var handler = new MockMessageHandler() { Response = "{}" }; var auth = (FirebaseAuth)config.CreateAuth(handler); @@ -1773,7 +1773,7 @@ await Assert.ThrowsAsync( [Theory] [MemberData(nameof(MainTenantTestConfigs))] - public async void CreateSessionCookieNoOptions(TestConfig config) + public async Task CreateSessionCookieNoOptions(TestConfig config) { var handler = new MockMessageHandler() { Response = "{}" }; var auth = (FirebaseAuth)config.CreateAuth(handler); @@ -1784,7 +1784,7 @@ await Assert.ThrowsAsync( [Theory] [MemberData(nameof(MainTenantTestConfigs))] - public async void CreateSessionCookieNoExpiresIn(TestConfig config) + public async Task CreateSessionCookieNoExpiresIn(TestConfig config) { var handler = new MockMessageHandler() { Response = "{}" }; var auth = (FirebaseAuth)config.CreateAuth(handler); diff --git a/FirebaseAdmin/FirebaseAdmin.Tests/FirebaseAdmin.Tests.csproj b/FirebaseAdmin/FirebaseAdmin.Tests/FirebaseAdmin.Tests.csproj index 65fba4a7..a7ced4e9 100644 --- a/FirebaseAdmin/FirebaseAdmin.Tests/FirebaseAdmin.Tests.csproj +++ b/FirebaseAdmin/FirebaseAdmin.Tests/FirebaseAdmin.Tests.csproj @@ -18,8 +18,8 @@ - - + + all runtime; build; native; contentfiles; analyzers; buildtransitive From fcdfa83385766431b45bf5f1d9f7d9c0ebdb3223 Mon Sep 17 00:00:00 2001 From: jonathanedey Date: Mon, 7 Jul 2025 15:20:23 -0400 Subject: [PATCH 2/4] fix: github actions status badge --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 401bb5e4..129e5428 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,5 @@ -[![Build Status](https://github.com/firebase/firebase-admin-dotnet/workflows/Continuous%20Integration/badge.svg)](https://github.com/firebase/firebase-admin-dotnet/actions) +[![Continuous Integration](https://github.com/firebase/firebase-admin-dotnet/actions/workflows/ci.yml/badge.svg)](https://github.com/firebase/firebase-admin-dotnet/actions/workflows/ci.yml) +[![Nightly Builds](https://github.com/firebase/firebase-admin-dotnet/actions/workflows/nightly.yml/badge.svg)](https://github.com/firebase/firebase-admin-dotnet/actions/workflows/nightly.yml) # Firebase Admin .NET SDK From a549ca6b8b0a0cfd6c288ef7fbc45b32e9e32021 Mon Sep 17 00:00:00 2001 From: jonathanedey Date: Mon, 7 Jul 2025 15:32:06 -0400 Subject: [PATCH 3/4] Trigger Integration Tests From 55cc4d90f0540c2a2301784a6718ebae3a010bc9 Mon Sep 17 00:00:00 2001 From: jonathanedey Date: Mon, 7 Jul 2025 18:21:48 -0400 Subject: [PATCH 4/4] fix: revert AspNetCore updates --- .../FirebaseAdmin.IntegrationTests.csproj | 2 +- .../FirebaseAdmin.Snippets/FirebaseAdmin.Snippets.csproj | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/FirebaseAdmin/FirebaseAdmin.IntegrationTests/FirebaseAdmin.IntegrationTests.csproj b/FirebaseAdmin/FirebaseAdmin.IntegrationTests/FirebaseAdmin.IntegrationTests.csproj index cdfd60ff..b8ad1725 100644 --- a/FirebaseAdmin/FirebaseAdmin.IntegrationTests/FirebaseAdmin.IntegrationTests.csproj +++ b/FirebaseAdmin/FirebaseAdmin.IntegrationTests/FirebaseAdmin.IntegrationTests.csproj @@ -10,7 +10,7 @@ - + diff --git a/FirebaseAdmin/FirebaseAdmin.Snippets/FirebaseAdmin.Snippets.csproj b/FirebaseAdmin/FirebaseAdmin.Snippets/FirebaseAdmin.Snippets.csproj index 14d9289e..8df6b1b7 100644 --- a/FirebaseAdmin/FirebaseAdmin.Snippets/FirebaseAdmin.Snippets.csproj +++ b/FirebaseAdmin/FirebaseAdmin.Snippets/FirebaseAdmin.Snippets.csproj @@ -10,8 +10,8 @@ - - + +