Skip to content

Commit 98554a5

Browse files
committed
cleanup debug logs
1 parent aeef210 commit 98554a5

File tree

3 files changed

+30
-36
lines changed

3 files changed

+30
-36
lines changed

auth/user_mgt.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1158,8 +1158,6 @@ func (c *baseClient) QueryUsers(ctx context.Context, query *QueryUsersRequest) (
11581158
return nil, err
11591159
}
11601160

1161-
//log.Printf("QueryUsers() with response = %d, %d", parsed.Count, len(parsed.Users))
1162-
11631161
var userRecords []*UserRecord
11641162
for _, user := range parsed.Users {
11651163
userRecord, err := user.makeUserRecord()
@@ -1525,8 +1523,6 @@ func (c *baseClient) post(
15251523
URL: url,
15261524
Body: internal.NewJSONEntity(payload),
15271525
}
1528-
//log.Printf("%+v \n", req.Body)
1529-
//log.Printf("%+v \n", resp)
15301526
return c.httpClient.DoAndUnmarshal(ctx, req, resp)
15311527
}
15321528

auth/user_mgt_test.go

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -2048,6 +2048,36 @@ func TestQueryUsersMalformedLastRefreshTimestamp(t *testing.T) {
20482048
}
20492049
}
20502050

2051+
func TestQueryUsersDefaultReturnUserInfo(t *testing.T) {
2052+
resp := `{
2053+
"userInfo": [{
2054+
"localId": "testuser"
2055+
}],
2056+
"recordsCount": "1"
2057+
}`
2058+
s := echoServer([]byte(resp), t)
2059+
defer s.Close()
2060+
2061+
// ReturnUserInfo is nil, should default to true in build()
2062+
query := &QueryUsersRequest{
2063+
Limit: 1,
2064+
}
2065+
2066+
_, err := s.Client.QueryUsers(context.Background(), query)
2067+
if err != nil {
2068+
t.Fatalf("QueryUsers() = %v", err)
2069+
}
2070+
2071+
var got map[string]interface{}
2072+
if err := json.Unmarshal(s.Rbody, &got); err != nil {
2073+
t.Fatal(err)
2074+
}
2075+
2076+
if got["returnUserInfo"] != true {
2077+
t.Errorf("QueryUsers() request[\"returnUserInfo\"] = %v; want true", got["returnUserInfo"])
2078+
}
2079+
}
2080+
20512081
func TestMakeExportedUser(t *testing.T) {
20522082
queryResponse := &userQueryResponse{
20532083
UID: "testuser",
@@ -2507,33 +2537,3 @@ func echoServer(resp interface{}, t *testing.T) *mockAuthServer {
25072537
func (s *mockAuthServer) Close() {
25082538
s.Srv.Close()
25092539
}
2510-
2511-
func TestQueryUsersDefaultReturnUserInfo(t *testing.T) {
2512-
resp := `{
2513-
"userInfo": [{
2514-
"localId": "testuser"
2515-
}],
2516-
"recordsCount": "1"
2517-
}`
2518-
s := echoServer([]byte(resp), t)
2519-
defer s.Close()
2520-
2521-
// ReturnUserInfo is nil, should default to true in build()
2522-
query := &QueryUsersRequest{
2523-
Limit: 1,
2524-
}
2525-
2526-
_, err := s.Client.QueryUsers(context.Background(), query)
2527-
if err != nil {
2528-
t.Fatalf("QueryUsers() = %v", err)
2529-
}
2530-
2531-
var got map[string]interface{}
2532-
if err := json.Unmarshal(s.Rbody, &got); err != nil {
2533-
t.Fatal(err)
2534-
}
2535-
2536-
if got["returnUserInfo"] != true {
2537-
t.Errorf("QueryUsers() request[\"returnUserInfo\"] = %v; want true", got["returnUserInfo"])
2538-
}
2539-
}

internal/http_client.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,8 +167,6 @@ func (c *HTTPClient) DoAndUnmarshal(ctx context.Context, req *Request, v interfa
167167
return nil, err
168168
}
169169

170-
//log.Printf("%+v \n", string(resp.Body))
171-
172170
if v != nil {
173171
if err := json.Unmarshal(resp.Body, v); err != nil {
174172
return nil, fmt.Errorf("error while parsing response: %v", err)

0 commit comments

Comments
 (0)