fix(auth): Fixed auth error code parsing (#712)

* fix(auth): Fixed auth error code parsing

* fix(auth): Fixed test to use error message prefix

Author: jonathanedey

auth/user_mgt.go

@@ -1510,7 +1510,7 @@ func parseErrorResponse(resp *internal.Response) (string, string) {
 	idx := strings.Index(code, ":")
 	if idx != -1 {
 		detail = strings.TrimSpace(code[idx+1:])
-		code = code[:idx]
+		code = strings.TrimSpace(code[:idx])
 	}
 
 	return code, detail

auth/user_mgt_test.go

@@ -2191,7 +2191,7 @@ func TestHTTPErrorWithCode(t *testing.T) {
 }
 
 func TestAuthErrorWithCodeAndDetails(t *testing.T) {
-	resp := []byte(`{"error":{"message":"USER_NOT_FOUND: extra details"}}`)
+	resp := []byte(`{"error":{"message":"USER_NOT_FOUND : extra details"}}`)
 	s := echoServer(resp, t)
 	defer s.Close()
 	s.Client.baseClient.httpClient.RetryConfig = nil

integration/auth/user_mgt_test.go

@@ -35,6 +35,7 @@ import (
 
 const (
 	continueURL        = "http://localhost/?a=1&b=2#c=3"
+	invalidContinueURL = "http://www.localhost/?a=1&b=2#c=3"
 	continueURLKey     = "continueUrl"
 	oobCodeKey         = "oobCode"
 	modeKey            = "mode"
@@ -1297,6 +1298,19 @@ func TestEmailSignInLink(t *testing.T) {
 	}
 }
 
+func TestAuthErrorParse(t *testing.T) {
+	user := newUserWithParams(t)
+	defer deleteUser(user.UID)
+	_, err := client.EmailSignInLink(context.Background(), user.Email, &auth.ActionCodeSettings{
+		URL:             invalidContinueURL,
+		HandleCodeInApp: false,
+	})
+	want := "domain of the continue url is not whitelisted: "
+	if err == nil || !auth.IsUnauthorizedContinueURI(err) || !strings.HasPrefix(err.Error(), want) {
+		t.Errorf("EmailSignInLink() expected error, got: %s, want: %s", err, want)
+	}
+}
+
 func resetPassword(email, oldPassword, newPassword, oobCode string) error {
 	req := map[string]interface{}{
 		"email":       email,