Address PR review comments

- Renamed factory methods in ParameterValue to ofRollout, ofPersonalization, and ofExperiment.
- Updated JSON key for experiment variant values to variantValue in TemplateResponse.

Author: google-labs-jules[bot]

src/main/java/com/google/firebase/remoteconfig/ParameterValue.java

@@ -62,7 +62,7 @@ public static InAppDefault inAppDefault() {
    * @param percent The percentage of the rollout.
    * @return A {@link ParameterValue.RolloutValue} instance.
    */
-  public static RolloutValue rollout(String rolloutId, String value, double percent) {
+  public static RolloutValue ofRollout(String rolloutId, String value, double percent) {
     return new RolloutValue(rolloutId, value, percent);
   }
 
@@ -72,7 +72,7 @@ public static RolloutValue rollout(String rolloutId, String value, double percen
    * @param personalizationId The personalization ID.
    * @return A {@link ParameterValue.PersonalizationValue} instance.
    */
-  public static PersonalizationValue personalization(String personalizationId) {
+  public static PersonalizationValue ofPersonalization(String personalizationId) {
     return new PersonalizationValue(personalizationId);
   }
 
@@ -83,7 +83,7 @@ public static PersonalizationValue personalization(String personalizationId) {
    * @param variantValues The list of experiment variant values.
    * @return A {@link ParameterValue.ExperimentValue} instance.
    */
-  public static ExperimentValue experiment(String experimentId,
+  public static ExperimentValue ofExperiment(String experimentId,
                                    List<ExperimentVariantValue> variantValues) {
     return new ExperimentValue(experimentId, variantValues);
   }
@@ -98,11 +98,11 @@ static ParameterValue fromParameterValueResponse(
     }
     if (parameterValueResponse.getRolloutValue() != null) {
       RolloutValueResponse rv = parameterValueResponse.getRolloutValue();
-      return ParameterValue.rollout(rv.getRolloutId(), rv.getValue(), rv.getPercent());
+      return ParameterValue.ofRollout(rv.getRolloutId(), rv.getValue(), rv.getPercent());
     }
     if (parameterValueResponse.getPersonalizationValue() != null) {
       PersonalizationValueResponse pv = parameterValueResponse.getPersonalizationValue();
-      return ParameterValue.personalization(pv.getPersonalizationId());
+      return ParameterValue.ofPersonalization(pv.getPersonalizationId());
     }
     if (parameterValueResponse.getExperimentValue() != null) {
       ExperimentValueResponse ev = parameterValueResponse.getExperimentValue();
@@ -112,7 +112,7 @@ static ParameterValue fromParameterValueResponse(
                 new ExperimentVariantValue(evv.getVariantId(), evv.getValue(),
                         evv.getNoChange()));
       }
-      return ParameterValue.experiment(ev.getExperimentId(), variantValues);
+      return ParameterValue.ofExperiment(ev.getExperimentId(), variantValues);
     }
     return ParameterValue.of(parameterValueResponse.getValue());
   }

src/main/java/com/google/firebase/remoteconfig/internal/TemplateResponse.java

@@ -285,7 +285,7 @@ public static final class ExperimentValueResponse {
     @Key("experimentId")
     private String experimentId;
 
-    @Key("experimentVariantValues")
+    @Key("variantValue")
     private List<ExperimentVariantValueResponse> experimentVariantValues;
 
     public String getExperimentId() {

src/test/java/com/google/firebase/remoteconfig/ParameterValueTest.java

@@ -43,7 +43,7 @@ public void testCreateInAppDefault() {
   @Test
   public void testCreateRolloutValue() {
     final ParameterValue.RolloutValue parameterValue =
-            ParameterValue.rollout("rollout_1", "value_1", 10.0);
+            ParameterValue.ofRollout("rollout_1", "value_1", 10.0);
 
     assertEquals("rollout_1", parameterValue.getRolloutId());
     assertEquals("value_1", parameterValue.getValue());
@@ -53,15 +53,15 @@ public void testCreateRolloutValue() {
   @Test
   public void testCreatePersonalizationValue() {
     final ParameterValue.PersonalizationValue parameterValue =
-            ParameterValue.personalization("personalization_1");
+            ParameterValue.ofPersonalization("personalization_1");
 
     assertEquals("personalization_1", parameterValue.getPersonalizationId());
   }
 
   @Test
   public void testCreateExperimentValue() {
     final ParameterValue.ExperimentValue parameterValue =
-            ParameterValue.experiment("experiment_1", ImmutableList.of(
+            ParameterValue.ofExperiment("experiment_1", ImmutableList.of(
                     ExperimentVariantValue.of("variant_1", "value_1"),
                     ExperimentVariantValue.ofNoChange("variant_2")
             ));
@@ -93,35 +93,35 @@ public void testEquality() {
     assertEquals(parameterValueFour, parameterValueFive);
 
     ParameterValue.RolloutValue rolloutValueOne =
-            ParameterValue.rollout("rollout_1", "value_1", 10.0);
+            ParameterValue.ofRollout("rollout_1", "value_1", 10.0);
     ParameterValue.RolloutValue rolloutValueTwo =
-            ParameterValue.rollout("rollout_1", "value_1", 10.0);
+            ParameterValue.ofRollout("rollout_1", "value_1", 10.0);
     ParameterValue.RolloutValue rolloutValueThree =
-            ParameterValue.rollout("rollout_2", "value_1", 10.0);
+            ParameterValue.ofRollout("rollout_2", "value_1", 10.0);
 
     assertEquals(rolloutValueOne, rolloutValueTwo);
     assertNotEquals(rolloutValueOne, rolloutValueThree);
 
     ParameterValue.PersonalizationValue personalizationValueOne =
-            ParameterValue.personalization("personalization_1");
+            ParameterValue.ofPersonalization("personalization_1");
     ParameterValue.PersonalizationValue personalizationValueTwo =
-            ParameterValue.personalization("personalization_1");
+            ParameterValue.ofPersonalization("personalization_1");
     ParameterValue.PersonalizationValue personalizationValueThree =
-            ParameterValue.personalization("personalization_2");
+            ParameterValue.ofPersonalization("personalization_2");
 
     assertEquals(personalizationValueOne, personalizationValueTwo);
     assertNotEquals(personalizationValueOne, personalizationValueThree);
 
     ParameterValue.ExperimentValue experimentValueOne =
-            ParameterValue.experiment("experiment_1", ImmutableList.of(
+            ParameterValue.ofExperiment("experiment_1", ImmutableList.of(
                     ExperimentVariantValue.of("variant_1", "value_1")
             ));
     ParameterValue.ExperimentValue experimentValueTwo =
-            ParameterValue.experiment("experiment_1", ImmutableList.of(
+            ParameterValue.ofExperiment("experiment_1", ImmutableList.of(
                     ExperimentVariantValue.of("variant_1", "value_1")
             ));
     ParameterValue.ExperimentValue experimentValueThree =
-            ParameterValue.experiment("experiment_2", ImmutableList.of(
+            ParameterValue.ofExperiment("experiment_2", ImmutableList.of(
                     ExperimentVariantValue.of("variant_1", "value_1")
             ));