Skip to content

Commit c7d68eb

Browse files
author
Varun Rathore
committed
fix lint error
1 parent d85247b commit c7d68eb

File tree

3 files changed

+42
-42
lines changed

3 files changed

+42
-42
lines changed

‎src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigClientImpl.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,7 @@ private String getETag(IncomingHttpResponse response) {
191191
List<String> etagList = (List<String>) response.getHeaders().get("etag");
192192
checkState(etagList != null && !etagList.isEmpty(),
193193
"ETag header is not available in the server response.");
194+
194195
String etag = etagList.get(0);
195196
checkState(!Strings.isNullOrEmpty(etag),
196197
"ETag header is not available in the server response.");
@@ -263,7 +264,7 @@ protected FirebaseRemoteConfigException createException(FirebaseException base)
263264
String response = getResponse(base);
264265
RemoteConfigServiceErrorResponse parsed = safeParse(response);
265266
return FirebaseRemoteConfigException.withRemoteConfigErrorCode(
266-
base, parsed.getRemoteConfigErrorCode());
267+
base, parsed.getRemoteConfigErrorCode());
267268
}
268269

269270
private String getResponse(FirebaseException base) {

‎src/test/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigClientImplTest.java‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import static org.junit.Assert.assertTrue;
2626
import static org.junit.Assert.fail;
2727

28+
import com.google.api.client.googleapis.util.Utils;
2829
import com.google.api.client.http.GenericUrl;
2930
import com.google.api.client.http.HttpHeaders;
3031
import com.google.api.client.http.HttpMethods;
@@ -41,6 +42,7 @@
4142
import com.google.firebase.FirebaseApp;
4243
import com.google.firebase.FirebaseOptions;
4344
import com.google.firebase.OutgoingHttpRequest;
45+
4446
import com.google.firebase.auth.MockGoogleCredentials;
4547
import com.google.firebase.internal.ApiClientUtils;
4648
import com.google.firebase.internal.SdkUtils;

‎src/test/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigTest.java‎

Lines changed: 38 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,11 @@
2727
import com.google.firebase.FirebaseOptions;
2828
import com.google.firebase.TestOnlyImplFirebaseTrampolines;
2929
import com.google.firebase.auth.MockGoogleCredentials;
30+
3031
import com.google.firebase.remoteconfig.internal.TemplateResponse;
32+
3133
import java.util.concurrent.ExecutionException;
34+
3235
import org.junit.After;
3336
import org.junit.Test;
3437

@@ -37,8 +40,7 @@
3740
* */
3841
public class FirebaseRemoteConfigTest {
3942

40-
private static final FirebaseOptions TEST_OPTIONS =
41-
FirebaseOptions.builder()
43+
private static final FirebaseOptions TEST_OPTIONS = FirebaseOptions.builder()
4244
.setCredentials(new MockGoogleCredentials("test-token"))
4345
.setProjectId("test-project")
4446
.build();
@@ -50,7 +52,7 @@ public class FirebaseRemoteConfigTest {
5052
+ " \"parameterGroups\": {}\n"
5153
+ "}";
5254
private static final FirebaseRemoteConfigException TEST_EXCEPTION =
53-
new FirebaseRemoteConfigException(ErrorCode.INTERNAL, "Test error message");
55+
new FirebaseRemoteConfigException(ErrorCode.INTERNAL, "Test error message");
5456

5557
@After
5658
public void tearDown() {
@@ -84,8 +86,7 @@ public void testDefaultRemoteConfigClient() {
8486

8587
assertTrue(client instanceof FirebaseRemoteConfigClientImpl);
8688
assertSame(client, remoteConfig.getRemoteConfigClient());
87-
String expectedUrl =
88-
"https://firebaseremoteconfig.googleapis.com/v1/projects/test-project/remoteConfig";
89+
String expectedUrl = "https://firebaseremoteconfig.googleapis.com/v1/projects/test-project/remoteConfig";
8990
assertEquals(expectedUrl, ((FirebaseRemoteConfigClientImpl) client).getRemoteConfigUrl());
9091
}
9192

@@ -121,16 +122,16 @@ public void testAppDelete() {
121122

122123
@Test
123124
public void testRemoteConfigClientWithoutProjectId() {
124-
FirebaseOptions options =
125-
FirebaseOptions.builder().setCredentials(new MockGoogleCredentials("test-token")).build();
125+
FirebaseOptions options = FirebaseOptions.builder()
126+
.setCredentials(new MockGoogleCredentials("test-token"))
127+
.build();
126128
FirebaseApp.initializeApp(options);
127129

128130
try {
129131
FirebaseRemoteConfig.getInstance();
130132
fail("No error thrown for missing project ID");
131133
} catch (IllegalArgumentException expected) {
132-
String message =
133-
"Project ID is required to access Remote Config service. Use a service "
134+
String message = "Project ID is required to access Remote Config service. Use a service "
134135
+ "account credential or set the project ID explicitly via FirebaseOptions. "
135136
+ "Alternatively you can also set the project ID via the GOOGLE_CLOUD_PROJECT "
136137
+ "environment variable.";
@@ -144,8 +145,8 @@ public void testRemoteConfigClientWithoutProjectId() {
144145

145146
@Test
146147
public void testGetTemplate() throws FirebaseRemoteConfigException {
147-
MockRemoteConfigClient client =
148-
MockRemoteConfigClient.fromTemplate(new Template().setETag(TEST_ETAG));
148+
MockRemoteConfigClient client = MockRemoteConfigClient.fromTemplate(
149+
new Template().setETag(TEST_ETAG));
149150
FirebaseRemoteConfig remoteConfig = getRemoteConfig(client);
150151

151152
Template template = remoteConfig.getTemplate();
@@ -167,8 +168,8 @@ public void testGetTemplateFailure() {
167168

168169
@Test
169170
public void testGetTemplateAsync() throws Exception {
170-
MockRemoteConfigClient client =
171-
MockRemoteConfigClient.fromTemplate(new Template().setETag(TEST_ETAG));
171+
MockRemoteConfigClient client = MockRemoteConfigClient.fromTemplate(
172+
new Template().setETag(TEST_ETAG));
172173
FirebaseRemoteConfig remoteConfig = getRemoteConfig(client);
173174

174175
Template template = remoteConfig.getTemplateAsync().get();
@@ -192,8 +193,8 @@ public void testGetTemplateAsyncFailure() throws InterruptedException {
192193

193194
@Test
194195
public void testGetTemplateAtVersionWithStringValue() throws FirebaseRemoteConfigException {
195-
MockRemoteConfigClient client =
196-
MockRemoteConfigClient.fromTemplate(new Template().setETag(TEST_ETAG));
196+
MockRemoteConfigClient client = MockRemoteConfigClient.fromTemplate(
197+
new Template().setETag(TEST_ETAG));
197198
FirebaseRemoteConfig remoteConfig = getRemoteConfig(client);
198199

199200
Template template = remoteConfig.getTemplateAtVersion("64");
@@ -215,8 +216,8 @@ public void testGetTemplateAtVersionWithStringValueFailure() {
215216

216217
@Test
217218
public void testGetTemplateAtVersionAsyncWithStringValue() throws Exception {
218-
MockRemoteConfigClient client =
219-
MockRemoteConfigClient.fromTemplate(new Template().setETag(TEST_ETAG));
219+
MockRemoteConfigClient client = MockRemoteConfigClient.fromTemplate(
220+
new Template().setETag(TEST_ETAG));
220221
FirebaseRemoteConfig remoteConfig = getRemoteConfig(client);
221222

222223
Template template = remoteConfig.getTemplateAtVersionAsync("55").get();
@@ -238,8 +239,8 @@ public void testGetTemplateAtVersionAsyncWithStringValueFailure() throws Interru
238239

239240
@Test
240241
public void testGetTemplateAtVersionWithLongValue() throws FirebaseRemoteConfigException {
241-
MockRemoteConfigClient client =
242-
MockRemoteConfigClient.fromTemplate(new Template().setETag(TEST_ETAG));
242+
MockRemoteConfigClient client = MockRemoteConfigClient.fromTemplate(
243+
new Template().setETag(TEST_ETAG));
243244
FirebaseRemoteConfig remoteConfig = getRemoteConfig(client);
244245

245246
Template template = remoteConfig.getTemplateAtVersion(64L);
@@ -261,8 +262,8 @@ public void testGetTemplateAtVersionWithLongValueFailure() {
261262

262263
@Test
263264
public void testGetTemplateAtVersionAsyncWithLongValue() throws Exception {
264-
MockRemoteConfigClient client =
265-
MockRemoteConfigClient.fromTemplate(new Template().setETag(TEST_ETAG));
265+
MockRemoteConfigClient client = MockRemoteConfigClient.fromTemplate(
266+
new Template().setETag(TEST_ETAG));
266267
FirebaseRemoteConfig remoteConfig = getRemoteConfig(client);
267268

268269
Template template = remoteConfig.getTemplateAtVersionAsync(55L).get();
@@ -430,8 +431,8 @@ public void testForcePublishTemplateAsyncFailure() throws InterruptedException {
430431

431432
@Test
432433
public void testRollbackWithStringValue() throws FirebaseRemoteConfigException {
433-
MockRemoteConfigClient client =
434-
MockRemoteConfigClient.fromTemplate(new Template().setETag(TEST_ETAG));
434+
MockRemoteConfigClient client = MockRemoteConfigClient.fromTemplate(
435+
new Template().setETag(TEST_ETAG));
435436
FirebaseRemoteConfig remoteConfig = getRemoteConfig(client);
436437

437438
Template template = remoteConfig.rollback("64");
@@ -453,8 +454,8 @@ public void testRollbackWithStringValueFailure() {
453454

454455
@Test
455456
public void testRollbackAsyncWithStringValue() throws Exception {
456-
MockRemoteConfigClient client =
457-
MockRemoteConfigClient.fromTemplate(new Template().setETag(TEST_ETAG));
457+
MockRemoteConfigClient client = MockRemoteConfigClient.fromTemplate(
458+
new Template().setETag(TEST_ETAG));
458459
FirebaseRemoteConfig remoteConfig = getRemoteConfig(client);
459460

460461
Template template = remoteConfig.rollbackAsync("55").get();
@@ -476,8 +477,8 @@ public void testRollbackAsyncWithStringValueFailure() throws InterruptedExceptio
476477

477478
@Test
478479
public void testRollbackWithLongValue() throws FirebaseRemoteConfigException {
479-
MockRemoteConfigClient client =
480-
MockRemoteConfigClient.fromTemplate(new Template().setETag(TEST_ETAG));
480+
MockRemoteConfigClient client = MockRemoteConfigClient.fromTemplate(
481+
new Template().setETag(TEST_ETAG));
481482
FirebaseRemoteConfig remoteConfig = getRemoteConfig(client);
482483

483484
Template template = remoteConfig.rollback(64L);
@@ -499,8 +500,8 @@ public void testRollbackWithLongValueFailure() {
499500

500501
@Test
501502
public void testRollbackAsyncWithLongValue() throws Exception {
502-
MockRemoteConfigClient client =
503-
MockRemoteConfigClient.fromTemplate(new Template().setETag(TEST_ETAG));
503+
MockRemoteConfigClient client = MockRemoteConfigClient.fromTemplate(
504+
new Template().setETag(TEST_ETAG));
504505
FirebaseRemoteConfig remoteConfig = getRemoteConfig(client);
505506

506507
Template template = remoteConfig.rollbackAsync(55L).get();
@@ -524,8 +525,7 @@ public void testRollbackAsyncWithLongValueFailure() throws InterruptedException
524525

525526
@Test
526527
public void testListVersionsWithNoOptions() throws FirebaseRemoteConfigException {
527-
MockRemoteConfigClient client =
528-
MockRemoteConfigClient.fromListVersionsResponse(
528+
MockRemoteConfigClient client = MockRemoteConfigClient.fromListVersionsResponse(
529529
new TemplateResponse.ListVersionsResponse().setNextPageToken("token"));
530530
FirebaseRemoteConfig remoteConfig = getRemoteConfig(client);
531531

@@ -548,8 +548,7 @@ public void testListVersionsWithNoOptionsFailure() {
548548

549549
@Test
550550
public void testListVersionsAsyncWithNoOptions() throws Exception {
551-
MockRemoteConfigClient client =
552-
MockRemoteConfigClient.fromListVersionsResponse(
551+
MockRemoteConfigClient client = MockRemoteConfigClient.fromListVersionsResponse(
553552
new TemplateResponse.ListVersionsResponse().setNextPageToken("token"));
554553
FirebaseRemoteConfig remoteConfig = getRemoteConfig(client);
555554

@@ -572,13 +571,12 @@ public void testListVersionsAsyncWithNoOptionsFailure() throws InterruptedExcept
572571

573572
@Test
574573
public void testListVersionsWithOptions() throws FirebaseRemoteConfigException {
575-
MockRemoteConfigClient client =
576-
MockRemoteConfigClient.fromListVersionsResponse(
574+
MockRemoteConfigClient client = MockRemoteConfigClient.fromListVersionsResponse(
577575
new TemplateResponse.ListVersionsResponse().setNextPageToken("token"));
578576
FirebaseRemoteConfig remoteConfig = getRemoteConfig(client);
579577

580-
ListVersionsPage listVersionsPage =
581-
remoteConfig.listVersions(ListVersionsOptions.builder().build());
578+
ListVersionsPage listVersionsPage = remoteConfig.listVersions(
579+
ListVersionsOptions.builder().build());
582580

583581
assertEquals("token", listVersionsPage.getNextPageToken());
584582
}
@@ -597,13 +595,12 @@ public void testListVersionsWithOptionsFailure() {
597595

598596
@Test
599597
public void testListVersionsAsyncWithOptions() throws Exception {
600-
MockRemoteConfigClient client =
601-
MockRemoteConfigClient.fromListVersionsResponse(
598+
MockRemoteConfigClient client = MockRemoteConfigClient.fromListVersionsResponse(
602599
new TemplateResponse.ListVersionsResponse().setNextPageToken("token"));
603600
FirebaseRemoteConfig remoteConfig = getRemoteConfig(client);
604601

605-
ListVersionsPage listVersionsPage =
606-
remoteConfig.listVersionsAsync(ListVersionsOptions.builder().build()).get();
602+
ListVersionsPage listVersionsPage = remoteConfig.listVersionsAsync(
603+
ListVersionsOptions.builder().build()).get();
607604

608605
assertEquals("token", listVersionsPage.getNextPageToken());
609606
}

0 commit comments

Comments
 (0)