Skip to content

feat(auth): Firebase Auth add link domain to actionCodeSetting #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Xiaoshouzi-gh
Copy link

@Xiaoshouzi-gh Xiaoshouzi-gh commented Jul 15, 2025

  • Add linkDomain to ActionCodeSettings, this allows developers to pass in customized Firebase Hosting Domains for applinks to open in mobile apps.
  • Added error code.

Edit: This PR also deprecates dynamicLinkDomain

@jonathanedey jonathanedey added the release:stage Stage a release candidate label Aug 8, 2025
@lahirumaramba lahirumaramba changed the title Firebase Auth add link domain to actionCodeSetting feat(auth): Firebase Auth add link domain to actionCodeSetting Aug 12, 2025
@lahirumaramba lahirumaramba self-requested a review August 12, 2025 15:34
@lahirumaramba lahirumaramba self-assigned this Aug 12, 2025
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's get a TW review on the docs. Thanks!

@jonathanedey jonathanedey requested a review from egilmorez August 12, 2025 16:12
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG with a literal nit, thanks!

public Builder setDynamicLinkDomain(String dynamicLinkDomain) {
this.dynamicLinkDomain = dynamicLinkDomain;
return this;
}

/**
* Sets the link domain to use for the current link if it is to be opened using
* HandleCodeInApp, as multiple link domains can be configured per project. This
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HandleCodeInApp looks like a literal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:stage Stage a release candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants