Remove unused local variables. (#659)

rsgowman · web-flow · commit 312c41a25885 · 2019-09-26T09:41:00.000-04:00
Also add option to tsconfig.json to prevent re-occurrences.
diff --git a/src/auth/auth-api-request.ts b/src/auth/auth-api-request.ts
@@ -37,12 +37,6 @@ import {
 import {Tenant, TenantOptions, TenantServerResponse} from './tenant';
 
 
-/** Firebase Auth backend host. */
-const FIREBASE_AUTH_HOST = 'www.googleapis.com';
-/** Firebase Auth backend port number. */
-const FIREBASE_AUTH_PORT = 443;
-/** Firebase Auth backend path. */
-const FIREBASE_AUTH_PATH = '/identitytoolkit/v3/relyingparty/';
 /** Firebase Auth request header. */
 const FIREBASE_AUTH_HEADER = {
   'X-Client-Version': 'Node/Admin/<XXX_SDK_VERSION_XXX>',
@@ -1491,7 +1485,7 @@ export class AuthRequestHandler extends AbstractAuthRequestHandler {
    * @param {FirebaseApp} app The app used to fetch access tokens to sign API requests.
    * @constructor.
    */
-  constructor(private readonly app: FirebaseApp) {
+  constructor(app: FirebaseApp) {
     super(app);
     this.tenantMgmtResourceBuilder =  new AuthResourceUrlBuilder(utils.getProjectId(app), 'v2beta1');
   }
diff --git a/src/auth/auth-config.ts b/src/auth/auth-config.ts
@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import * as utils from '../utils';
 import * as validator from '../utils/validator';
 import {deepCopy} from '../utils/deep-copy';
 import {AuthClientErrorCode, FirebaseAuthError} from '../utils/error';
diff --git a/src/auth/auth.ts b/src/auth/auth.ts
@@ -616,7 +616,7 @@ export class TenantAwareAuth extends BaseAuth<TenantAwareAuthRequestHandler> {
    * @param tenantId The corresponding tenant ID.
    * @constructor
    */
-  constructor(private readonly app: FirebaseApp, tenantId: string) {
+  constructor(app: FirebaseApp, tenantId: string) {
     super(
         utils.getProjectId(app),
         new TenantAwareAuthRequestHandler(app, tenantId),
diff --git a/src/auth/tenant.ts b/src/auth/tenant.ts
@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import * as utils from '../utils';
 import * as validator from '../utils/validator';
 import {AuthClientErrorCode, FirebaseAuthError} from '../utils/error';
 import {
diff --git a/src/instance-id/instance-id-request.ts b/src/instance-id/instance-id-request.ts
@@ -24,8 +24,6 @@ import * as validator from '../utils/validator';
 
 /** Firebase IID backend host. */
 const FIREBASE_IID_HOST = 'console.firebase.google.com';
-/** Firebase IID backend port number. */
-const FIREBASE_IID_PORT = 443;
 /** Firebase IID backend path. */
 const FIREBASE_IID_PATH = '/v1/';
 /** Firebase IID request timeout duration in milliseconds. */
@@ -49,7 +47,6 @@ const ERROR_CODES: {[key: number]: string} = {
 export class FirebaseInstanceIdRequestHandler {
 
   private readonly host: string = FIREBASE_IID_HOST;
-  private readonly port: number = FIREBASE_IID_PORT;
   private readonly timeout: number = FIREBASE_IID_TIMEOUT;
   private readonly httpClient: AuthorizedHttpClient;
   private readonly path: string;
diff --git a/src/messaging/messaging.ts b/src/messaging/messaging.ts
@@ -26,7 +26,7 @@ import {
 import {FirebaseMessagingRequestHandler} from './messaging-api-request';
 import {FirebaseServiceInterface, FirebaseServiceInternalsInterface} from '../firebase-service';
 import {
-  ErrorInfo, FirebaseArrayIndexError, MessagingClientErrorCode, FirebaseMessagingError,
+  ErrorInfo, MessagingClientErrorCode, FirebaseMessagingError,
 } from '../utils/error';
 
 import * as utils from '../utils';
@@ -160,7 +160,6 @@ function mapRawResponseToTopicManagementResponse(response: object): MessagingTop
     errors: [],
   };
 
-  const errors: FirebaseArrayIndexError[] = [];
   if ('results' in response) {
     (response as any).results.forEach((tokenManagementResult: any, index: number) => {
       // Map the FCM server's error strings to actual error objects.
diff --git a/test/integration/database.spec.ts b/test/integration/database.spec.ts
@@ -17,7 +17,6 @@
 import * as admin from '../../lib/index';
 import * as chai from 'chai';
 import * as chaiAsPromised from 'chai-as-promised';
-import url = require('url');
 import {defaultApp, nullApp, nonNullApp, cmdArgs, databaseUrl} from './setup';
 
 /* tslint:disable:no-var-requires */
@@ -172,11 +171,14 @@ describe('admin.database', () => {
   });
 });
 
+// Check for type compilation. This method is not invoked by any
+// tests. But it will trigger a TS compilation failure if the RTDB
+// typings were not loaded correctly.
+//
+// @ts-ignore: purposely unused method.
 function addValueEventListener(
     db: admin.database.Database,
     callback: (s: admin.database.DataSnapshot) => any) {
-  // Check for type compilation. This method is not invoked by any tests. But it will
-  // trigger a TS compilation failure if the RTDB typings were not loaded correctly.
   const eventType: admin.database.EventType = 'value';
   db.ref().on(eventType, callback);
 }
diff --git a/test/integration/setup.ts b/test/integration/setup.ts
@@ -19,7 +19,7 @@ import fs = require('fs');
 import minimist = require('minimist');
 import path = require('path');
 import {random} from 'lodash';
-import { Credential, CertCredential, GoogleOAuthAccessToken, Certificate } from '../../src/auth/credential';
+import { Credential, GoogleOAuthAccessToken, Certificate } from '../../src/auth/credential';
 
 /* tslint:disable:no-var-requires */
 const chalk = require('chalk');
diff --git a/test/unit/auth/action-code-settings-builder.spec.ts b/test/unit/auth/action-code-settings-builder.spec.ts
@@ -19,7 +19,6 @@ import * as chai from 'chai';
 import * as sinonChai from 'sinon-chai';
 import * as chaiAsPromised from 'chai-as-promised';
 
-import {deepCopy} from '../../../src/utils/deep-copy';
 import {ActionCodeSettingsBuilder} from '../../../src/auth/action-code-settings-builder';
 import {AuthClientErrorCode} from '../../../src/utils/error';
 
diff --git a/test/unit/auth/auth-api-request.spec.ts b/test/unit/auth/auth-api-request.spec.ts
@@ -2405,7 +2405,7 @@ AUTH_REQUEST_HANDLER_TESTS.forEach((handler) => {
         );
 
         const requestHandler = handler.init(mockApp);
-        return requestHandler.getEmailActionLink('EMAIL_SIGNIN', email)
+        return requestHandler.getEmailActionLink(invalidRequestType, email)
           .then((resp) => {
             throw new Error('Unexpected success');
           }, (error) => {
@@ -3780,7 +3780,6 @@ AUTH_REQUEST_HANDLER_TESTS.forEach((handler) => {
       describe('createTenant', () => {
         const path = '/v2beta1/projects/project_id/tenants';
         const postMethod = 'POST';
-        const tenantId = 'tenant-id';
         const tenantOptions: TenantOptions = {
           displayName: 'TENANT-DISPLAY-NAME',
           emailSignInConfig: {
diff --git a/test/unit/auth/auth-config.spec.ts b/test/unit/auth/auth-config.spec.ts
@@ -138,8 +138,8 @@ describe('EmailSignInConfig', () => {
       });
     });
 
-    const invalidPasswordRequired = [null, NaN, 0, 1, '', 'a', [], [1, 'a'], {}, { a: 1 }, _.noop];
-    invalidEnabled.forEach((passwordRequired) => {
+    const invalidPasswordRequired = invalidEnabled;
+    invalidPasswordRequired.forEach((passwordRequired) => {
       it('should throw on invalid EmailSignInConfig.passwordRequired:' + JSON.stringify(passwordRequired), () => {
         expect(() => {
           EmailSignInConfig.buildServerRequest({
diff --git a/test/unit/auth/auth.spec.ts b/test/unit/auth/auth.spec.ts
@@ -2652,7 +2652,6 @@ AUTH_CONFIGS.forEach((testConfig) => {
 
       describe('using SAML configurations', () => {
         const providerId = 'saml.provider';
-        const serverResponse = {};
         const expectedError = new FirebaseAuthError(AuthClientErrorCode.CONFIGURATION_NOT_FOUND);
 
         it('should resolve with void on success', () => {
diff --git a/test/unit/auth/tenant-manager.spec.ts b/test/unit/auth/tenant-manager.spec.ts
@@ -377,7 +377,6 @@ describe('TenantManager', () => {
   });
 
   describe('createTenant()', () => {
-    const tenantId = 'tenant-id';
     const tenantOptions: TenantOptions = {
       displayName: 'TENANT-DISPLAY-NAME',
       emailSignInConfig: {
diff --git a/test/unit/auth/tenant.spec.ts b/test/unit/auth/tenant.spec.ts
@@ -48,14 +48,6 @@ describe('Tenant', () => {
     },
   };
 
-  const tenantOptions: TenantOptions = {
-    displayName: 'TENANT-DISPLAY-NAME',
-    emailSignInConfig: {
-      enabled: true,
-      passwordRequired: false,
-    },
-  };
-
   describe('buildServerRequest()', () => {
     const createRequest = true;
 
diff --git a/test/unit/auth/user-import-builder.spec.ts b/test/unit/auth/user-import-builder.spec.ts
@@ -111,11 +111,6 @@ describe('UserImportBuilder', () => {
     },
   ];
 
-  const options = {
-    hash: {
-      algorithm: 'BCRYPT' as any,
-    },
-  };
   const hmacAlgorithms = ['HMAC_SHA512', 'HMAC_SHA256', 'HMAC_SHA1', 'HMAC_MD5'];
   const md5ShaPbkdfAlgorithms = [
     'MD5', 'SHA1', 'SHA256', 'SHA512', 'PBKDF_SHA1', 'PBKDF2_SHA256',
diff --git a/test/unit/firebase-app.spec.ts b/test/unit/firebase-app.spec.ts
@@ -16,9 +16,6 @@
 
 'use strict';
 
-// Use untyped import syntax for Node built-ins
-import https = require('https');
-
 import * as _ from 'lodash';
 import * as chai from 'chai';
 import * as sinon from 'sinon';
diff --git a/test/unit/firebase-namespace.spec.ts b/test/unit/firebase-namespace.spec.ts
@@ -519,7 +519,7 @@ describe('FirebaseNamespace', () => {
     });
 
     it('should return a valid namespace when the default app is initialized', () => {
-      const app: FirebaseApp = firebaseNamespace.initializeApp(mocks.appOptions);
+      firebaseNamespace.initializeApp(mocks.appOptions);
       const fs: Firestore = firebaseNamespace.firestore();
       expect(fs).to.not.be.null;
     });
diff --git a/test/unit/firestore/firestore.spec.ts b/test/unit/firestore/firestore.spec.ts
@@ -19,7 +19,6 @@
 import path = require('path');
 import * as _ from 'lodash';
 import {expect} from 'chai';
-import * as utils from '../../../src/utils/index';
 
 import * as mocks from '../../resources/mocks';
 import {FirebaseApp} from '../../../src/firebase-app';
diff --git a/tsconfig.json b/tsconfig.json
@@ -3,6 +3,7 @@
     "module": "commonjs",
     "target": "es5",
     "noImplicitAny": true,
+    "noUnusedLocals": true,
     "lib": ["es2015"],
     "outDir": "lib",
     // We manually craft typings in src/index.d.ts instead of auto-generating them.
