Commit 45905e4
authored
Enable 'strictNullChecks' ts compiler option. (#676)
* Enable 'structNullChecks' ts compiler option.
In the majority of cases, I simply turned stuff like this:
```
function fname(param: T) {
if (!param) throw Error("invalid param; must not be nullish");
...
}
```
into this:
```
function fname(param: T|null|undefined) {
if (!param) throw Error("invalid param; must not be nullish");
...
}
```
A more sensible approach would be eliminate the possibility of
null/undef and eliminate the checks too, but that's a bit more involved
and this patch is already enormous. But I think these sorts of
improvements could be taken advantage of opportunistically as the code
is worked on in the future.
* Add @firebase/auth-types to dev dependencies
And also update @firebase/auth to most recent to match.1 parent e231560 commit 45905e4
File tree
54 files changed
+547
-423
lines changed- src
- auth
- database
- firestore
- instance-id
- messaging
- project-management
- security-rules
- storage
- utils
- test
- integration
- resources
- unit
- auth
- firestore
- instance-id
- messaging
- project-management
- security-rules
- utils
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
54 files changed
+547
-423
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| 70 | + | |
70 | 71 | | |
71 | 72 | | |
72 | 73 | | |
| |||
0 commit comments