Upgraded Mocha to 5.x (#345)

* Upgraded Mocha to 5.x

* Implemented app clean up after tests

* Fixing a typo

Author: hiranya911

package-lock.json

@@ -13,8 +13,8 @@
     "lint": "run-p lint:src lint:unit lint:integration",
     "test": "run-s lint test:unit",
     "integration": "run-s build test:integration",
-    "test:unit": "mocha test/unit/*.spec.ts --compilers ts:ts-node/register",
-    "test:integration": "mocha test/integration/*.ts --slow 5000 --timeout 5000 --compilers ts:ts-node/register",
+    "test:unit": "mocha test/unit/*.spec.ts --require ts-node/register",
+    "test:integration": "mocha test/integration/*.ts --slow 5000 --timeout 5000 --require ts-node/register",
     "test:coverage": "nyc npm run test:unit",
     "lint:src": "tslint --format stylish -p tsconfig.json",
     "lint:unit": "tslint -c tslint-test.json --format stylish test/unit/*.ts test/unit/**/*.ts",
@@ -85,14 +85,13 @@
     "gulp-exit": "0.0.2",
     "gulp-header": "^1.8.8",
     "gulp-istanbul": "^1.1.3",
-    "gulp-mocha": "^3.0.1",
     "gulp-replace": "^0.5.4",
     "gulp-tslint": "^6.0.2",
     "gulp-typescript": "^3.2.4",
     "lodash": "^4.17.5",
     "merge2": "^1.2.1",
     "minimist": "^1.2.0",
-    "mocha": "^3.5.0",
+    "mocha": "^5.2.0",
     "nock": "^9.1.8",
     "npm-run-all": "^4.1.2",
     "nyc": "^11.5.0",

package.json

@@ -43,19 +43,20 @@ describe('admin.database', () => {
     }
     console.log(chalk.yellow('    Updating security rules to defaults.'));
     /* tslint:enable:no-console */
-    const client = new apiRequest.SignedApiRequestHandler(defaultApp);
+    const client = new apiRequest.AuthorizedHttpClient(defaultApp);
     const dbUrl =  url.parse(databaseUrl);
     const defaultRules = {
       rules : {
         '.read': 'auth != null',
         '.write': 'auth != null',
       },
     };
-    const headers = {
-      'Content-Type': 'application/json',
-    };
-    return client.sendRequest(dbUrl.host, 443, '/.settings/rules.json',
-      'PUT', defaultRules, headers, 10000);
+    return client.send({
+      url: `https://${dbUrl.host}/.settings/rules.json`,
+      method: 'PUT',
+      data: defaultRules,
+      timeout: 10000,
+    });
   });
 
   it('admin.database() returns a database client', () => {

test/integration/database.spec.ts

@@ -98,6 +98,15 @@ before(() => {
   cmdArgs = minimist(process.argv.slice(2));
 });
 
+after(() => {
+  return Promise.all([
+    defaultApp.delete(),
+    nullApp.delete(),
+    nonNullApp.delete(),
+    noServiceAccountApp.delete(),
+  ]);
+});
+
 class CertificatelessCredential implements Credential {
   private readonly delegate: admin.credential.Credential;