Skip to content

Commit 676f9a2

Browse files
committed
add valid request tests
1 parent 7985028 commit 676f9a2

File tree

1 file changed

+17
-6
lines changed

1 file changed

+17
-6
lines changed

test/unit/auth/passkey-config.spec.ts

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,9 @@ import * as chai from 'chai';
1919
import * as sinonChai from 'sinon-chai';
2020
import * as chaiAsPromised from 'chai-as-promised';
2121
import {
22-
PasskeyConfig, PasskeyConfigRequest, PasskeyConfigServerResponse,
22+
PasskeyConfig, PasskeyConfigRequest, PasskeyConfigServerResponse, PasskeyConfigClientRequest
2323
} from '../../../src/auth/passkey-config';
2424
import {deepCopy} from '../../../src/utils/deep-copy';
25-
import {ServerResponse} from 'http';
26-
import exp from 'constants';
2725

2826
chai.should();
2927
chai.use(sinonChai);
@@ -42,6 +40,15 @@ describe('PasskeyConfig', () => {
4240
};
4341
describe('buildServerRequest', () => {
4442
describe('for a create request', () => {
43+
const validRpId = 'project-id.firebaseapp.com';
44+
it('should create a client request with valid params', () => {
45+
const expectedRequest: PasskeyConfigClientRequest = {
46+
rpId: validRpId,
47+
expectedOrigins: passkeyConfigRequest.expectedOrigins,
48+
};
49+
expect(PasskeyConfig.buildServerRequest(true, passkeyConfigRequest, validRpId)).to.deep.equal(expectedRequest);
50+
});
51+
4552
const invalidRpId = [null, NaN, 0, 1, '', [], [1, 'a'], {}, { a: 1 }, _.noop];
4653
invalidRpId.forEach((rpId) => {
4754
it('should throw on invalid rpId {$rpId}', () => {
@@ -54,8 +61,14 @@ describe('PasskeyConfig', () => {
5461
it('should throw error if rpId is defined', () => {
5562
expect(PasskeyConfig.buildServerRequest(false, passkeyConfigRequest, 'project-id.firebaseapp.com')).to.throw(`'rpId' must be a valid non-empty string'`);
5663
});
57-
});
5864

65+
it('should create a client request with valid params', () => {
66+
const expectedRequest: PasskeyConfigClientRequest = {
67+
expectedOrigins: passkeyConfigRequest.expectedOrigins,
68+
};
69+
expect(PasskeyConfig.buildServerRequest(false, passkeyConfigRequest)).to.deep.equal(expectedRequest);
70+
});
71+
});
5972

6073
describe('for passkey config request', () => {
6174
const nonObjects = [null, NaN, 0, 1, true, false, '', 'a', [], [1, 'a'], _.noop];
@@ -104,8 +117,6 @@ describe('PasskeyConfig', () => {
104117
expect(passkeyConfig.rpId).to.equal(expectedServerResponse.rpId);
105118
expect(passkeyConfig.expectedOrigins).to.equal(expectedServerResponse.expectedOrigins);
106119
});
107-
108-
109120
});
110121

111122
describe('toJSON', () => {

0 commit comments

Comments
 (0)