Skip to content

Commit 6fa5219

Browse files
authored
fixing tests with unhandled promises (#894)
* fixing tests with unhandled promises
1 parent d985602 commit 6fa5219

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

test/integration/machine-learning.spec.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -244,11 +244,11 @@ describe('admin.machineLearning', () => {
244244
return uploadModelToGcs('model1.tflite', 'valid_model.tflite')
245245
.then((fileName: string) => {
246246
modelOptions.tfliteModel!.gcsTfliteUri = fileName;
247-
createTemporaryModel(modelOptions)
247+
return createTemporaryModel(modelOptions)
248248
.then((createdModel) => {
249249
expect(createdModel.validationError).to.be.empty;
250250
expect(createdModel.published).to.be.false;
251-
admin.machineLearning().publishModel(createdModel.modelId)
251+
return admin.machineLearning().publishModel(createdModel.modelId)
252252
.then((publishedModel) => {
253253
expect(publishedModel.published).to.be.true;
254254
});
@@ -279,14 +279,14 @@ describe('admin.machineLearning', () => {
279279
return uploadModelToGcs('model1.tflite', 'valid_model.tflite')
280280
.then((fileName: string) => {
281281
modelOptions.tfliteModel!.gcsTfliteUri = fileName;
282-
createTemporaryModel(modelOptions)
282+
return createTemporaryModel(modelOptions)
283283
.then((createdModel) => {
284284
expect(createdModel.validationError).to.be.empty;
285285
expect(createdModel.published).to.be.false;
286-
admin.machineLearning().publishModel(createdModel.modelId)
286+
return admin.machineLearning().publishModel(createdModel.modelId)
287287
.then((publishedModel) => {
288288
expect(publishedModel.published).to.be.true;
289-
admin.machineLearning().unpublishModel(publishedModel.modelId)
289+
return admin.machineLearning().unpublishModel(publishedModel.modelId)
290290
.then((unpublishedModel) => {
291291
expect(unpublishedModel.published).to.be.false;
292292
});

0 commit comments

Comments
 (0)