Setting noImplicitAny: true (#353)

* Setting noImplicitAny: true

* TS fixes in integration tests

* Disabling noImplicitAny again due to RTDB typing issue

* Added RTDB typings explicitly

* Added trace resolution

* Upgraded RTDB packages

Author: hiranya911

package-lock.json

@@ -52,8 +52,8 @@
   ],
   "types": "./lib/index.d.ts",
   "dependencies": {
-    "@firebase/app": "^0.3.1",
-    "@firebase/database": "^0.3.1",
+    "@firebase/app": "^0.3.4",
+    "@firebase/database": "^0.3.6",
     "@types/node": "^8.0.53",
     "jsonwebtoken": "8.1.0",
     "node-forge": "0.7.4"
@@ -64,14 +64,18 @@
     "@types/google-cloud__storage": "^1.7.1"
   },
   "devDependencies": {
+    "@types/bcrypt": "^2.0.0",
     "@types/chai": "^3.4.34",
     "@types/chai-as-promised": "0.0.29",
     "@types/firebase-token-generator": "^2.0.28",
+    "@types/jsonwebtoken": "^7.2.8",
     "@types/lodash": "^4.14.104",
+    "@types/minimist": "^1.2.0",
     "@types/mocha": "^2.2.48",
     "@types/nock": "^9.1.0",
     "@types/request": "^2.47.0",
     "@types/request-promise": "^4.1.41",
+    "@types/scrypt": "^6.0.0",
     "@types/sinon": "^4.1.3",
     "@types/sinon-chai": "^2.7.27",
     "bcrypt": "^3.0.0",
@@ -84,9 +88,7 @@
     "gulp": "^3.9.1",
     "gulp-exit": "0.0.2",
     "gulp-header": "^1.8.8",
-    "gulp-istanbul": "^1.1.3",
     "gulp-replace": "^0.5.4",
-    "gulp-tslint": "^6.0.2",
     "gulp-typescript": "^3.2.4",
     "lodash": "^4.17.5",
     "merge2": "^1.2.1",

package.json

@@ -238,7 +238,7 @@ function validateCreateEditRequest(request: any, uploadAccountRequest: boolean =
   // customAttributes should be stringified JSON with no blacklisted claims.
   // The payload should not exceed 1KB.
   if (typeof request.customAttributes !== 'undefined') {
-    let developerClaims;
+    let developerClaims: object;
     try {
       developerClaims = JSON.parse(request.customAttributes);
     } catch (error) {
@@ -247,7 +247,7 @@ function validateCreateEditRequest(request: any, uploadAccountRequest: boolean =
       // this field.
       throw new FirebaseAuthError(AuthClientErrorCode.INVALID_CLAIMS, error.message);
     }
-    const invalidClaims = [];
+    const invalidClaims: string[] = [];
     // Check for any invalid claims.
     RESERVED_CLAIMS.forEach((blacklistedClaim) => {
       if (developerClaims.hasOwnProperty(blacklistedClaim)) {
@@ -286,7 +286,7 @@ function validateCreateEditRequest(request: any, uploadAccountRequest: boolean =
       !validator.isArray(request.providerUserInfo)) {
     throw new FirebaseAuthError(AuthClientErrorCode.INVALID_PROVIDER_DATA);
   } else if (validator.isArray(request.providerUserInfo)) {
-    request.providerUserInfo.forEach((providerUserInfoEntry) => {
+    request.providerUserInfo.forEach((providerUserInfoEntry: any) => {
       validateProviderUserInfo(providerUserInfoEntry);
     });
   }
@@ -681,7 +681,7 @@ export class FirebaseAuthRequestHandler {
 
     // Parameters that are deletable and their deleteAttribute names.
     // Use client facing names, photoURL instead of photoUrl.
-    const deletableParams = {
+    const deletableParams: {[key: string]: string} = {
       displayName: 'DISPLAY_NAME',
       photoURL: 'PHOTO_URL',
     };

src/auth/auth-api-request.ts

@@ -220,7 +220,7 @@ export class Auth implements FirebaseServiceInterface {
         // List of users to return.
         const users: UserRecord[] = [];
         // Convert each user response to a UserRecord.
-        response.users.forEach((userResponse) => {
+        response.users.forEach((userResponse: any) => {
           users.push(new UserRecord(userResponse));
         });
         // Return list of user records and the next page token if available.

src/auth/auth.ts

@@ -52,7 +52,7 @@ const ONE_HOUR_IN_SECONDS = 60 * 60;
 const JWT_ALGORITHM = 'RS256';
 
 
-function copyAttr(to: object, from: object, key: string, alt: string) {
+function copyAttr(to: {[key: string]: any}, from: {[key: string]: any}, key: string, alt: string) {
   const tmp = from[key] || from[alt];
   if (typeof tmp !== 'undefined') {
     to[key] = tmp;

src/auth/credential.ts

@@ -253,7 +253,7 @@ export class FirebaseTokenGenerator {
    * @return {Promise<string>} A Promise fulfilled with a Firebase Auth Custom token signed with a
    *                           service account key and containing the provided payload.
    */
-  public createCustomToken(uid: string, developerClaims?: object): Promise<string> {
+  public createCustomToken(uid: string, developerClaims?: {[key: string]: any}): Promise<string> {
     let errorMessage: string;
     if (typeof uid !== 'string' || uid === '') {
       errorMessage = 'First argument to createCustomToken() must be a non-empty string uid.';
@@ -267,7 +267,7 @@ export class FirebaseTokenGenerator {
       throw new FirebaseAuthError(AuthClientErrorCode.INVALID_ARGUMENT, errorMessage);
     }
 
-    const claims = {};
+    const claims: {[key: string]: any} = {};
     if (typeof developerClaims !== 'undefined') {
       for (const key in developerClaims) {
         /* istanbul ignore else */

src/auth/token-generator.ts

@@ -68,7 +68,7 @@ export interface FirebaseTokenInfo {
  * Class for verifying general purpose Firebase JWTs. This verifies ID tokens and session cookies.
  */
 export class FirebaseTokenVerifier {
-  private publicKeys: object;
+  private publicKeys: {[key: string]: string};
   private publicKeysExpireAt: number;
   private readonly shortNameArticle: string;
 
@@ -234,7 +234,7 @@ export class FirebaseTokenVerifier {
     return new Promise((resolve, reject) => {
       jwt.verify(jwtToken, publicKey, {
         algorithms: [this.algorithm],
-      }, (error, decodedToken: any) => {
+      }, (error: any, decodedToken: any) => {
         if (error) {
           if (error.name === 'TokenExpiredError') {
             errorMessage = `${this.tokenInfo.jwtName} has expired. Get a fresh token from your client ` +
@@ -257,7 +257,7 @@ export class FirebaseTokenVerifier {
    *
    * @return {Promise<object>} A promise fulfilled with public keys for the Google certs.
    */
-  private fetchPublicKeys(): Promise<object> {
+  private fetchPublicKeys(): Promise<{[key: string]: string}> {
     const publicKeysExist = (typeof this.publicKeys !== 'undefined');
     const publicKeysExpiredExists = (typeof this.publicKeysExpireAt !== 'undefined');
     const publicKeysStillValid = (publicKeysExpiredExists && Date.now() < this.publicKeysExpireAt);

src/auth/token-verifier.ts

@@ -119,7 +119,7 @@ export interface UserImportResult {
 
 
 /** Callback function to validate an UploadAccountUser object. */
-type ValidatorFunction = (data: UploadAccountUser) => void;
+export type ValidatorFunction = (data: UploadAccountUser) => void;
 
 
 /**
@@ -191,7 +191,8 @@ function populateUploadAccountUser(
     });
   }
   // Remove blank fields.
-  for (const key in result) {
+  let key: keyof UploadAccountUser;
+  for (key in result) {
     if (typeof result[key] === 'undefined') {
       delete result[key];
     }
@@ -216,7 +217,7 @@ export class UserImportBuilder {
   private requiresHashOptions: boolean;
   private validatedUsers: UploadAccountUser[];
   private validatedOptions: UploadAccountOptions;
-  private indexMap: object;
+  private indexMap: {[key: number]: number};
   private userImportResultErrors: FirebaseArrayIndexError[];
 
   /**

src/auth/user-import-builder.ts

@@ -274,7 +274,7 @@ export class FirebaseApp {
 
     Object.keys(firebaseInternals_.serviceFactories).forEach((serviceName) => {
       // Defer calling createService() until the service is accessed
-      this[serviceName] = this.getService_.bind(this, serviceName);
+      (this as {[key: string]: any})[serviceName] = this.getService_.bind(this, serviceName);
     });
 
     this.INTERNAL = new FirebaseAppInternals(this.options_.credential);

src/firebase-app.ts

@@ -65,7 +65,7 @@ export class FirebaseNamespaceInternals {
   private apps_: {[appName: string]: FirebaseApp} = {};
   private appHooks_: {[service: string]: AppHook} = {};
 
-  constructor(public firebase_) {}
+  constructor(public firebase_: {[key: string]: any}) {}
 
   /**
    * Initializes the FirebaseApp instance.