Skip to content

Commit a767d9e

Browse files
authored
Upgraded sinon to latest (#161)
1 parent 09c47af commit a767d9e

File tree

3 files changed

+108
-51
lines changed

3 files changed

+108
-51
lines changed

package-lock.json

Lines changed: 103 additions & 46 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
"@types/nock": "^8.0.33",
6767
"@types/request": "2.0.6",
6868
"@types/request-promise": "^4.1.33",
69-
"@types/sinon": "^1.16.31",
69+
"@types/sinon": "^4.1.2",
7070
"@types/sinon-chai": "^2.7.27",
7171
"chai": "^3.5.0",
7272
"chai-as-promised": "^6.0.0",
@@ -91,7 +91,7 @@
9191
"request": "^2.75.0",
9292
"request-promise": "^4.1.1",
9393
"run-sequence": "^1.1.5",
94-
"sinon": "^1.17.3",
94+
"sinon": "^4.1.3",
9595
"sinon-chai": "^2.8.0",
9696
"ts-node": "^3.3.0",
9797
"tslint": "^3.5.0",

test/unit/auth/auth-api-request.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1628,7 +1628,7 @@ describe('FirebaseAuthRequestHandler', () => {
16281628
};
16291629

16301630
let stub = sinon.stub(HttpRequestHandler.prototype, 'sendRequest')
1631-
.returns(Promise.reject(mockErrorResponse));
1631+
.rejects(mockErrorResponse);
16321632
stubs.push(stub);
16331633

16341634
const requestHandler = new FirebaseAuthRequestHandler(mockApp);
@@ -1647,7 +1647,7 @@ describe('FirebaseAuthRequestHandler', () => {
16471647
};
16481648

16491649
let stub = sinon.stub(HttpRequestHandler.prototype, 'sendRequest')
1650-
.returns(Promise.reject(mockErrorResponse));
1650+
.rejects(mockErrorResponse);
16511651
stubs.push(stub);
16521652

16531653
const requestHandler = new FirebaseAuthRequestHandler(mockApp);
@@ -1664,7 +1664,7 @@ describe('FirebaseAuthRequestHandler', () => {
16641664
};
16651665

16661666
let stub = sinon.stub(HttpRequestHandler.prototype, 'sendRequest')
1667-
.returns(Promise.reject(mockErrorResponse));
1667+
.rejects(mockErrorResponse);
16681668
stubs.push(stub);
16691669

16701670
const requestHandler = new FirebaseAuthRequestHandler(mockApp);

0 commit comments

Comments
 (0)