address prod url comments

Author: stephenarosaj

src/data-connect/data-connect-api-client-internal.ts

@@ -26,14 +26,26 @@ import * as validator from '../utils/validator';
 import { ConnectorConfig, ExecuteGraphqlResponse, GraphqlOptions, OperationOptions } from './data-connect-api';
 
 const API_VERSION = 'v1';
+const FIREBASE_DATA_CONNECT_PROD_URL = 'https://firebasedataconnect.googleapis.com';
 
 /** The Firebase Data Connect backend service URL format. */
 const FIREBASE_DATA_CONNECT_SERVICES_URL_FORMAT =
-  'https://firebasedataconnect.googleapis.com/{version}/projects/{projectId}/locations/{locationId}/services/{serviceId}:{endpointId}';
+  FIREBASE_DATA_CONNECT_PROD_URL + 
+  '/{version}' + 
+  '/projects/{projectId}' + 
+  '/locations/{locationId}' + 
+  '/services/{serviceId}' + 
+  ':{endpointId}';
 
 /** The Firebase Data Connect backend connector URL format. */
 const FIREBASE_DATA_CONNECT_CONNECTORS_URL_FORMAT =
-  'https://firebasedataconnect.googleapis.com/{version}/projects/{projectId}/locations/{locationId}/services/{serviceId}/connectors/{connectorId}:{endpointId}';
+  FIREBASE_DATA_CONNECT_PROD_URL + 
+  '/{version}' + 
+  '/projects/{projectId}' + 
+  '/locations/{locationId}' + 
+  '/services/{serviceId}' + 
+  '/connectors/{connectorId}' + 
+  ':{endpointId}';
 
 /** Firebase Data Connect service URL format when using the Data Connect emulator. */
 const FIREBASE_DATA_CONNECT_EMULATOR_SERVICES_URL_FORMAT =

test/unit/data-connect/validate-admin-args.spec.ts

@@ -23,7 +23,7 @@ import {
   DATA_CONNECT_ERROR_CODE_MAPPING,
   FirebaseDataConnectError
 } from '../../../src/data-connect/data-connect-api-client-internal';
-import firebase from '@firebase/app-compat';
+import firebase, { FirebaseApp } from '@firebase/app-compat';
 import { projectId } from '../../resources/mocks';
 import { apiKey } from '../../integration/setup';
 
@@ -32,13 +32,17 @@ interface IdVars {
 }
 
 describe('validateAdminArgs()', () => {
+  let app: FirebaseApp;
   beforeEach(() => {
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    const app = firebase.initializeApp({
+    app = firebase.initializeApp({
       apiKey,
       authDomain: projectId + '.firebaseapp.com',
     });
   });
+
+  afterEach(() => {
+    app.delete();
+  });
 
   const connectorConfig: ConnectorConfig = {
     location: 'us-west2',