Skip to content

Commit db8be26

Browse files
Adds scrypt support in node 12 (#739)
* Adds scrypt support in node 12 Replaces scrypt npm module (no longer maintained and doesn't work for node 12) for testing standard scrypt with `crypto.scryptSync` which has been supported since node v10.5. * Fixes http timeout issues in node 12. * Updated CI config; Re-generated the package lock file Co-authored-by: hiranya911 <[email protected]>
1 parent c93893b commit db8be26

File tree

8 files changed

+727
-879
lines changed

8 files changed

+727
-879
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99

1010
strategy:
1111
matrix:
12-
node-version: [8.x, 10.x]
12+
node-version: [10.x]
1313

1414
steps:
1515
- uses: actions/checkout@v1

.github/workflows/release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
- name: Set up Node.js
4848
uses: actions/setup-node@v1
4949
with:
50-
node-version: 8.x
50+
node-version: 10.x
5151

5252
- name: Install and build
5353
run: |
@@ -112,7 +112,7 @@ jobs:
112112
- name: Set up Node.js
113113
uses: actions/setup-node@v1
114114
with:
115-
node-version: 8.x
115+
node-version: 10.x
116116

117117
- name: Publish preflight check
118118
id: preflight

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ information on using pull requests.
8787

8888
### Prerequisites
8989

90-
1. Node.js 8.13.0 or higher.
90+
1. Node.js 10.10.0 or higher.
9191
2. NPM 5 or higher (NPM 6 recommended).
9292
3. Google Cloud SDK ([`gcloud`](https://cloud.google.com/sdk/downloads) utility)
9393

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ requests, code review feedback, and also pull requests.
5555

5656
## Supported Environments
5757

58-
We support Node.js 8.13.0 and higher.
58+
We support Node.js 10.10.0 and higher.
5959

6060
Please also note that the Admin SDK should only
6161
be used in server-side/back-end environments controlled by the app developer.

0 commit comments

Comments
 (0)